`resolveCachedPath` ignores `origin` about rollup-plugin-includepaths

[fatfisz]

@darlanalves I think it should be ok to cache the file name along with the dirname of the origin.

The other idea I have is ignoring relative paths altogether, but that could possibly break some code. Still, I think that relative paths are outside the scope of what rollup-plugin-includepaths should be doing (because relative paths are already handled ok by other resolvers), but that's only an opinion.

[darlanalves]

Hello buddy :)

Nice spotting here! I'd never notice this bug.

I think it will break some build to completely remove the relative path resolution. Both "absolute" and relative path search are not only reduced to find a given path, but check for alternatives of it, e.g checking for a missing file extension. Removing the feature altogether would lead to a duplication of the plugin just for relative path search.

The simplest solution IMO would be just disable the caching of relative paths. That solves the issue while keeping the feature.

Now, caching the relative paths along with the origin could be better to speedup the search in cases that several modules require one common module in the same folder. It's really ease to add that too, in the method that resolves from cache.

What about this instead?
0b24e60#diff-a4f485aa834ca5b3c24819fceb39c56fL62

[fatfisz]

No problem, that works too and doesn't break anything. Thanks for the quick reply and a fix!

Btw. would you mind adding any packages that you are using to build the src/plugin.es5.js version of the plugin? That would be very helpful to potential contributors.

Also, would you consider using Map for the cache object while we are at that? It's better to use that instead of the plain object for dictionary-like data structures.

[darlanalves]

Surely :)
I did the plugin while researching the inner workings of rollup, and at time was too lazy to prepare a build setup. Right now I'm just copying/pasting in the Babel REPL and using the ES5 output 😁

I've published a new version on npm with the fix and a build step. Thanks a lot for finding it 👍

[fatfisz]

You're welcome 😄 I will close the issue and the PR as this is sorted out now.