earthsalamander42 / dota_imba

Repo for the development of Dota IMBA, a mod for Valve's Dota 2.

Dota IMBA

Repo for the development of Dota IMBA, a mod for Valve's Dota 2.

License

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

    http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.

Branching and copying

Feel free to create branches or copy the repo as you see fit for your uses. The repo is open source for a reason - you're free to use all abilities, items, et cetera provided here; just make sure to credit from where they came from.

Contributing to Dota IMBA

Currently we examine all suggestions before implementing them, on the IMBA development discord channel. You can send a message to me through Github in the link: https://github.com/EarthSalamander42, or PM me in either Dota IMBA's Reddit or Discord server for further details.

Feel free to just implement your suggestion/fix without talking to us, but please understand that there's a chance it might get ignored for game balance or other reasons. Thank you!

Also see the CONTRIBUTING files for conventions

Reporting bugs

Report bugs by opening issues in our dota imba site https://mods.frostrose-studio.com/. Registration is easy and short and it would be very helpful for us to track bugs.

dota_imba's Issues

Bane Brain Sap + OnSpellStart

Current: Bane's Brain Sap debuff is spending the extra mana after spells are cast.

Intended: the Brain Sap debuff should prevent a spell from being cast if the target does not have the necessary (increased) mana.

Problem: "OnSpellStart" modifier event not working - find a workaround or wait until it is fixed.

Make Tidebringer reduce Ebb and Flow's cooldown based on enemies hit

Currently reduces its own (Tidebringer) cooldown.

[BUG] Mjolnir gives -100 damage instead of +100

Add Test version as separate branch?

Would make it easy to fix rubick bugs etc, add experimental features.

Drow's scepter ultimate only updates changes after an enemy comes close

Make illusions inherit their owner's armlet state

Illusions currently spawn with an inactive armlet at all times

Bane Enfeeble + Refresher Orb

When applying Enfeeble on the same target twice (via Refresher Orb), only the -damage part of the debuff has its duration refreshed - the -stats% debuff ends prematurely.

nevermore does not gain souls when attacking nor when enemy heroes are around

I'm not sure if the souls are to be added to modifier_souls or modifier_souls_dummy
I am also quite confused between the two

Item builds

Make an IMBA basic recommended item build for heroes.
This should help newcomers know what they should pick and which items (new or old) match their hero's gameplay.

In time, the item build should be according to player suggestions.

Rapier confusion

The new rapiers can be improved by making them work exactly like Roshan's immortality does.
It doesn't take any inventory slot but if you die, the rapier "buff" is either dropped on the floor or the buff itself transfers to whoever killed the rapier holder.
So if a creep kill him, the creep get it 😛 No, but seriously...

I don't know how to implement this, the current rapier is confusing as hell for everyone I've played with, almost no1 buys it anymore.

Bounty Hunter's Shuriken Toss + refresher interaction

Skill works properly, but particles aren't properly erased when using refresher orb or -wtf mode.

Medallion needs correct particle when used on allies

Need some guide/help to start contributing (build/debug)

I would like to start contributing,
but im having trouble importing this project to dota workshoptools

currently im copying it to game\dota_addons
it does seem to start, but i cannot use dota_launch_custom_game to launch it

i see a bunch of entries in gitignore
are there any assets i need to copy over that are required?

any help would be appreciated :)

Liquid Fire can't be used when attacking towers

Bane + Fiend's Grip not piercing spell immunity

Fiend's Grip can target spell immune targets, but does nothing to them.

Wraith King cannot resurrect while under Ancient Apparition's Ice Blast

Abaddon's Illusions are beneffiting from borrowed time

Minor Lion bugs

Lion:

• Mana Drain can be targeted at creeps without mana
• Finger of Death Frog Panic ignores cast duration. This means there is no chance to avoid it for the targeted enemy.
• Mana drain particles are yuuuggee. They are also kinda weird. Not a fan.

datadriven items have their modifiers applied again when using the -respawn command (when testing).

Medallion of Courage's ally bonus armor doesn't work

title

Reverb Saber bug

Last game, as Warlock, I had the Reverb Saber buff until end of game. No one else seemed to have it, so it didn't appear to be a bug that affected anyone.

I have not had a chance to reproduce, but maybe giving the Reverb Saber to the golem while there were still attacks left caused Warlock to retain the buff indefinitely. I have put Reverb Sabers on golems for many games now, and this is the first time it has happened.

I will try to reproduce this Thursday.

Bane Fiend's Grip + Refresher Orb

Casting Fiend's Grip on any target already affected by it (via Refresher Orb) will make the second cast of the spell end prematurely.

Fix Jakiro's particles

reference: https://github.com/fcalife/dota_imba/pull/129

Motion Controllers must persist through death

Or server dies. Thanks for yahnich for mentioning that.
It should be fixed on Mirana's Leap, Slardar's Rip Current, and might be needed on Jakiro's Dual Breath.

We need to make sure all motion controllers are not stopped mid-motion.

Possible solution is to just add a CDOTA_Modifier_Lua:RemoveOnDeath flag on motion controller modifiers.

Bane Fiend's Grip + invisibility

Fiend's Grip should check for invisibility at the start of its cast, and apply true sight to the target for the duration if it is present.

Games can be paused and unpaused with no limit

Title.

People abuse this mechanic that allows them to keep pausing the games, ruining it for the rest of the players, because they think they're funny little retard kids.

Hand of Midas doesn't work

no bonus gold or exp.

Crimson guard active needs correct particle

dominator isn't granting bonus HP to dominated creeps

Tower ability description

Need to clarify which heroes (enemy of allies) affect the tower, or are affected by the tower.

drum of endurance active affecting only heroes

title

Force Tower perma-stun

For some reason, Force Tower perma-stuns his enemies. It may be that it doesn't use its cooldown.

armlet is not removing hp properly when disactivated

clinkz flaming arrows are passive but drows frost arrows not

this leads unequality between those two heroes, when clinkz silenced he continues with flaming arrows but drow have no similarity

Add IsNetherWardStealable()

When all heroes are IMBAfied, we want to move IMBA spells from the forbidden_abilities table to our own IsNetherWardStealable() function. Default is true, meaning the ward will steal and use it. Setting it to false will cause the ward to ignore the skill.

Github file structure

Hey, as I see through your code it's only the /game/dota_addons part and not the /content/dota_addons, meaning the only things here are compiled resources where you can't see the original coding. Could you perhaps have structure like eletd's github? https://github.com/Karawasa/Element-TD

Mirana's Moonlight Shadow fade delay indicator

Since SetDuration doesn't show changes when setting a smaller duration, the fade delay works but is not visible to users.

Should/would be probably solved with another modifier and some tweak on effects when someone affected with Moonlight Shadow attacks or casts a spell.

Add a global function for innate skills

Add a function in util.lua that handles innate skills, similar to CDOTA_BaseAbility:IsInnate().

It will default to false, but returning true will make it an innate ability.

IMBA 7.00 Bug Compilation Issue

Feel free to post anything here if you don't want to make a separate issue or something.

Silencer - this one's mine

• Some sound stuff that's played at the middle of the map;
• Ulti blows speakers, as I feared - use playsoundforclient; (FIXED)

Track particles must be hidden from enemy team

title

abaddon's aphotic shield charges recharge faster than the skill's cooldown

Kunkka torrent + Ghost Ship knockback bug

Pugna Nether Ward is not punishing.

Pugna Nether ward is doing nothing other then mana degen. Please fix it. Pugna is a fun hero

Drums need correct sound effect

mana break is burning mana on spell immune enemies and buildings.

Pipe's Barrier active is not displaying its particles properly

Allow spectators to zoom out

Spectators should be able to zoom out further, to allow them to see the entire battlefield on the screen. Especially needed on 10v10 battles.

Go through all stuns and flag them as such

In order to allow strong dispels (e.g. abaddon's aphotic shield) to dispel them.

crimson guard has no active

diffusal blade is an orb effect