Comments (4)
Hi @crackerplace. Happy to see you get involved with apm-server.
The first payload you mentioned is an interface. So I think passing it here as is should work as expected or do you see any unwanted side affects?
For the second line you mentioned it's passed as value as we only extract the data and don't modify it. Passing it by pointer would also work but I prefer in general if not pointer is need to pass a copy except it would become a performance issue.
from apm-server.
@ruflin thanks,Would be happy to contribute :-)
Sounds fine as we are passing a pointer to the struct payload which satisfies pr.Payload.
A simple better change would be to make payload as lower case at line as we are anywayz assigning it to an interface and need not be exported.It helps in understanding as well.What do you think ?
from apm-server.
Making it private SGTM assuming we don't need it anywhere else. Can you open a PR?
from apm-server.
@ruflin Sure.Will open.
from apm-server.
Related Issues (20)
- feat: support otlp/http JSON protobuf encoding
- apm-server binary is not statically linked HOT 1
- Support APM Server on Amazon Linux 2023
- [docs] Remove false deprecation note for standalone apm-server
- APM Server 8.13.0 Test Plan HOT 1
- Document release process with the automation workflow HOT 4
- [DOCS] Create openAPI specifications for public APM APIs
- Fix automation, bring back openAPI spec HOT 1
- API UI failing for error events derived from traces with Jaeger agent
- APM Server 8.14.0 Test Plan HOT 7
- ci: minor-release automation is not aligned with expectations HOT 4
- ci: minor-release automation does not sign commits HOT 3
- release: review test plan template
- Consider flattening headers and cookies HOT 8
- Perf regression, too many small bulk requests HOT 5
- Document 7.17.20 being broken for apm-server managed by Fleet with self-signed certificates HOT 1
- Fix/Improve APM Server Smoke Tests HOT 3
- APM Event Intake: All errors are considered exceptions. HOT 1
- APM Integration Check Not Compatible With Elastic APM Data Option HOT 3
- Flaky tests due to changes in the geoip database
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from apm-server.