eliraneliassy / bye-bye-ngmodules

Hi there 👋

bye-bye-ngmodules's Issues

Memory leak with HOC implementation

Hi Eliran,
It was good to go through your lecture on Bye Bye NgModules even though I like the simplicity of these module implementation.
I was going through your seminar and found that I could really use that HOC implementation you had demostrated it was absolute mind boggling truth be told.

So with your HOC implementation although it unsubscribes the subscription it fails to do so for the next component generation.

The code I'm referring to is below:-
https://github.com/eliraneliassy/bye-bye-ngmodules/blob/master/src/app/timer-example/unsubsribce.hoc.ts

With the above HOC it still shows multiple observables still running in the background (except the first one) when you destroy and revive the component multiple times.

So the HOC is instantiated only for the first component then? Or am I missing something? If you can clarify this that would be awesome and I can adopt this method to be precise in my prod application.