bye-bye-ngmodules's Issues
Memory leak with HOC implementation
Hi Eliran,
It was good to go through your lecture on Bye Bye NgModules even though I like the simplicity of these module implementation.
I was going through your seminar and found that I could really use that HOC implementation you had demostrated it was absolute mind boggling truth be told.
So with your HOC implementation although it unsubscribes the subscription it fails to do so for the next component generation.
The code I'm referring to is below:-
https://github.com/eliraneliassy/bye-bye-ngmodules/blob/master/src/app/timer-example/unsubsribce.hoc.ts
With the above HOC it still shows multiple observables still running in the background (except the first one) when you destroy and revive the component multiple times.
So the HOC is instantiated only for the first component then? Or am I missing something? If you can clarify this that would be awesome and I can adopt this method to be precise in my prod application.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.