GithubHelp home page GithubHelp logo

Comments (13)

Turbo87 avatar Turbo87 commented on June 1, 2024 1

@stefanpenner we discussed this in the call yesterday. the plan is to update this package to use terser for now and if we are confident that the dust has settled and terser is indeed the new thing to use we will rename it to broccoli-terser.

from broccoli-terser-sourcemap.

boris-petrov avatar boris-petrov commented on June 1, 2024

I actually managed to create another issue a couple of minutes before you. :) @stefanpenner, @mikrostew - ping. :)

from broccoli-terser-sourcemap.

stefanpenner avatar stefanpenner commented on June 1, 2024

@boris-petrov / @fabiosantoscode nice, thanks for letting us know. I'm fine with making this change, assuming we know what the differences are and if a minor/major bump is required.

If either of you have time to do ^ and report back, I can quickly release based on your findings.

from broccoli-terser-sourcemap.

stefanpenner avatar stefanpenner commented on June 1, 2024

It claims compat: https://github.com/fabiosantoscode/terser#note

from broccoli-terser-sourcemap.

boris-petrov avatar boris-petrov commented on June 1, 2024

I cannot tell for sure, I guess @fabiosantoscode can say more, but this is a fork which just continues the work of uglify-es so this could be a minor bump as there are no breaking changes and this will be practically invisible for end-users.

from broccoli-terser-sourcemap.

stefanpenner avatar stefanpenner commented on June 1, 2024

cc @Turbo87 / @rwjblue thoughts?

from broccoli-terser-sourcemap.

Turbo87 avatar Turbo87 commented on June 1, 2024

why was this forked?

from broccoli-terser-sourcemap.

stefanpenner avatar stefanpenner commented on June 1, 2024

maybe es6 support?

from broccoli-terser-sourcemap.

Turbo87 avatar Turbo87 commented on June 1, 2024

uglify-es already had ES6 support 🤔

from broccoli-terser-sourcemap.

stefanpenner avatar stefanpenner commented on June 1, 2024

🤷‍♂️

from broccoli-terser-sourcemap.

Turbo87 avatar Turbo87 commented on June 1, 2024

@stefanpenner for future reference: terser/terser#2

from broccoli-terser-sourcemap.

Turbo87 avatar Turbo87 commented on June 1, 2024

hmm, I'm wondering if we should fork this and make a broccoli-terser package instead of integrating it here. keeping the uglify name while using something else underneath might be confusing 🤔

from broccoli-terser-sourcemap.

stefanpenner avatar stefanpenner commented on June 1, 2024

@stefanpenner for future reference: terser/terser#2

Thanks, so it seems like its just the new version? Why not just major bump....

from broccoli-terser-sourcemap.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.