Comments (7)
Generally, it's also not an actual problem for me but there are two cases where it needs some care (not saying solving it is worth it ... I agree that the changelog
dir is somewhat confusing)
- when there was a release after opening the PR it's easy to forget to move the entry
- sometimes it's "hard" to remember to add to the unreleased section (t.b.h. should be a no-brainer but it happened to at least three people including me)
I'm really not too much in favor of the changelog-directory myself - just wanted to start a discussion
from esp-hal.
I think that a process change right now is probably not worth the effort. We can revisit this if we ever get too annoyed by the current solution.
from esp-hal.
I don't really see the need, I've never really found updating CHANGELOG.md
to be that problematic personally. I always do a cleanup pre-release, too.
If this is something that actually bothers people, somebody can set this up I guess. I found it confusing contributing to probe-rs
the first time though so we will need some docs (that nobody will read π).
from esp-hal.
probe-rs's solution has one big quality of life element: it's not necessary to manually specify the PR number. This makes it at least one step more convenient - after people learn how to use it. After getting used to, well I may not prefer it, but I find it to be a pretty good solution.
Thankfully people only need to bump against the idea once and they then seem to remember. Maybe because it's different? :)
from esp-hal.
I'd be happy with leaving the CHANGELOG update to the last commit, as that prevents conflicts while iterating on the PR. Unfortunately the big red X on my commits bother me too much to do that. π .
from esp-hal.
probe-rs's solution has one big quality of life element: it's not necessary to manually specify the PR number
Oh yes - that is quite convenient. Haven't thought about that
Unfortunately the big red X on my commits bother me too much to do that.
One thing we might should do at least is to not require it for draft PRs - I think we currently always check it
from esp-hal.
I guess if somebody wants to set up whatever infra we need for this, then add a CODEOWNERS
file please so that you can maintain it. Also please document the process somewhere, probably the top-level README.md
.
I honestly don't really want to do this, but if it's better for other people than I guess it's fine and I'll just suck it up and deal with it.
from esp-hal.
Related Issues (20)
- RFC: What to do about `async` vs `direct-vectoring` features? HOT 1
- Find a way to use ROM memset/memcpy - if it can't work, we should ensure memcpy and memset are in RAM somehow HOT 5
- TRNG #1200 breaks esp-wifi for ESP32-S2 HOT 1
- esp-hal 0.16.0 : Can't compile esp-wifi with the new esp-hal 0.16.0 HOT 3
- TWAI Overrun error when compiling in debug mode HOT 3
- Be explicit about the need to build using the `release` profile HOT 2
- Donβt forget to upgrade the defmt version in esp-backtrace and esp-println. HOT 1
- Automatically update the links and version numbers in the documentation index HOT 1
- Try to reduce duplicated code between `I2C`/`LP_I2C` drivers HOT 2
- Add ETM tasks and events for timers HOT 2
- The `resources/index.html` file should be converted to a template, and the packages and their versions should be populated dynamically.
- `UsbSerialJtag`s `core::fmt::Write` impl is blocking HOT 1
- Reading from ADC1 is broken once esp-wifi initialize() function has been called HOT 10
- RFC: Investigate the need for a lower-level layer of abstraction HOT 2
- Unclear behaviour of `GpioPin<Output<OpenDrain>, _>::is_high()` for ESP32 HOT 5
- Rng Initialization breaks ADC1 (at least on ESP32) HOT 4
- variant usage HOT 2
- Critical section crash HOT 6
- ESP32 & ESP32-S2: Wrong IΒ²C frequency
- Nightly CI is broken HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from esp-hal.