No implementation of `embedded_hal_async::spi::SpiDevice` in `esp32c3-hal` about esp-hal

[bjoernQ]

According to https://docs.rs/embedded-hal/1.0.0/embedded_hal/spi/index.html#for-hal-authors

HALs must implement SpiBus. Users can combine the bus together with the CS pin (which should implement OutputPin) using HAL-independent SpiDevice implementations such as the ones in embedded-hal-bus.

HALs may additionally implement SpiDevice to take advantage of hardware CS management, which may provide some performance benefits. (There’s no point in a HAL implementing SpiDevice if the CS management is software-only, this task is better left to the HAL-independent implementations).

I agree that we probably should implement SpiDevice since our hardware is capable of managing CS pins

TL;DR should be possible to use embedded-hal-bus with our implementation

[reivilibre]

TL;DR should be possible to use embedded-hal-bus with our implementation

This seems to be for embedded-hal rather than embedded-hal-async, unfortunately.

But you're right, that it seems like someone could make a very easy wrapper, particularly since the ESP32C3 implementation of SpiBus can manage the CS pin itself, the CS management could be a 'no-op'.

However it seems like this should be encoded directly in the type system of the ESP HAL: if the SpiBus has a CS pin attached, it ought to offer an SpiDevice interface (as well?).

[bjoernQ]

This seems to be for embedded-hal rather than embedded-hal-async, unfortunately.

There is an async feature: https://github.com/rust-embedded/embedded-hal/blob/04b4f1897a126d1f3aebf679489b60d8e994c839/embedded-hal-bus/Cargo.toml#L19

[reivilibre]

ah sorry, yes there is! Thanks :)

[jessebraham]

I don't think there's really anything actionable here so going to go ahead and close the issue. If you disagree feel free to re-open it.