GithubHelp home page GithubHelp logo

etherdelta.github.io's People

Contributors

etherdeg avatar zackcoburn avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

etherdelta.github.io's Issues

[macOS - Safari/Firefox] Site makes the browser window unresponsive on load

Yesterday I discovered EtherDelta and was checking it out in Safari, everything worked fine. I wanted to try it out so I installed MetaMask on Chrome and played with it for a while, just to see how the site works etc. Later that day I was back in Safari (Chrome and MetaMask were closed) and wanted to just check the orders/graphs on some tokens, but I couldn't get the site to work.

It loaded the basic DOM interface, but when it started to load the content (tokens, orders and basically everything) the site froze. Not only the site, but the entire tab it was open in. I couldn't refresh it, I couldn't go to a different website, I could only close the current tab to make Safari responding again.

I tried to open it in Firefox but it was the same as in Safari. Only browser that now works is Chrome with MetaMask installed (haven't yet tried it without MetaMask).
It kinda sucks for me because Safari is my main browser and I use Chrome/MetaMask only when I want to trade there. So when I just want to check the current prices and whatnot, I still have to open Chrome because it just won't load elsewhere.

The site always freezes when it starts loading all the stuff from the database and was working fine before I opened an account there using Chrome/MetaMask. I don't know how the site uses the local storage, but is it possible that the site is trying to connect to my MetaMask account even when I'm in different browser without MetaMask, causing the site to freeze?

Can't withdraw funds from EtherDelta

I can't withdraw ETH or tokens from EtherDelta, as my metamask says there are insufficient funds. I have 0.000798ETH left in my metamask wallet and 1.858ETH deposited on EtherDelta. Why can't I withdraw?

Browser remembers private key

Can I suggest that you change the private key field to a password field? The way it is now, anyone with access to my pc can click inside the empty public and private key fields and get their values. This is a pretty serious security risk in my opinion. I can't post screenshots without exposing my keys.

Thanks for your consideration.

Handling of pull requests in this project

Just puzzled about a pull request i've send to you and now it's conflicting because the changes have manually(?) been added to the code already? why is this handled that way?

#29

Feature Request: Account overview

It would be nice to be able to have an overview page of my etherdelta account that showed all balances on all tokens (ideally with the ability to filter out zero balances).

5vvsj

Data feed request

Is it possible to have access to the data feed to enable more sophisticated charts on a project I am working on?

Many thanks.

Brian

Negative fee for makers

To increment liquidity on the market could be a good idea set the maker fee negative,
like -0.025%

bitmex.com use the same strategy

Cheers

rounding to 5 decimals causes incorrect ETH amount shown for proposed trade

It is possible to place a resting order with more than 5 decimals of price. There are two problems:

  1. When this order is displayed it only shows 5 decimals.

  2. When you click on such an order to execute against it, the trade popup window displays an incorrect amount of base currency (usually ETH) for the trade. The error can be as high as 50% in the case of a trade price like 0.00001499.

For example, here is an order priced at 0.000071. Trade confirmation window:

screen shot 2017-07-13 at 12 09 13 pm

And trade result showing larger ETH value:

screen shot 2017-07-13 at 12 25 03 pm

FEED Token

I wasn't sure where else to get help with this. Apologies if this is the wrong place to ask but please help me add the investfeed token to EtherDelta. Thank you

Ticker: IFT
Contract Address: 0x7654915a1b82d6d2d0afc37c52af556ea8983c7e
Token Decimals: 18

https://www.investfeed.com/

Sell Order Shown as Complete, Order Still on Book, Funds from Trade Don't Exist

Open Orders
screen shot 2017-03-10 at 11 09 49 am

Completed Trades
screen shot 2017-03-10 at 11 09 45 am

"0/55" Implies it was not filled.
In the trades section, we see something implying the order was filled. When checking the block and transaction, we see the address in question does not own the tokens. Well, that makes sense, because the token would belong to the EtherDelta wallet, as it hasn't been withdrawn. Except...

screen shot 2017-03-10 at 11 14 25 am

Transaction
https://etherscan.io/tx/0xf30d3722e5b8e508bc2ac1fa80f4b2b6d580b0721a24caf6ffa10c8590aa8849

Wallet
https://etherscan.io/address/0x8768a6d20a85ab39efedb88b581115c3d0630a72

It's not adding up.

Require confirmation to forget accounts

I was contacted by a new Ethereum user today who tried using MetaMask and EtherDelta for the first time, to buy some VERI tokens.

She very patiently spent the whole day having a pretty hard time using our tools together.

She had a very hard time managing accounts. I've mentioned before that the current UI makes it a bit confusing which accounts were from MetaMask or from EtherDelta.

She got confused enough that eventually she selected Forget All Accounts, which allowed her to throw away all her private keys, including accounts that had funds deposited in EtherDelta.

At the very least, you should have a serious warning & confirmation before people can delete their private keys.

EtherDelta "buy orders" do not add up to the EtherDelta wallet (3 ETH worth)

I have ~ 3 ETH worth of tokens missing on buy orders made today. For instance, the buy orders add up to 134394.616 but only deposited 130618.437 worth of tokens. That works out to 3776.179 missing tokens. So, there's the technical issue, and there's the issue of the missing digits.

How might I proceed to help the project?

Moreover, how may I proceed to resolve my missing digits?

Thanks,

Monte

Broken

Tons of failed transactions
Most orders don't work
Order book very incorrect
Etherscan API keeps going offline

image

109.5 Populous disappeared into the etherdelta_2 wallet

This is an account that I made on etherdelta, about 27 days ago I moved 109.5 Populous into etherdelta2 wallet and somehow disappeared, or shall I say still in etherdelta2 wallet. When I do the math on the IN's to the wallet and the OUT's to the wallet I am exactly short 109.5 Populous and its not showing up in the Populous wallet on my etherdelta. This is a mystery to me since I am a noob but was wondering if anyone can explain this.
https://etherscan.io/address/0xf41b00dcf9440f4602fc9a0f8631c32c3b3831ef#tokentxns

this transaction is my 109.5 Populous going out to etherdelta2 wallet... and never going anywhere else.
https://etherscan.io/tx/0xd98f818d4da1afe9242ea8a26ef712855942e3e8a5e6983cec33c0db81a5288d

Is there a way to get the tokens back? Am I interpreting this all wrong? Please help, Ive been trying to figure it out for a month and cant find anyone else with the same issue.

Insufficient balance for transaction

Please make it possible to withdraw full ether and token balances by correctly subtracting the fee from the transfer amount.

Edit:
I can't even sell tokens to get enough ether to transfer out! ๐Ÿ˜ก

Blank EtherDelta page

I opened etherdelta about an hour ago to find that there are no buy/sell orders showing up. I have refreshed several times however there is still no action.

Example of placing a sell or buy order

The API (and its documentation) is extremely helpful for analyzing the history and state of the exchange. Could someone please show an example of how to place an order through either solidity or, if it's available an endpoint?

New asset

Hi, how can I incorporate my cryptomoneda to etherdelta?

result.times is not a function

Hello,

When i want to deposit some ETH from my wallet to Etherdelta, i have this error "result.times is not a function" or "Object doesn't support property or method 'times bundle.js (2648,7)".
I have this error on Edge, Chrome, Firefox on Windows 10 and Safari on macOS.

How to fetch exchange rate in a contract?

I've been sketching a margin trading addition to EtherDelta. This would allow users to lend their tokens for interest to traders who want to short sell.

Margin accounts are backed by collateral and can be liquidated by the creditor if the market value of collateral falls below a certain threshold. Do you have any ideas for fetching the exchange rate from, say, last 12 hours in a contract? Afaik, contracts cannot access the event log. Current order book depth would also help, but EtherDelta stores it mostly off-chain.

Incomplete and untested draft:
mmalmi@0eb1c33#diff-e438becd3bae07de17d35137485d8c3b

NaN

My account shows NaN in EtherDelta and Decentrex, what is the problem? Server down, or am I blocked?

Is Ether Delta working

For the past two days I cannot get onto Ether Delta, the site starts to load and then freezes.
Thoughts?

Transfer EMV

How to transfer EMV from etherdelta to cryptoderievatif?

Disable deposits to old smartcontracts

Over time, as the current smart contract has been updated, users are reccomended to withdraw their old tokens/Eth from the old contracts to deposit on the new.

The UI should make it difficult/impossible to deposit new Eth/tokens onto the old contract(s) when a new one is in use.

Open Trades not live updated

"You cannot trade this order because it already traded. Someone else already traded this order and the order book hasn't updated yet."

"You tried to send an Ethereum transaction but there was an error."

Trading is impossible.

  • is the developer fixing this?

Funds in EtherDelta wallet showing Zero Balance when funds are visibly there

I am trying to perform basic transactions / withdrawls after depositing funds from my Metamask wallet.

My funds are visibly there (1,34 ETH) however every transaction I try to initiate such as a trade or withdrawl, my funds in Metamask are displayed as 0 ETH. Why is that? I made my deposit hours ago and I can see it has successfully transferred. (590 confirmations) and the 1.34 ETH is on my Etherdelta column, but Why is it thats the funds are not usable, or displayed as zero?

Here's my initial Transaction ID: https://etherscan.io/tx/0x720d77d1113db7aa7ec1b5a8ccb414b3f7be4128ed4e55db9c231b2e41147882

Populous token address change

Contradictory to the original information give earlier, Populous token address is:

0xd4fa1460f537bb9085d22c7bccb5dd450ef28e3a

I kindly ask you to update this information on EtherScan, so Populous can start trading :)

About add korean language

I'm a big fan of etherdelta,
so I want to add korean language to etherdelta.
Can I make the pull request about it? :)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.