facebookarchive / fbkutils Goto Github PK

View Code? Open in Web Editor NEW

328.0 46.0 69.0 17.28 MB

A variety of utilities built and maintained by Facebook's Linux Kernel Team that we wish to share with the community.

License: Other

C 2.61% Makefile 0.05% Python 80.66% PostScript 12.29% Shell 4.39%

fbkutils's Issues

Completion of error handling

Would you like to add more error handling for return values from functions like the following?

pthread_mutex_init ⇒ create_worker_threads
sigaction ⇒ init_sighandlers

Checking if the key is in dictionary instead of using dict.get(key, -1)

https://github.com/facebook/fbkutils/blob/988bbdc252cd4c094be7a6e4241ca5f732db41fe/netesto/local/exp/exp.py#L191-L194

Some places in this file fbkutils/netesto/local/exp/exp.py has check if a key is in the dictionary and then tries to access it. It may be inefficient and less clean to go through the dictionary twice. Can I raise a PR to change these to

 def getFieldIndex(s):
   return fieldDict.get(s, -1)

@vmagro

AttributeError: 'dict' object has no attribute 'correctness_tests'

When executing schbench, or other benchmarks as far as I can tell, throws the following error:

AttributeError: 'dict' object has no attribute 'correctness_tests'

After some investigation seems to be that all benchmarks return a dict object containing the
metrics, and benchpress/cli/commands/run.py calls a non-existing function on it called correctness_tests().

Unsuccessful make

Attempting to run make, making sure I had glibc installed, this is the output of the make logs.

make[1]: Entering directory '/home/xlaits/git/fbkutils/netconsd/modules'
g++ logger.cc -std=c++11 -O2 -D_GNU_SOURCE -fno-strict-aliasing -Wall -Wextra -Wmissing-declarations -Wno-missing-field-initializers -Wno-unused-parameter -fPIC -I../../ncrx -I../include -lpthread -lrt -ldl -c -o logger.o
logger.cc: In constructor 'logtarget::logtarget(in6_addr*)':
logger.cc:78:12: error: 'stderr' was not declared in this scope
   78 |    fprintf(stderr, "FATAL: open() failed: %m\n");
      |            ^~~~~~
logger.cc:28:1: note: 'stderr' is defined in header '<cstdio>'; did you forget to '#include <cstdio>'?
   27 | #include <jhash.h>
  +++ |+#include <cstdio>
   28 | 
logger.cc:78:4: error: 'fprintf' was not declared in this scope
   78 |    fprintf(stderr, "FATAL: open() failed: %m\n");
      |    ^~~~~~~
logger.cc: In function 'void write_log(logtarget&, msg_buf*, ncrx_msg*)':
logger.cc:119:3: error: 'dprintf' was not declared in this scope
  119 |   dprintf(tgt.fd, "%s\n", buf->buf);
      |   ^~~~~~~
logger.cc:121:3: error: 'dprintf' was not declared in this scope
  121 |   dprintf(tgt.fd, "%06lu %014lu %d %d %s%s%s%s%s\n", msg->seq,
      |   ^~~~~~~
make[1]: *** [Makefile:20: logger.so] Error 1
make[1]: Leaving directory '/home/xlaits/git/fbkutils/netconsd/modules'
make: *** [Makefile:47: mods] Error 2```

File explicitly closed can be replaced with"with open(file, 'r')" syntax

https://github.com/facebook/fbkutils/blob/988bbdc252cd4c094be7a6e4241ca5f732db41fe/netesto/local/processExp.py#L207-L216

The file fbkutils/netesto/local/processExp.py has the above code, which closes the file explictly. It can be replace by the following code. Why use with open syntax

with open(field_fn, 'r')  as fin:
   for iline in fin: 
     line = iline.strip() 
     if len(line) == 0: 
         continue 
     if line[0] != '#': 
         field = line.split(':') 
         fieldList.append(field[0]) 
         fieldOpDict[field[0]] = field[1]

reserved identifier violation

I would like to point out that identifiers like “__LISTENER_H__” and “__OUTPUT_H__” do not fit to the expected naming convention of the C language standard.
Would you like to adjust your selection for unique names?

facebookarchive / fbkutils Goto Github PK

fbkutils's Issues

Completion of error handling

Checking if the key is in dictionary instead of using dict.get(key, -1)

AttributeError: 'dict' object has no attribute 'correctness_tests'

Unsuccessful make

File explicitly closed can be replaced with"with open(file, 'r')" syntax

reserved identifier violation

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

Jobs