Odin inspector 3 not supported (UnityEngine.ExitGUIException) about unity-addressable-importer

[Mefodei]

@Mefodei ODIN related issue, guess you may want to have a look?

Yes, i will try to check this one

[tamarillostudio]

• com.unity.addresasbles version : 1.16.7
• com.littlebigfun.addressable-importer version : 0.9.3
• odin version : 3.0.1.0
• exception details
  it occurs on click save button. It looks not affect save function.
  UnityEngine.ExitGUIException: Exception of type 'UnityEngine.ExitGUIException' was thrown.
  at Sirenix.OdinInspector.Editor.InspectorProperty.Draw (UnityEngine.GUIContent defaultLabel) [0x00493] in X:\Repositories\sirenix-development\Sirenix Solution\Sirenix.OdinInspector.Editor\Core\InspectorProperty.cs:837
  at Sirenix.OdinInspector.Editor.PropertyTree.DrawProperties () [0x00019] in X:\Repositories\sirenix-development\Sirenix Solution\Sirenix.OdinInspector.Editor\Core\PropertyTree.cs:485
  at Sirenix.OdinInspector.Editor.PropertyTree.Draw (System.Boolean applyUndo) [0x00007] in X:\Repositories\sirenix-development\Sirenix Solution\Sirenix.OdinInspector.Editor\Core\PropertyTree.cs:389
  at UnityAddressableImporter.Editor.Helper.AddressableImporterFilterOdinHandler.Draw () [0x0000f] in /TestProject/Library/PackageCache/[email protected]/Editor/OdinSupport/AddressableImporterFilterOdinHandler.cs:56
  UnityEngine.Debug:LogError(Object)
  UnityAddressableImporter.Editor.Helper.AddressableImporterFilterOdinHandler:Draw() (at Library/PackageCache/[email protected]/Editor/OdinSupport/AddressableImporterFilterOdinHandler.cs:60)
  UnityAddressableImporter.Editor.Helper.AddressableImporterOdinHandler:DrawInspectorTree(String) (at Library/PackageCache/[email protected]/Editor/OdinSupport/AddressableImporterOdinHandler.cs:49)
  UnityAddressableImporter.Editor.Helper.AddressableImporterOdinHandler:Draw() (at Library/PackageCache/[email protected]/Editor/OdinSupport/AddressableImporterOdinHandler.cs:26)
  UnityAddressableImporter.Helper.Internal.AddressableImportSettingsEditor:DrawBaseEditor() (at Library/PackageCache/[email protected]/Editor/Helper/AddressableImportSettingsEditor.cs:57)
  UnityAddressableImporter.Helper.Internal.AddressableImportSettingsEditor:OnInspectorGUI() (at Library/PackageCache/[email protected]/Editor/Helper/AddressableImportSettingsEditor.cs:42)
  UnityEngine.GUIUtility:ProcessEvent(Int32, IntPtr, Boolean&) (at /Users/bokken/buildslave/unity/build/Modules/IMGUI/GUIUtility.cs:189)

[Mefodei]

@favoyang
#53

[issue-label-bot]

Issue-Label Bot is automatically applying the label bug to this issue, with a confidence of 0.91. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

[favoyang]

Please provide

• com.unity.addresasbles version
• com.littlebigfun.addressable-importer version
• odin version
• exception details

[favoyang]

@Mefodei ODIN related issue, guess you may want to have a look?

[favoyang]

Hi @tamarillostudio,

Sorry for the long delay. I have made a simple change related to ODIN (f8d9bba), but it only affects the initial importer error.

I don't have an issue when hit the save button.

• com.unity.addresasbles version : 1.16.15
• com.littlebigfun.addressable-importer version : 0.9.4
• ODIN version : 3.0.2
• Unity 2020.2.0f1

Could you give 0.9.4 a try and also upgrade ODIN to 3.0.2?

[Mefodei]

That issue on Odin inspector side. They already fix that in v. 3.0.2

[favoyang]

@Mefodei thanks for verifying the issue. Issue closed.

[favoyang]

We have a new duplicated new issue #46. I tested with

• addressables 1.16.19
• odin 3.0.5.0
• importer 0.9.4

I still get the same error.

UnityEngine.ExitGUIException: Exception of type 'UnityEngine.ExitGUIException' was thrown.

I checked related odin patch notes: https://odininspector.com/patch-notes, since 3.0.2

Fix:

• GUIUtility.ExitGUI() is now called after all button clicks, meaning that button methods that invalidate the GUI state should no longer cause a multitude of exceptions related to layout and other GUI states to be thrown after they're done executing.

It seems that we could just ignore the issue.

        public void Draw()
        {
            try
            {
                FilterRules(_searchFilter);
                _drawerTree.Draw();
                ApplyChanges();
            }
            catch (Exception e)
            {
                Debug.LogError(e);
            }
        }

=> 
        public void Draw()
        {
                FilterRules(_searchFilter);
                _drawerTree.Draw();
                ApplyChanges();
        }

Thought?

[Mefodei]

I can update odin to enable ODIN_INSPECTOR3 [Searchable] attribute support сб, 15 мая 2021 г. в 15:59, Favo Yang ***@***.***>:

…

We have a new duplicated new issue #46 <#46>. I tested with - addressables 1.16.19 - odin 3.0.5.0 - importer 0.9.4 I still get the same error. UnityEngine.ExitGUIException: Exception of type 'UnityEngine.ExitGUIException' was thrown. I checked related odin patch notes: https://odininspector.com/patch-notes, since 3.0.2 Fix: - GUIUtility.ExitGUI() is now called after all button clicks, meaning that button methods that invalidate the GUI state should no longer cause a multitude of exceptions related to layout and other GUI states to be thrown after they're done executing. It seems that we could just ignore the issue. public void Draw() { try { FilterRules(_searchFilter); _drawerTree.Draw(); ApplyChanges(); } catch (Exception e) { Debug.LogError(e); } } => public void Draw() { FilterRules(_searchFilter); _drawerTree.Draw(); ApplyChanges(); } Thought? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#43 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABY4TDVPFSSO2HY7BFDWNU3TNZV3HANCNFSM4THDTNDQ> .

-- Best Regards *Sergey Mikhaylov* Tel: [phone] CTO email: ***@***.*** linkedin: https://www.linkedin.com/in/mefodei github: https://github.com/Mefodei

[favoyang]

@Mefodei

Thanks for the quick reply! Will that fix the issue entirely? Please submit a PR, I would like to test it.

I think we can force odin 3 and drop version 2 support.

[Mefodei]

Nice, let's drop Odin 2 support. I will create PR сб, 15 мая 2021 г. в 16:33, Favo Yang ***@***.***>:

…

@Mefodei <https://github.com/Mefodei> Thanks for the quick reply! Will that fix the issue entirely? Please submit a PR, I would like to test it. I think we can force odin 3 and drop version 2 support. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#43 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABY4TDW433TJS2VSMABZEHTTNZZ23ANCNFSM4THDTNDQ> .

-- Best Regards *Sergey Mikhaylov* Tel: [phone] CTO email: ***@***.*** linkedin: https://www.linkedin.com/in/mefodei github: https://github.com/Mefodei

[favoyang]

@Mefodei I muted ODIN UnityEngine.ExitGUIException error temporarily in b4cb7cf.

[favoyang]

Closed by #53