firemind / projectfiremind-issues Goto Github PK

For example Mono Black Infect includes Mountains, Plains, Forest and Island. Mono Black Warriors includes at least Plains and Mountains.

wastes are basic lands shd be able to have as many as you want.

Clean up formats standard, modern and extended after rotation.

Recalculate the legalities of all decks in those formats.

Delete all ratings for decks that rotated out.

Adjust validator to check for legality in any block.

Add Block Party Format as selectable format and in top decks view.

As described in the discussion here:

https://www.firemind.ch/decks/156905

On https://www.firemind.ch/status there are some new cards that were shown as pushed, eg https://www.firemind.ch/card_script_submissions/2813 but I'm unable to find the commit on the csm-auto repo.

Btw, nice work on the automatic testing of the submissions! I noticed some of the improper submissions were correctly rejected by the system.

A user reports the auto-complete on the card submission page sometimes triggers the form. This shouldn't happen.

Look for hq pictures of the missing cards and replace the rest with lq pics.

Some cards have plain wrong images (like mox jet). Figure out if there is a pattern and an easy fix. If not maybe let users report broken images.

Clusters at first look like a very useful option, allowing you to let evolution do the final touches on your deck, but the interface they're behind is not in a great shape. Here are some of the issues I've ran into:

• Firstly, only the Lands cluster is automatically created. It would be very useful if creatures and spells were created automatically too. Depending on the language the server runs, I'd be happy to help with that.

• Secondly, the Lands cluster is always autoselected. Even when I'm trying to adjust the number of copies I'd like to see tested and definitely don't want to change the card's cluster, it gets set to Lands and I have to set it back to creatures

• Thirdly, the interface for adding cards to clusters doesn't update with added cards until you close and repoen the pop-up, making it hard to see if you're added all the cards to the clusters you want them in.

• Fourthly, it would be very handy to get statistics on the number of cards in a certain cluster, to see if you've not missed any cards. Both points 3 & 4 sound like Javascript problems and I'd be glad to help with them.

Define a pool of maybe cards for a deck from which slight variations of the deck can be compiled automatically.

Pool entries may be mapped to a card group which they replace (to decrease the number of possible changes to the deck).

Cards may be marked as hard (they will never be replaced).

Number range for deck entries to try from. (e.g. Always have Lightningbolts, but is 2 enough or do I need 4)?

Raised on forums

java.lang.RuntimeException: unknown count "Vampire"
   at magic.data.EnglishToInt.convert(EnglishToInt.java:35)
   at magic.model.ARG.amount(ARG.java:34)
   at magic.model.event.MagicCostEvent$2.toEvent(MagicCostEvent.java:32)
   at magic.model.event.MagicCostEvent.build(MagicCostEvent.java:280)
   at magic.model.event.MagicRegularCostEvent.<init>(MagicRegularCostEvent.java:22)
   at magic.model.event.MagicRegularCostEvent.build(MagicRegularCostEvent.java:45)
   at magic.model.event.MagicPermanentActivation.create(MagicPermanentActivation.java:114)
   at magic.model.MagicAbility$167.addAbilityImpl(MagicAbility.java:1228)
   at magic.model.MagicAbility.addAbility(MagicAbility.java:1419)
   at magic.data.CardProperty$14.setProperty(CardProperty.java:102)
   at magic.model.MagicCardDefinition.loadAbilities(MagicCardDefinition.java:188)
   at magic.model.MagicCard.<init>(MagicCard.java:100)
   at magic.model.MagicCard.<init>(MagicCard.java:88)
   at magic.model.MagicPlayer.createHandAndLibrary(MagicPlayer.java:424)
   at magic.model.MagicDuel.nextGame(MagicDuel.java:127)
   at magic.firemind.FiremindDuelRunner.runDuel(FiremindDuelRunner.java:167)
   at magic.firemind.FiremindDuelRunner.main(FiremindDuelRunner.java:76)

Something is taking way too long there. Probably the win/loss ratio label.

currently twitter does not provide an email address. firemind's authentication depends on the email as unique key though.

cards added to the repo are using the CRLF line terminators, whereas we use LF (Unix) style terminators in the main repo. This is currently resolved with a normalization commit post integration of the card scripts, eg magarena/magarena@345a64a

It will be great if card scripts can be converted to Unix style line endings pre-commit so as to eliminate the normalization commit altogether.

Cards that have been requested, and then added, still appear on the card request list

right now those lead to internal server errors. should be cleaned up

The page you were looking for doesn't exist.

You may have mistyped the address or the page may have moved.

logged in as Ian Hodges. deck merfolk under modern. click the deck. page opens click modern under challenge the above error appears.

using i.e.11 on windows 10.

The process to enable cards mistakenly uses the magarena repo clone which also contains user submissions through the sites. This can lead to cards being enabled that have not yet been merged into magarena and that of course leads to failing duels.

For the enabling process a clone of the current magarena stable release should be used.

I lost the link after clearing my browser history. I will record it on the Magarena wiki to prevent something like this from happening again.

it should handle searches like "put x +1/+1 counters" correctly

Queue running on the latest magarena code to determine if card submissions are functional.

In a later step make it available to users to run experimentally on and dismiss results if it is broken

Allow Ai1 and Ai2 to have separate strength settings to allow comparisons of AI across different strength settings. Currently it is only possible to compare AI with the same strength.

The filename of a card script is obtained by replacing all non-alphanumeric characters with _. This includes the hyphen.

Eg. in https://code.google.com/r/projectfiremind-magarena-20140421/source/detail?r=183fb087149e6251cd609db51d085eaee2f14dcc
the correct filename should be Ghitu_Fire_Eater.txt and Ghitu_Fire_Eater.groovy

Sakura-Tribe Scout is showing that it doesn't have a script. I know this card was added to Magarena in the 1.49 release in April.

Could be possible that there are others that have slipped through the net.

Pictures from the set Stronghold still seem to be scrambled (see Hesitation, Tidal Warrior). Looks like the only remaining set with this problem.

The tapped out api does not support validation of restricted cards (ie mox jet in vintage). The restricted list should be added to the format legality calculator.

See https://www.firemind.ch/ai_rating_matches/123 and https://www.firemind.ch/ai_rating_matches/125

They have been stuck at 31% and 78% percent respectively.

Find a better solution than the 5 second sleep. app/workers/push_cardscript_worker.rb:26

Currently (because of a workaround for æthervial all are are changed to æ.

The archeotype statistics pages such as this one seem to not have been updated since the default game consisted of 4 battles. As games by default consist of 5 battles now, no battles are shown in the last 4-0 and 3-1 results pages.

Changing those to daily 5-0 and daily 4-1 could make those statistics work again.

Send a weekly (?) status report email to users telling them how their decks performed this week.

Interesting information:

• Changes in rankings
• Especially good/bad performance against certain decks
• Round up of how many duels were run
• Was my deck forked?

Users should be able to opt-out of these notifications.

Maybe it is time to allow deletion of decks again.

If not at least allow users to hide decks they no longer want

Results in this
http://www.firemind.ch/decks/134395/diff/4445

Add constraints to prevent this and delete decks effected by it

http://www.firemind.ch/decks/my_forks should redirect if not logged in

To replicate:

1. Create a cluster:
   
2. Try to assign cards to a cluster. You assignments aren't shown until you re-open the pop-up
   

This initially made me think the functionality was broken.

The card Teferi's Puzzle Box has been available in Magarena for a while, but isn't available in Firemind.

Edit: actually, my mistake, this card was added on the latest release. For some reason I thought it was older. Closing.

This should definitely not happen. https://www.firemind.ch/duels/416619

Currently there is a way to get your deck archeotype classified by project firemind, but its not automatically applied to newly created decks, even as a suggestion. As a result, about 23% of decks in Standard, Modern and Pauper, 28% in Vintage and 42% in Legacy don't have an Archeotype.

Suggestion: appy the classification automatically to each uploaded deck

My Modern deck is showing that Longshot Squad isn't Modern legal. It is.

Just a thought about the current Archetype method.

I feel as though Basic lands shouldn't be included in defining an Archetype (and maybe even non-basic lands)

Basic lands are the main card type that can appear in high quantities in a deck, though they rarely define what that deck does.

Currently 8-Rack is being defined for all mono-black decks, as they contain Swamps. Even though they don't contain any of the non-basic land cards for that archetype.

Some examples from the top 10 Modern decks which are all 8-Rack:

Wraith Rat - Cards matched = Swamp
Black and Forth - Cards matched = Swamp
Poison - Cards matched = Urborg, Tomb of Yawmoth; Swamp

We intend to switch over from hg hosted on googlecode to git hosted on github after the Oct dev cycle. Starting Nov, we'll start to use the github repository as the main repo. Hopefully the card submission can be updated as well.

Or share with the strict requirement of no further sharing?

I'd like to look/reuse how you automate games between AI. I'm looking into deep RL/machine learning techniques, and this would provide a great starting point for training AI.

Add a script that lists missing images.

when I try to login, I get redirected to the homepage but I'm still not logged.
Whit a wrong password, all is as it should be (I remain on the login page and get the message wrong user/pasword).
I tried to reset the password, but it didn't change anything

Add a challenge button on decks that aren't yours that lets you select one of your decks to challenge it with.

Also add usual duel options to this.