fjolliton / cl-vectors Goto Github PK

Hey, I'm about to package the library for inclusion in Void Linux so I'd like to ask you to tag a version in Github. I see in the version file the current one is 0.1.5 but it simplifies our process and discussion greatly if there is a Github tagged versin :)

Thanks!

There is a bug in defun discrete-bezier-curve.
Sometimes it calls (atan 0.0 0.0), spec [1] specifies that:

If both are supplied, number2 can be zero provided number1 is not zero.
The problem is fixed using a safe version of atan:

 (safe-atan (x y)
	     (if (and (= x 0) (= y 0))
		 0
		 (atan x y)))

I'm not sure if "0" is the correct answer.

Regards,
Alessandro

[1] http://clhs.lisp.se/Body/f_asin_.htm

Is use of $VERSION$ in the cl-vector .asd file a bug? a feature? what is that about? any idea?

I think it's the cause of warnings I see like those below.

I think it could be fixed by putting a real version x.y thingee with numbers in there instead. Presumably the version from the file named VERSION, but I don't know.

We are hoping to not have to see all these warnings every compile.

Thank you,

Mark

; Warning: UIOP/UTILITY:PARSE-VERSION: "$VERSION$" doesn't follow asdf version numbering convention
; While executing: (:INTERNAL ASDF/DEFSYSTEM::INVALID-PARSE ASDF/DEFSYSTEM::NORMALIZE-VERSION), in process repl-thread(11).
; Warning: Invalid :version specifier "$VERSION$" for component "cl-vectors" from file #P"lisp/quicklisp/dists/quicklisp/software/cl-vectors-20130312-git/cl-vectors.asd", using NIL instead
; While executing: (:INTERNAL ASDF/DEFSYSTEM::INVALID ASDF/DEFSYSTEM::NORMALIZE-VERSION), in process repl-thread(11).
; Warning: Invalid :version specifier "$VERSION$" for component "cl-vectors" from file #P"lisp/quicklisp/dists/quicklisp/software/cl-vectors-20130312-git/cl-vectors.asd", using NIL instead
; While executing: (:INTERNAL ASDF/DEFSYSTEM::INVALID ASDF/DEFSYSTEM::NORMALIZE-VERSION), in process repl-thread(11).
; Warning: UIOP/UTILITY:PARSE-VERSION: "$VERSION$" doesn't follow asdf version numbering convention
; While executing: (:INTERNAL ASDF/DEFSYSTEM::INVALID-PARSE ASDF/DEFSYSTEM::NORMALIZE-VERSION), in process repl-thread(11).
; Warning: Invalid :version specifier "$VERSION$" for component "cl-aa" from file #P"lisp/quicklisp/dists/quicklisp/software/cl-vectors-20130312-git/cl-aa.asd", using NIL instead
; While executing: (:INTERNAL ASDF/DEFSYSTEM::INVALID ASDF/DEFSYSTEM::NORMALIZE-VERSION), in process repl-thread(11).
; Warning: Invalid :version specifier "$VERSION$" for component "cl-aa" from file #P"lisp/quicklisp/dists/quicklisp/software/cl-vectors-20130312-git/cl-aa.asd", using NIL instead
; While executing: (:INTERNAL ASDF/DEFSYSTEM::INVALID ASDF/DEFSYSTEM::NORMALIZE-VERSION), in process repl-thread(11).
; Warning: UIOP/UTILITY:PARSE-VERSION: "$VERSION$" doesn't follow asdf version numbering convention
; While executing: (:INTERNAL ASDF/DEFSYSTEM::INVALID-PARSE ASDF/DEFSYSTEM::NORMALIZE-VERSION), in process repl-thread(11).
; Warning: Invalid :version specifier "$VERSION$" for component "cl-paths" from file #P"lisp/quicklisp/dists/quicklisp/software/cl-vectors-20130312-git/cl-paths.asd", using NIL instead
; While executing: (:INTERNAL ASDF/DEFSYSTEM::INVALID ASDF/DEFSYSTEM::NORMALIZE-VERSION), in process repl-thread(11).
; Warning: Invalid :version specifier "$VERSION$" for component "cl-paths" from file #P"lisp/quicklisp/dists/quicklisp/software/cl-vectors-20130312-git/cl-paths.asd", using NIL instead