fragglet / c-algorithms Goto Github PK

A library of common data structures and algorithms written in C.

Home Page: https://fragglet.github.io/c-algorithms/

License: ISC License

Shell 0.39% C++ 1.13% C 96.71% Makefile 0.64% M4 0.47% Ruby 0.66%

c-algorithms's Introduction

C Algorithms

The C programming language includes a very limited standard library in
comparison to other modern programming languages.  This is a collection of
common Computer Science algorithms which may be used in C projects.

The code is licensed under the ISC license (a simplified version of the BSD
license that is functionally identical).  As such, it may legitimately be
reused in any project, whether Proprietary or Open Source.

c-algorithms's People

Contributors

Stargazers

Watchers

Forkers

leiqzhang pyin nkrylov maxking alemic qingyangwtg yoghurtshawn colinz2 chimenchen jiaoshouwu fengyuqiancheng kavonm lazarusx kulsunny qiukui qq644531343 shobhitguptavmc neo-yuanyanjun qwertyssp colincui zimo-geek zz198808 90lantran wangying1357 wyrover fengyiqui dud3 javajavelin stavrossk kiwi4py acd16 cc272309126 ssserenity dedovkonstantin shadrd0g shufengdong cankai chl1996 clever-boy whuisser115 lizhangzhan jih488 dunyixu xiaoxiao19 linan7788626 clydezeng masum0009 losintikfos ldfaiztt jimmy486 mindis caisan blue119 mymizan enjoyhacking jacklicn jameslz skmuduli92 pjcrosbie phenixsh jieliu liyongming1982 mrsanhaa rongp jicky1984 alex1818 nitsel88 rishirajsurti pangkunpeng1987 idodoyo ajaykgp eugjlee bayes089116 connlan xorllc matkuscz qiaod jingchengli tony lixinsu timou hellokingyip toints pandaychen knowno miyaliu ben01122 soroushmehr neelpatel21 woongh mirland 340211173 tomathivanan coder57 templeblock ricardo2197 jiguosong neutree laeeqentc sdcloudt

c-algorithms's Issues

Should rename libcalg-1.0.pc.in to libcalg.pc.in

pkg-config file usually does not need to carry the version in the filename.

Crash with trie when using values >= 128?

This bug was reported previously but I don't think it was fixed.

regarding the missing rb_tree_subtree_height function in the rb_tree.c file

As addressed earlier also, the implementation of rb_tree_subtree_height function is missing in the file rb_tree.c which is specified there in the header file.
I have implemented and coded that function, so can you allow me to make a pull request for the same, so that you cam look at it, in order to resolve the issue?

Prototype for AVLTreeCompareFunc is incorrect, causing confusion

At line 119 of https://github.com/fragglet/c-algorithms/blob/master/src/avl-tree.h, there is a function pointer for AVLTreeCompareFunc declared.

The declaration is:

typedef int (*AVLTreeCompareFunc)(AVLTreeValue value1, AVLTreeValue value2);

But the documentation (and code) shows that this function is for comparing the keys of two nodes in the tree, so the declaration should actually be:

typedef int (*AVLTreeCompareFunc)(AVLTreeKey key1, AVLTreeKey key2);

As both AVLTreeKey and AVLTreeValue are themselves typedefed as **void ***, it doesn’t actually make any difference to the function operation, but it makes the prototype confusing.

Documentation should specify which header to include

Yes, I know I could examine all the headers available, but it'd be nice if each documentation page listed which header(s) you need to include to use it.

c-algorithms code quality

looking for c data structures and algorithms as my c tool kit, the recent release of c-algorithms is 8 years ago, is it actively maintained and 'production ready'? does it go through lots of test cases and field use, or at this point it's more of a reference implementation for others to learn how to do data structure and algorithms coding in C?

Cannot distinguish between no-op insert and memory error

I preface that I'm quite new to C so this may be completely off. However, in:

c-algorithms/src/set.c

Lines 256 to 275 in 5b0555f

 
 if (set->equal_func(data, rover->data) != 0) { 

 /* This data is already in the set */ 

 return 0; 

 } 

 rover = rover->next; 

 } 

 /* Not in the set. We must add a new entry. */ 

 /* Make a new entry for this data */ 

 newentry = (SetEntry *) malloc(sizeof(SetEntry)); 

 if (newentry == NULL) { 

 return 0; 

 }

the 0 return value is used both for an operation that does not change the state of a set (because the value already exists), which may or may not be an issue, and a memory error, which is more likely to be an issue, and of a different type.

Shall the former not use a kind of custom error code, and the latter an ENOMEM according to https://www.gnu.org/software/libc/manual/html_node/Error-Codes.html ?

Thanks.

Do we need to call `arraylist_new` again in a cleared array list when we want to put items.

Hi,
I am using the arraylist library in cython hobby project. So far so good. My project is a win32 api ui library. I have list box control . It has an items property which is internally your arraylist. I need to implement an option to clear all the items from list box. It's okay, because I can call the arraylist_clear function. But after clearing the arraylist, if my user wants to put another set of items what should I do ? Should I call arraylist_free & arraylist_new ?
Thanks in advance.

Build on Mac

On Mac how can I build the code, I found autogen.sh can't run on Mac.

missing rb_tree_subtree_height implemention

Hi there,
During wrapping this into a python libraty, I found rb_tree_subtree_height missing in rb-tree.c, which appears in the header file.
Did I miss something?

[bug] rb-tree: Calling the comparator on node values instead of keys

c-algorithms/src/rb-tree.c

Line 377 in 17cd712

if (tree->compare_func(value, (*rover)->value) < 0) {

This line should check the keys, not the values.

Separately, does this repro accept new features such as implementing the missing deletion functionality in rbtree?

Thanks!

any instruction to build src?

I tried.

./autogen.sh
make

is there a way to change default "malloc function"?

i want to use the lib in mcu( Inconvenient to use malloc and free), i find it only only can register "free function" useing your api.

Cannot modify data of list entry. Was this meant to be this way?

There are functions to get the value of a ListEntry, but there are no functions to write to the data of a ListEntry.

The underlying struct is defined in the list.c file so it is not possible to access it directly.

I am willing to implement the feature if needed.


	if (set->equal_func(data, rover->data) != 0) {

	/* This data is already in the set */

	return 0;
	}

	rover = rover->next;
	}

	/* Not in the set. We must add a new entry. */

	/* Make a new entry for this data */

	newentry = (SetEntry *) malloc(sizeof(SetEntry));

	if (newentry == NULL) {
	return 0;
	}

fragglet / c-algorithms Goto Github PK

c-algorithms's Introduction

c-algorithms's People

Contributors

Stargazers

Watchers

Forkers

c-algorithms's Issues

Recommend Projects

Recommend Topics

Recommend Org

Jobs