fvtt-fria-ligan / forbidden-lands-foundry-vtt

This is a Forbidden Lands game System for the Foundry Virtual Tabletop. Made by @Perfectro, @patrys and @aMediocreDad. Maintained by @aMediocreDad

'Round the beggar from Varassa all sat in a ring,
and by the campfire they sat and heard his song.
About walkers and wolfkin and every terrible thing,
and of his fear he sang to them all night long:

"There is something beyond the mountains,
beyond the howls beyond the mist,
there is something behind the veils,
behind hearts cold as stone.
Hearken, something walks and whispers,
walks and lures you in and whimpers:
Come to us, for this earth shall ever be ours and ours alone!"

⚔️💀 Forbidden Lands for Foundry VTT 💀⚔️

The Officially supported, and community developed system for playing Forbidden Lands on Foundry VTT.

The core system features no content. It only provides support for various mechanics required to play the game:

• Character, and Monster sheets.
  • Including the ability to drag-and-drop Gear, Talents, Spells and Critical Injuries.
  • Integrated consumables roll mechanics.
  • Automation through Roll Modifiers and Encumbrance tracking.
  • Conditions can be tracked from character sheets and tokens.
• Party Sheet
  • Bring the party together on Journeys. @maxstar's famous Party Sheet is now part of the system.
• Stronghold Sheets.
  • Giving you the ability to track the buildings, hirelings, and resources in a stronghold through drag-and-drop.
• Items:
  • Gear — General equipment needed for adventuring.
  • Weapon — Choose whether it is a normal weapon or an artifact.
  • Armor — Armor rating, and track how to get your hands on some defense.
  • Talent — Talents for characters. Helps you survive.
  • Spells — Store information on powerful spells.
  • Critical Injuries — Track those pesky injuries caused by monster attacks.
  • Monster Attacks — For detailing vicious monster attacks causing critical injuries.
  • Monster Talents — Monsters also have talents.
  • Raw Materials — For building your stronghold.
  • Stronghold Buildings — For ease of tracking the buildings in your stronghold.
  • Stronghold Hirelings — Track wages, and capabilities of your stronghold's hirelings.
  • Roll Modifiers can be customized on many items so you don't need to remember whether something gives you a bonus, or penalty, to your rolls.

Content for the system is available as addon modules. You can purchase them at Fria Ligan's website (see below).

🚀 Install

1. Open Foundry's Admin dashboard and select the Game Systems-tab.
2. Click the Install System button, and find Forbidden Lands in the list of available systems (should that fail, look here for available manifests).
3. Install Year Zero Engine: Combat as prompted. If not prompted make sure to install the module manually.
4. Create a Game World using the Forbidden Lands system.

Testing the development version

1. Download the repository as a zip file and extract it (or clone it if you know how) into a directory where you can find it.
2. Download Bun or Node.
3. Open a terminal in the directory where you extracted the repository and run:

# If you have Bun installed
bun install && bun run build

# Or if you have Node installed
npm install && npm run build

4. Follow the prompts that appear when you run the command.
5. Success!

🚦 Supported Modules

• Dice So Nice will give you beautiful 3D dice for each roll.
• Year Zero Combat for a more streamlined combat experience.
• Token Action HUD will support Forbidden Lands System very soon!
• Simple Calendar now has the Forbidden Lands calendar implemented as a preset option.
• Virtual Tabletop Assets - Tokenizer is supported on all character sheets.
• Drag'n'Transfer can be set up using this array: "character":"monster","monster":"stronghold","stronghold":"character" (Thanks @moinen).

🗺️ Preview

🛠️ Contributing

If you want to contribute to the project, download and build it for something else, or if you simply have an issue, please read our contributing guide to learn more about how we accept contributions and how to set up the development version of the project.

🙏 Contributors

✏️ System originally created by @Perfectro

🔧 Currently maintained by @aMediocreDad

✨ We have many great contributors to the project including @patrys @maxstar @jimorie @giant-teapot @roonel @romelwell @moo-man @SlamHammerfist @lasseborly, @m0ppers, @narukaioh, and @Cussa

🌐 Localization contributors: @ptosekigloo @ptoseklukas (cs), @Bapf @OnkelRod @sebastiansIT @Tobbot @GeneralMine (de), @DavidCMeier @KaWeNGoD (es), @ismail-ahmed @cyberdwarf1664 @Zhikann (fr), @franklinbenini @DenninDalke @luizbgomide @igorteuri @trprado (pt-BR), @SwedishRabbit (se), and @Rosataker (zh-TW)

🎲 Dice graphics recreated by Tomasz 'jarv' Dobrowolski with permission from Fria Ligan.

🧙 Character Generator now features optional expanded Bitter Reach tables from Reforged Power, courtesy Experimental

As well as plenty of users who have come with great feedback, either on the official Foundry discord server or in issues

💻 Websites

• Foundry VTT
• Fria Ligan: Forbidden Lands

📝 Licenses

• Logo and Content: The Forbidden Lands logo and content is Copyright © and Trademarked by Free League Publishing. The parts of this project protected under this copyright may not be distributed commercially or freely. This includes art, logo, and copyright text (like the character-generator.json) sourced from the Forbidden Lands tabletop RPG.

  Some content may be reused under Free League's Open Gaming License.

• Source Code: All source code (javascript, hbs, scss, as well as system templates and the like), are Copyright © 2021 Free League Developer Community, and licenced under the GNU General Public License v3.0.
• Foundry VTT: The project is created following the Foundry VTT Limited License Agreement for module development.
• Fonts: The fonts used in this project carry their own licenses:
  • IM Fell English Font Family
  • Poppins

forbidden-lands-foundry-vtt's Issues

German translation

Is it planned that there will be a German translation? That would be great

Hide exposed schemaversion

The World Schema Version does not need to be exposed to users.

Consumables as per Y0 SRD

Currently the consumables are implemented as per Forbidden Lands rules. It would be excellent if we could choose between these and the Consumables as per Year Zero SRD.

"Supply Rating: You track each consumable on your character sheet using a Supply rating. A higher rating is better.

Supply Roll: At regular intervals (depending on the consumable in question), you need to make a Supply roll. This means rolling a number of dice equal to the current Supply rating – but never more than six dice. For every 1 rolled, the Supply rating is decreased by one. When the Supply rating reaches zero, you’re out of the consumable. The effects of lacking air, food and water are explained in Combat & Damage.

Group Consumables: Usually, consumables are tracked individually, but they can also be tracked for the group as a whole, depending on the situation. The GM has final say.

Sharing: If you want to give a consumable to another person, you simply increase the recipient’s Supply rating as many steps as you decrease your own."

In our home group, we additionally count every four full units of a consumable as a regular item in terms of weight.

Initiative order - lowest to highest

Rules as Written, the Initiative in FBL is low to high. While this is achievable with the Reverse Initiative, this has caused some styling issues before, so it'd be great if it were integrated into the core system.

Module updete

I cant update modul to 5.0.0. After check still show current version.

Importing after updating module creates duplicates

I have a FoundryVTT installation ongoing since 0.7.9, now "updated" to 0.8.8. What I had to do get 0.8.8 running was to copy the data to a completely new setup, separate from the old one and existing in parallel (the old one of course being shut down at the moment).

Now when I update the game system and the FBL modules, I get the "Begin importing" dialogs at startup. Even though it says in the settings window that "previously existing entries will be overwritten", what actually happens is that I get duplicates of all items, characters, journal entries, etc. This is of course annoying, and I want to avoid it - but I still want to do the import in order to get any new macros, updates, etc. How can I do that?

Character Generator does not record skills with spaces in name

When generating a character with the "chargen" if you have a childhood or a background that grants you "Animal Handling" it
does not get recorded on your character sheet when you hit apply.

I suspect this might have to do with the space in the name of the skill. After discovering this, I modified the dataset.json to add "Sleight of Hand" (the only other skill with a space in the name) and found the same behavior. I did not see this behavior with any other skill in testing.

• Windows 10
• Chrome
• Foundry Version 0.7.9
• FBL System 5.3.5

Refactoring of Dev Environment

Changes include:

• Automatized Gulp workflow.
• CSS -> SCSS (for faster maintenance).
• JS -> TS (this is a slow change, but one that will allow for Foundry.js type definitions and documentation. It will also facilitate creating unit tests).
• Prettier code formatting.
• Github Actions.
• Reorganization of files and folders.

Armor and Gear Artifacts

As the 'artifact' item type has been removed and integrated into the 'weapon' item type, we no longer have a good place for non-weapon artifact types. Barkhyde, for example, is a helmet (kind of). It would fit best into the armor category, mechanically, but there's currently no way to properly add its effects, drawbacks, etc. there. Entered as an artifact weapon, it gets placed into the 'weapons' slot on a character sheet, and of course lacks a way to track armor rating there as well.

Is there currently a plan to revise the armor item sheet to allow for artifact types? There are also a fair number of artifact items that don't really fall well into either category and should maybe considered more as artifact 'gear' (Clay's Rosary, for example).

Originally posted by @rwisaak in #27

DM rolls are different from player rolls

When as a DM I want to help a player rolling something from her pc sheet, the chatmessage does not identify the roll has a PC roll.

It just identifies (Skill rolled) and GM.

There is not the PC name anywhere in the chatmessage, nor appears the push in the chatmessage.

🐛 Character/Items image alignment issues

Describe the bug
Character, and item images is not centered (consistently) on character and item sheets. On character sheets, images are placed at top left always. For items, they are only centered horizontally.

Wide images:

Tall Images:

Expected behavior
All item and character images to be centered both vertically and horizontally to match the gray background gradient.

Desktop:

• OS: Windows
• Client Foundry Desktop app
• Foundry Version 0.7.9
• Forbidden Lands 5.1.2
• Active Modules 0

Error importing premium modules

Hi,

I've purchased the premium modules of Forbidden Lands but I get some error when importing the modules. I'm not sure if the problem is in this game system or in the modules. I've sent a mail to Free League support but I think that is worth it to add the issue here, just in case.

To avoid any backward issues I've created a clean world. Application and modules are in the last version:

• Foundry VTT: 0.8.7
• Forbidden Lands Game System: 6.0.1
• Forbidden Lands - Core Game: 1.2.0
• Forbidden Lands - Bitter Reach: 1.2.0
• Forbidden Lands - Raven's Purge: 1.2.0

No other modules have been loaded.

I'm aware that Forbidden Lands premium modules show a Compatibility Risk tag.

When imported the core game module in the Forbidden Lands just created world, it creates the folders in the different sections of Foundry but no content is imported. An error is shown several times in the main screen:

Minimized windows don't show the "close" button correctly.

Desktop

• OS: Both Win10 and Ubuntu 20.04
• Client- Foundry Desktop app,
• Foundry Version 0.7.9

🐛 Calendar/Weather support seems broken

Describe the bug
When starting a new world and activating Calendar/Weather no calendar configuration is done.

Expected behavior
When activating the Calendar/Weather module it should configure the calendar to the appropriate format for the forbidden lands.

Desktop:

• OS: Windows 10
• Nodejs client
• Foundry Version 0.8.8
• Forbidden Lands 6.0.4
• About Time 1.0.4
• Calendar/Weather 3.1.6
• Simple Calendar 1.3.8

Workaround
Here a JSON file that can be imported into simple calendar to get similar calendar to the one used in the module:
https://pastebin.com/RGgyBHWX

#71 Add support for Safe Casting and Ingredients.

As seen in #71, the dice roller for spell casting can seem a bit confusing if one assumes that you can include Ingredients and Safe Casting in the dice roll.

Adding support for these via checkboxes or similar adding to the total power level without displaying dice would probably make the whole process a lot more intuitive.

Character Generator

First: warning message. I believe that the sentence should sound: "Clicking .... with no way to revert the changes". It's actually possible to to reset the changes again and again by generating new character, but there's no option to go back, so I guess that word "revert" fits better than "reset".

Second: When the character is generated one can click on "apply" several times, spawning copies of equipment and talents. One click should do the job. Next click should work if the character would be generated again.

In the game module the weight option "regular" should be "normal" to conform to the choices in the game.

Option to record attribute and gear damage when pushing a roll

It would be incredibly helpful if the roller were able to offer to (or automatically, based on a setting) apply attribute or gear condition damage when a player pushes a roll and there are failures.

Party Sheet no longer working

Following the latest update, the party sheet is no longer working properly. Tested this both on my existing game on forge-vtt and in the local windows client (clean install of system and world).

Creating a new party sheet presents me with a blank screen and a prompt to enter the party name. When I enter this, it blanks the field again, but changes the name in the actor list.

Dragging and dropping actors onto the sheet fails without UI indication. When closing the actor sheet, the following error is displayed>

"Required field "name" not present in actor data"

Console output:
Foundry VTT | Rendering ForbiddenLandsPartySheet
backend.mjs:306 Foundry VTT | Created Actor with id [SqoschxztuWCAxi5]
foundry.js:8865 Error: [SqoschxztuWCAxi5] Required field "name" not present in ActorData
at ActorData._validateField (data.mjs:361)
at ActorData.validate (data.mjs:273)
at ClientDatabaseBackend._preUpdateDocumentArray (foundry.js:8862)
at ClientDatabaseBackend._updateDocuments (foundry.js:8794)
at ClientDatabaseBackend.update (backend.mjs:154)
at async Function.updateDocuments (document.mjs:366)
at async ForbiddenLandsActor.update (document.mjs:448)

Character generator no longer applies attributes after the last update.

Hi!
I have two instances of Foundry installed. On one I have updated the system and the bug showed itself. On the other one, with system version 5.2.1 all works as expected. I reinstalled the system and created clean world without any modules. The bug must be somehow related to the update.

Prepare for Official release.

Make item sheets resizable

On larger viewports 1440p+ item sheets are small and could display more information.

🚀 0.8 Ready

This Issue tracks Foundry 0.8 readiness.

0.8 Development Branch

0.8 Alpha Build

What does this mean?

Foundry 0.8 is finally here. This means breaking backwards compatibility. This means 5.3.2 will be the last release for 0.7.9.

If you want to check out the beta in YOUR Foundry instance install the system manually with this manifest:
https://raw.githubusercontent.com/fvtt-fria-ligan/forbidden-lands-foundry-vtt/0.8-beta/system.json

Checklist

Sheets opening:

• Character / Limited Character
• Monster
• Party
• Stronghold
• Armor
• Building
• Critical Injury
• Gear
• Hireling
• Monster Attack
• Monster Talent
• Raw Material
• Spell
• Talent
• Weapon

Other Areas:

• Rolls tested
• Post to Chat
• Character Generator tested
• Drag-drop tested
• Roll Modifiers tested
• Editor tested
• Migration of existing world
• Importing official content (This is confirmed NOT working, the modules will need to be updated).
• Combat

🐛 Character Generator not recognizing added Paths

It seems like the number of Paths for a Profession does not change when you add new Paths to a Profession.

If you add an extra Path to a Profession (ex. Path of Ice to the Druid, taking it to four Paths) when you attempt to generate a random Path it only gives results of the first three listed paths (as per the default number of Paths for Druid). The same seems to be true for Sorcerer as well (ex. Adding Path of Elements taking the total to five rather than the default four).

The drop down list is updated correctly, and you can manually select the new Paths without issue.

I did test adding extra Professions, and the random picker seemed to recognize the additions without issue.

When creating new items, there is no Blank weight option, yet in the game all containers have no weight. So if they are created as items, it throws off encumbrance.

Case-insensitive artifact dice

As per discussion #23.

Expected behaviour:

• Input "D12" in roll modifier or input and roll a d12 artifact dice.

Actual behaviour:

• Does not recognize uppercase "D".

This should be an easy fix.

4.1.0 - Prepare release.

This release includes:

#7
#9
#8
...and tentatively:
#12

To be done before release.

• Update system.json to reflect release

• Package release files.

• Prepare tag, release notes and merge release branch to main.

Item quantity in Stronghold Sheets

Currently there is no way to indicate item quantities in Stronghold sheets. E.g. If there is more than one stone in the Stronghold.

🐛 Cannot roll skills/attributes/weapons from GM Screen

Checklist
Before posting a bug make sure you have disabled all modules and checked if the issue is still present.

• Done a clean install of the system.
• Disabled all modules.
• Checked if the issue is present in a new world instance.
• Not a "How To"-question.

Describe the bug
When using the GM Screen module character sheets won't recognize button clicks for Attributes, Skills, Actions, Weapons and so on.

Expected behavior
Roll Dialog should appear when clicking an Attribute, Skill, Weapon-label.

Desktop (please complete the following information):

• OS: macOS, Windows
• Client Chrome / Foundry Native
• Foundry Version 0.7.9

Additional context
An issue has been reported in the GM screen module that closely resembles this one. Upon further inspection Forbidden Lands System is using the same method as PF1 when validating ownership of the sheet on click.

ElfFriend-DnD/foundryvtt-gmScreen#49

5.0.0 Release

Major Changes:

• #47 - Weapon features that interact with attack actions.

Minor Changes:

• #46 - Improved Chat Item links. Thanks to @moo-man
• #44 - Monster types and Mount encumbrance calculation. Thanks to @roonel
• #45 - Special Encumbrance values.
• #36 - Alternative Actor/Item sheet interaction.

Localization:

• #42 - Forbidden Lands now supports Spanish Language. Thanks to @DavidCMeier
• #50 - Forbidden Lands now supports Taiwanese Language. Thanks to @Rosataker
• #51 - Updated Czech localization. Thanks to @ptoseklukas

Fixes:

• #41 Readme.md links fixed.
• #48 Git localized badge added.
• #39 Minor fixes to templates as partial references were affected by formatting.
• #52 Hide exposed schemaVersion.
• #53 Allow resizing of item sheets.

Do you have a file that guides the programmer to work here?

I'm trying to contribute to this repository,
but I still don’t understand how I can run this project on my machine.

Do you have a file that guides the programmer to work here?

I also noticed that when trying to run the program I had two errors:

1. related to dataPath, I had to put Path directly in the variable

const config = {dataPath: "/path/to/foundryVTT/Data"}

2. when trying to do a build: watch, I'm having an error related to the hotbar-drop, I had to comment because I didn't find this file in the project.

Strange font behavior on Linux/Ubuntu 20.04

I've got that strange font look when I run Forbidden Lands on Linux. On Windows all is fine. All looks fine when I join the game by the browser, so it may be as well Foundry related.

A Way to Track Critical Injury Duration

Critical Injury length matters and there is currently no retention of that data. As far as I can tell, I can drag the injury card over from chat and it records it, but the length isn't saved.

I would like a place in the Critical Injuries section to record the length of the injury.

Can't create talent/spell on sheet

Checklist
Before posting a bug make sure you have disabled all modules and checked if the issue is still present.

• Done a clean install of the system.
• Disabled all modules.
• Checked if the issue is present in a new world instance.
• Not a "How To"-question.

Describe the bug
Can't add a spell, talent or equipment pressing the "+" symbol on sheet

Expected behavior
When I click on the "+", I need to see the "create " dialog.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: [e.g. macOS] macOS
• Client [e.g. Foundry Desktop app, Chrome, Firefox] Chrome
• Foundry Version [e.g. 0.7.9] 0.8.8

Additional context
I can add an item, spell or equipment from compendium without problems.
Also, I can create a new item/spell/equipment on "Foundry Items" menu.

REWRITE DONE! PLEASE CONSULT THE CONTRIBUTING.MD

To all contributors!

I recently acquired the part of history we lost back in December. After some deliberation I have decided to do a full rewrite of history to create a clean timeline of the repos development. This means that all commit ids will be rewritten and if you are doing work on the system you need to rebase onto the new tree once the update is pushed.

I will initiate the rewrite once we have reached milestone 5.1.0 and cut a release.

In the meantime feel free to inspect how the history rewrite will look like here:
https://github.com/aMediocreDad/fbl-history-rewrite

Swedish translation not complete/correct

I've noticed a few mistranslations where the english word has been translated into Swedish but not the Swedish word used in the Swedish books.

For example in the "Tillverkning"-tab on items, it says "Lager" instead of "Tillgång" that is in the books. Same with "Råmaterial" which should be "Råvaror" and "Tid" which should be "Tidsåtgång".

The Weapon "Stat"-tab is not translated all the way through either.

It could probably need some TLC!

Can't open Caractersheet 7.X

Discussed in https://github.com/fvtt-fria-ligan/forbidden-lands-foundry-vtt/discussions/160

^{Originally posted by Lanistra222 September 11, 2021}
Since the update to 7.X (7.0.3) I can't open the charakterhseets anymore. Affected ist just the charaktersheet not the monster-, party-or strongholdsheet. I tried to create a new world and occured the the same problem.

Artifact dice

How do I add an artifacts dice to a roll, for instance connected to a talent or artifact?

5.1.0 Release

Preparation for 5.1.0 release.

Feature lock is Thursday at 2PM GMT.

IMPORTANT! After this release I will begin the rebasing of the current trunk onto the old one. THIS WILL LEAD TO A HISTORY REWRITE. If I see any forks ahead of main after finishing the rebase I will give a days notice before the rebase happens.

• Testing of features and stylesheet changes.
• Fixes to inevitable bugs introduced with new feature changes.
• Set up Github release action.
• Prepare tag and release notes.
• Package and ship release.

Bug with damage calculation

When doing an attack roll, the first 6 rolled shouldn't count as damage : it allows the blow to hit the target. Currently, all 6 are added to weapon damage, to the result that the damage output in the chat card is always false : it should be one less.

Exemple : when attacking with a broadsword (damage 2), this roll result should have been 3 and not 4 : the first 6 allows the blow to hit (and thus inflicting the weapon damage - 2) and the other one adds 1 to the weapon damage for a total of 3, not 4.

I hope I made myself clear, but if not, feel free to ask questions !

✨ Adding descriptions without artifact dice

Is your feature request related to a problem? Please describe.
Lets say my players find a nice bucket. I want to give the nice bucket a bit of flavor text, but to do that I have to transform this ordinary (but nice) bucket into a legendary artifact. Let's just say my party have a bit to many artifact by this point...

I like to give my players items with descriptions and appearance. However, the text fields to do so can only be accessed by giving the item an artifact bonus.

Describe the solution you'd like
I see two solutions to the problem.

1. Add a precistant description field for all items.
2. Add a "Normal Item+" category that shows the Artifact tab without adding an artifact dice to the object.

Macros for randomly generated Adventure Sites & NPCs, using the tables in the GMG

Similarly to the loot tables, it would be really great to include macros for randomly generated adventure sites and NPCs in the premium system module using the tables from chapter 8 in the GMG (pages 167-186).
Any plans to do so?

Mounts & Pets Management

Currently mounts are listed as Gear, and lack the ability to have items attached to them, as well as food, water and consumables. Adding an animal as an item doesn't make much sense.

One current workaround is to use a player character sheet, but it doesn't really function properly. To give an example, if a goblin uses a boar to carry his gear, the boar shouldn't be able to use weapons stored on his back, but it should be able to use its tusks, which is its natural weapon. Currently, any weapon stored on a mount appears in the Attacks tab; same behavior with armors. Furthermore a group of players can share a mount as a beast of burden, and having it attached to one particular character can make this cumbersome.

For these reasons, I think it would be preferable if mounts had their own character sheet. Pets are almost always attached to a specific character, but would also benefit from having their own sheet.

An option would be to make it possible to drag and drop a mount or a pet character sheet in an "Extras" tab on the players' characters' sheets, to link them without having to treat mounts and pets as items (which makes little sense mechanically since they have different attributes and features than pure items).

To summarize, an ideal mounts/pets' sheet could include the following:

• Main tab with attributes/skills;
• Combat tab with natural attacks, armor (and possibly weapons) and critical injuries;
• Gear tab with mount gear, consumables, and a separate section for cargo;
• Notes tab;
• Useful but not needed, a section displaying the links created between the player characters and the mount/pet, to visualize who has a relationship with and can access the sheet. That section would be automatically populated when the mount/pet is dragged and dropped to a character sheet.

Initiative draw without replacement.

Hey!
When rolling for initiative in the FL-system on Foundry VTT, it sometimes happens that two or more actors roll the same number. When this happens, the initiative for those actors just follows an alphabetical order. E.g. ‘Player A’ and ‘Player B’ both roll a ‘5’ – in this case ‘Player A’ will always go first. That does not seem to be intended; is there a possbility to change this behavior?
Cheers

Originally posted by @t-luethi in #15

Hotbar Drop support for Macros

A common feature request has been the ability to drag and drop skills and attacks to the hot bar as macros.

This feature requires a rather extensive reworking of how rolls are handled.

✨ Reworked Dice Engine

Converting to YZUR

@Stefouch has developed an excellent roll-engine for the Year Zero systems. The Forbiden Lands system would greatly benefit from an overhaul to its current roll engine which has almost no API for other modules like Token Actions HUD, or Hotbar Drop support, Macros and other usecases.

In addition the Roll Dialog is severely lacking when it comes to functionality for Spell Rolls and Modifiers from Items, as well as attribute damage and willpower gain from pushing rolls.

Converting to YZUR will help facilitate improvements in all of the above aspects of the system as well as providing a better template for chat cards.

Character Generator gives too many items.

Character Generator should only give the items connected to its rolled events, but currently also gives you the default items from your profession.

You can find the intended behaviour on this link: https://forum.frialigan.se/viewtopic.php?t=3930

🐛 Weapon/Armor wrong stats in player sheet

Describe the bug
The stats of the weapons/armor are OK in the item sheet. However, when dragged into the player's sheet, all the stats (such as modifier, damage, armor rating) seem to be 1.

Expected behavior
The stats of the weapons/armors when dragged into the player's sheet should look the same as the ones in the items.

Desktop (please complete the following information):

• OS: macOS
• Client Foundry Desktop app
• Foundry Version 0.8.8

Problems after upgrading to 5.1.2

I just upgraded the game system from 4.1.2 to 5.1.1 in my local FoundryVTT installation, trying it out before doing the same in my official server-based one. But I seem to be having some issues:

• The push roll macro does not work anymore. Web console output shows

  TypeError: Cannot read property 'dices' of undefined
  at DiceRoller.push (forbidden-lands.js:1022)
  at eval (eval at execute (foundry.js:32837), <anonymous>:1:19)
  at Macro.execute (foundry.js:32837)
  at Hotbar._onClickMacro (foundry.js:20566)
  at HTMLLIElement.dispatch (jquery.min.js:2)
  at HTMLLIElement.v.handle (jquery.min.js:2) 
  

• At the same time, I cannot see the Push button on any rolls (generic or from an item)

The new Party character seems to be in place, so some of the upgrade has come through.

I simply did the upgrade from within FoundryVTT, is there more I need to do?

Weapon actions in the character sheet should take into account weapon features

Rules state:

• only hook weapons can shove
• only parrying weapons can parry without a penalty

Currently, all melee weapon actions are displayed regardless of the weapon features.
It should be an easy change, I would be happy to tackle it or leave it for a new contributor.