gaearon / react-hot-api

(Deprecated) A generic library implementing hot reload for React components without unmounting or losing their state

Deprecation Notice

Don’t use this for new projects.
React Proxy is much more advanced, has a better API, and is covered by tests.

React Hot API

You can read the README before deprecation if you want to.

react-hot-api's Issues

Add tests

It would be much easier now due to cleaner separation.

Here's what tests should do:

• Have “versions” of classes, like ComponentBeforeUpdate, ComponentAfterUpdate
• Test that certain behavior changes after applying update:
  • render returns a different tree;
  • methods previously put into setTimeout also execute new code after update.
• Verify that component doesn't lose state and doesn't unmount

Basically verify that patching works correctly. Edge cases to consider:

• All component styles (createClass, extends React.Component in 0.13+, plain object in 0.13+)
• Components with shouldComponentUpdate returning false

ES6 class constructor not hot-updated?

Sorry if this has been answered elsewhere (or if there's a good technical reason), but it seems that constructors in ES6 classes aren't hot-updated like the rest of the class is?

add new beta 0.14 to peerDependencies

As far as I understand, NPM messes up when trying to depend both 0.14.0-beta1 and on libraries that has declared React as a peerDependency.

For example

    "react": "0.14.0-beta1",
    "react-date-picker": "2.0.15",

Does not work well because react-date-picker has peerDependency >= 0.13.0

I've seen this commit which seems to be your solution to this problem (that I could validate on my computer for react-date-picker), so I simply add 0.14.0-beta1 to the list.
c11de6c

By the way, isn't there any better solution? Should I contact every lib author to make the change so that I'm able to use that beta? :'(

makeAssimilatePrototype invokes getters when copying methods

reference to gaearon/react-hot-loader#131

Skip autobinding 0.13 components not created with React.createClass

Autobinding should be skipped here

peerDependencies break npm install [email protected]

Should we change 0.14.0-beta1 to 0.14.0-beta3?

"peerDependencies": {
    "react": ">=0.11.0 || 0.13.0-beta.1 || 0.13.0-rc1 || 0.13.0-rc2 || 0.14.0-beta1"
 },

Also 0.13.0-beta.1 || 0.13.0-rc1 || 0.13.0-rc2 can be safely removed now?

Adapt to breaking changes in facebook/react#4612

Autobinding changes in facebook/react#4612, we want to support this if it lands.

Hot-replace statics

Currently statics are not being hot-replaced. We want to support that—both for traditional createClass style and for ES6 classes.

patchProperty clashes with getter-only-properties in component classes

It should probably do some more introspection using Object.getOwnPropertyDescriptor or some such.

Support inheritance chain

If you have an inheritance chain with something like Babel, only the top level prototype is updated.

We should probably walk the prototype chain here: https://github.com/gaearon/react-hot-api/blob/master/modules/makePatchReactClass.js#L40.

This is up for grabs!

Crashes when factory is exported

If I export a factory obtained with React.createFactory(), hot loader currently crashes:

makePatchReactClass.js: Cannot read property 'render' of undefined

While exporting factories is a discouraged pattern, we should still avoid throwing.
(And ideally, support hot reloading for exported factories.)

React 15 for peerDependencies

Hi @gaearon,
I understand that react-hot-api is deprecated, but could you update the peerDependencies? Seems like everything works with React 15.0.0-rc.1, but I'm getting the peer invalid error when I shrinkwrap my packages.

Calling makeHot twice results in stack overflow

Calling makeHot twice on the same component will cause a stack overflow.

For example:

App = makeHot(App, 'App');
App = makeHot(App, 'App');

This happens because we treat patched prototype as source of truth, but it has already been processed.

Uncaught TypeError: Cannot set property updatePosition

I meet a strange question and I can't find out the reason. This problem appear after I updated a npm package. Can someone give me some promote?

makeAssimilatePrototype.js:21 Uncaught TypeError: Cannot set property updatePosition of #<t> which has only a getter
    at patchProperty (webpack:///./~/react-hot-api/modules/makeAssimilatePrototype.js?:21:16)
    at eval (webpack:///./~/react-hot-api/modules/makeAssimilatePrototype.js?:52:9)
    at Array.forEach (native)
    at eval (webpack:///./~/react-hot-api/modules/makeAssimilatePrototype.js?:51:51)
    at Array.forEach (native)
    at reconcileWithStoredPrototypes (webpack:///./~/react-hot-api/modules/makeAssimilatePrototype.js?:50:21)
    at assimilatePrototype (webpack:///./~/react-hot-api/modules/makeAssimilatePrototype.js?:63:5)
    at patchReactClass (webpack:///./~/react-hot-api/modules/makePatchReactClass.js?:40:5)
    at Object.makeHot (webpack:///./~/react-hot-api/modules/makeMakeHot.js?:33:12)
    at makeExportsHot (webpack:///./~/react-hot-loader/makeExportsHot.js?:44:26)

My ENV

• node v7.7.3
• npm 4.1.2

Fall back to ReactUpdateQueue on 0.13 components

Thoughts on fallback to ReactUpdateQueue.enqueueForceUpdate on react-0.13 components not created using React.createClass and that don't extend React.Component?
Here is an example using a patched loader and api that uses the fallback