geniusforapp / fancydialog Goto Github PK

View Code? Open in Web Editor NEW

423.0 15.0 66.0 4.79 MB

Simple Alert Dialog With Fancy Style

License: Apache License 2.0

Kotlin 100.00%

fancydialog's Introduction

FancyDialog

FancyDialog is a AlertDialog with some fancy styling and them the new version of it is completely build with kotlin

Add Library

repositories {
       maven { url 'https://jitpack.io' }
}    
implementation 'com.github.geniusforapp:fancyDialog:1.0.2'

Code Sample

      val dialog = FancyDialogBuilder(this, R.style.CustomDialog)
                .withImageIcon(R.drawable.ic_new_message)
                .withTitleTypeFace(R.font.roboto_bold)
                .withSubTitleTypeFace(R.font.roboto_medium)
                .withActionPositiveTypeFace(R.font.roboto_bold)
                .withActionNegativeTypeFace(R.font.roboto_bold)
                .withTextGravity(CENTER)
                .withPanelGravity(END)
                .withTitle(R.string.dialog_text_title)
                .withSubTitle(R.string.dialog_text_message)
                .withPositive(R.string.dialog_action_yes) { view, dialog -> dialog.dismiss() }
        dialog.show()

Pull requests are welcome!

Feel free to contribute to FancyDialog.

If you've fixed a bug or have a feature you've added, just create a pull request. If you've found a bug, want a new feature, or have other questions, file an issue. I will try to answer as soon as possible.

Applications using FancyDialog

Please send a pull request if you would like to be added here.

License

Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.

fancydialog's People

Contributors

Stargazers

Watchers

fancydialog's Issues

Pull request acceptance

Hey @geniusforapp, I’ve done some work on your project. Can you merge it?

java.lang.IllegalStateException: Fragment already added:

Fatal Exception: java.lang.IllegalStateException: Fragment already added: FancyAlertDialog{41d19b48 #0 FancyAlertDialog}
       at android.support.v4.app.FragmentManagerImpl.addFragment(FragmentManager.java:1679)
       at android.support.v4.app.BackStackRecord.executeOps(BackStackRecord.java:727)
       at android.support.v4.app.FragmentManagerImpl.executeOps(FragmentManager.java:2363)
       at android.support.v4.app.FragmentManagerImpl.executeOpsTogether(FragmentManager.java:2149)
       at android.support.v4.app.FragmentManagerImpl.optimizeAndExecuteOps(FragmentManager.java:2103)
       at android.support.v4.app.FragmentManagerImpl.execPendingActions(FragmentManager.java:2013)
       at android.support.v4.app.FragmentManagerImpl$1.run(FragmentManager.java:710)

When does it happen: when you show multiple Fancy Dialogs without dismissing the previous ones.
Possible Solution :Add a check if !isAdded() on show dialog.

Cheers for this awesome library.

Can not perform this action after onSaveInstanceState

I'm seeing this crash many times in my crashlytics. I can not reproduce it on my device though.
Any idea why only a few users are seeing this crash? (My app orientation is set to Portrait)

Fatal Exception: java.lang.IllegalStateException: Can not perform this action after onSaveInstanceState
at android.support.v4.app.FragmentManagerImpl.checkStateLoss(Unknown Source)
at android.support.v4.app.FragmentManagerImpl.modifiesAlpha(Unknown Source)
at android.support.v4.app.BackStackRecord.dump(Unknown Source)
at android.support.v4.app.BackStackRecord.commit(Unknown Source)
at android.support.v4.app.DialogFragment.show(Unknown Source)
at ikvaesolutions.xxxxxxxxxxx.custom.FancyAlertDialog.onCreate(Unknown Source)
at ikvaesolutions.xxxxxxxxxxx.custom.FancyAlertDialog.onCreate(Unknown Source)
at ikvaesolutions.xxxxxxxxxxx.custom.FancyAlertDialog$Builder.show(Unknown Source)
at ikvaesolutions.xxxxxxxxxxx.activities.SplashScreenActivity.showDisclaimer(Unknown Source)
at ikvaesolutions.xxxxxxxxxxx.activities.SplashScreenActivity.access$000(Unknown Source)
at ikvaesolutions.xxxxxxxxxxx.activities.SplashScreenActivity$1.run(Unknown Source)
at android.os.Handler.handleCallback(Handler.java:739)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:148)
at android.app.ActivityThread.main(ActivityThread.java:5530)
at java.lang.reflect.Method.invoke(Method.java)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:733)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:623)

Crash on Button Click if Application Paused

App crashes on button press if application is paused. Fancy Dialog Builder does not save click objects so they become null.

04-08 14:57:53.250 29392-29392/com.geniusforapp.fancysample E/AndroidRuntime: FATAL EXCEPTION: main
                                                                              Process: com.geniusforapp.fancysample, PID: 29392
                                                                              java.lang.NullPointerException: Attempt to invoke virtual method 'com.geniusforapp.fancydialog.FancyAlertDialog$OnPositiveClicked com.geniusforapp.fancydialog.FancyAlertDialog$Builder.getOnPositiveClicked()' on a null object reference
                                                                                  at com.geniusforapp.fancydialog.FancyAlertDialog$1.onClick(FancyAlertDialog.java:140)
                                                                                  at android.view.View.performClick(View.java:5201)
                                                                                  at android.view.View$PerformClick.run(View.java:21215)
                                                                                  at android.os.Handler.handleCallback(Handler.java:739)
                                                                                  at android.os.Handler.dispatchMessage(Handler.java:95)
                                                                                  at android.os.Looper.loop(Looper.java:148)
                                                                                  at android.app.ActivityThread.main(ActivityThread.java:5525)
                                                                                  at java.lang.reflect.Method.invoke(Native Method)
                                                                                  at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:730)
                                                                                  at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:620)