GithubHelp home page GithubHelp logo

Publish 1.3.5 of spirv-headers about rspirv HOT 11 CLOSED

gfx-rs avatar gfx-rs commented on July 18, 2024
Publish 1.3.5 of spirv-headers

from rspirv.

Comments (11)

kvark avatar kvark commented on July 18, 2024

I don't have a problem with that. Changes seem backwards compatible. @antiagainst anything to check before we proceed?

from rspirv.

antiagainst avatar antiagainst commented on July 18, 2024

SGTM! Please feel free to proceed. The version number is tracking the spec version. So the next one would be 1.4.1. One thing to keep in mind is that we use a custom verison of core grammar (with categories added and adjusted a bunch of names there) so bumping the version will require manually merge upstream changes with our version. (I'm sorry about this. The changes should really be upstreamed, at least those components that make sense.) I'd recommend going into 1.4.1 instead of 1.5.1 (which is the current spec version) so that we can minimize the changes needed to merge and also a consumer can specifically pin to this version if needed. The procedure would be: diff the current in-tree grammar with the current tracked upstream grammar, update the git submodule for spirv-headers to KhronosGroup/SPIRV-Headers@c4f8f65 and then apply the changes to get a newer version of the custom grammar.

from rspirv.

Jasper-Bekkers avatar Jasper-Bekkers commented on July 18, 2024

Wouldn't it make sense to publish both 1.4.1 and 1.5.1 so we're up to date with the latest spec version as well?

from rspirv.

antiagainst avatar antiagainst commented on July 18, 2024

Certainly. My previous point was that let's not omit 1.4.1 and jump to 1.5.1 directly. :) We should update to 1.5.1 to catch up with the spec for sure. :)

from rspirv.

Jasper-Bekkers avatar Jasper-Bekkers commented on July 18, 2024

I've submitted 2 PRs #115 and #116 that update the json files.

from rspirv.

azriel91 avatar azriel91 commented on July 18, 2024

Heya, please may I bump this 👋. The current spirv_headers version on crates.io depends on num-derive 0.1.44 which brings in syn 0.12.15. I'm slowly chewing through updating the Rust ecosystem 😄

from rspirv.

kvark avatar kvark commented on July 18, 2024

@azriel91 so you are blocked on #116?

from rspirv.

azriel91 avatar azriel91 commented on July 18, 2024

Heya, yeaps.

from rspirv.

antiagainst avatar antiagainst commented on July 18, 2024

The syn dependency is due to derive_more used by rspirv. If one bumps the version of derive_more to 0.99 then syn will use 1.0. But that results in some compilation failures I haven't gotten time to look into it.

from rspirv.

azriel91 avatar azriel91 commented on July 18, 2024

ah, I can do that: (#120).

from rspirv.

Jasper-Bekkers avatar Jasper-Bekkers commented on July 18, 2024

Closing because 1.5 got merged to master now.

from rspirv.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.