GithubHelp home page GithubHelp logo

Comments (6)

antiagainst avatar antiagainst commented on July 18, 2024

Ouch! I should definitely add tests for the builder. The decoder and parser are extensively covered by tests, but the builder I delayed it a little bit, thinking that they are basically automatically generated and should be fine. But apparently not.

Yep, the grammar doesn't directly encode additional parameters to decorations in the OpDecorate instruction (or its siblings). They are encoded in the Decoration operand kind.

Thanks a lot for reporting! Will fix soon. :)

from rspirv.

antiagainst avatar antiagainst commented on July 18, 2024

What is interesting is that if you check 8411ea6, the code removed were manually written and they did have the additional parameters. :)

from rspirv.

tedsta avatar tedsta commented on July 18, 2024

Ahhh haha. I do like your code generation though. Pretty slick.

from rspirv.

antiagainst avatar antiagainst commented on July 18, 2024

Will push a new release soon

from rspirv.

tedsta avatar tedsta commented on July 18, 2024

Sweet, thank you!

from rspirv.

antiagainst avatar antiagainst commented on July 18, 2024

Done. https://crates.io/crates/rspirv/0.3.3 :)

from rspirv.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.