GithubHelp home page GithubHelp logo

Duplicated code in Disassemble about rspirv HOT 3 CLOSED

gfx-rs avatar gfx-rs commented on July 18, 2024
Duplicated code in Disassemble

from rspirv.

Comments (3)

Skepfyr avatar Skepfyr commented on July 18, 2024

@antiagainst, I think you are the only one who can answer this. For reference, it is now here:
https://github.com/gfx-rs/rspirv/blob/master/rspirv/binary/disassemble.rs#L133-L153

from rspirv.

antiagainst avatar antiagainst commented on July 18, 2024

Ah, sorry, It has been long enough that I myself lost track... The comment may already be outdated with recent developements. (Yeah, should really use some good comments there.) So please just ignore it.

from rspirv.

antiagainst avatar antiagainst commented on July 18, 2024

Reading it a bit more, I remembered that I meant we have similar logic in impl Disassemble for dr::BasicBlock and impl Disassemble for dr::Function. Because of the ExtInstSetTracker thingie, I wasn't able to delegate the disassembling to dr::Function/dr::BasicBlock's dissassemble() method directly. Clarified with 96bbb9f.

from rspirv.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.