gher-uliege / physocean.jl Goto Github PK

Hello,

using the latest version of PhysOcean (all the tests passed) and Julia 1.0.0, I cannot test the WOD download.
Running:

WorldOceanDatabase.download(lonr,latr,timerange,varname,email,basedir);

returns UndefVarError: Dates not defined but this can be easily fixed by adding using Dates.
Then after recompiling and running the same code, I get:

KeyError: key "file_name" not found

Stacktrace:
 [1] getindex at ./dict.jl:478 [inlined]
 [2] download(::StepRangeLen{Float64,Base.TwicePrecision{Float64},Base.TwicePrecision{Float64}}, ::StepRangeLen{Float64,Base.TwicePrecision{Float64},Base.TwicePrecision{Float64}}, ::Array{Date,1}, ::String, ::String, ::String) at /home/ctroupin/.julia/packages/PhysOcean/Xi3Gc/src/WorldOceanDatabase.jl:227
 [3] top-level scope at In[3]:1

Hello,
I found a bug in CMEMS.jl.
If all the content in index_history.txt does not match exactly what really is in the folders inside the function CMEMS.download will enter in a loop that starts in line 115 (catch err).
You can relax this catch by skipping non existent files or directories listed in index_history.txt.
Sincerely,
Paolo Oliveri

This issue is used to trigger TagBot; feel free to unsubscribe.

If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.

If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!