GithubHelp home page GithubHelp logo

Comments (3)

gildas-lormeau avatar gildas-lormeau commented on June 9, 2024

Where did you read that ignoreHTTPSErrors could be a valid option?

from single-file-cli.

404name avatar 404name commented on June 9, 2024

Where did you read that ignoreHTTPSErrors could be a valid option?

single-file-cli doesn't work when I download a website with an expired SSL certificate. I directly modify the source code so that will take effect just like #5 add browserOptions.ignoreHTTPSErrors=true . But you close it as you say Options should not be hardcoded, especially when they have an impact on security. So, the value should come from options and MUST NOT be set to true by default

- const browserOptions = {};
+ const browserOptions = {
+	ignoreHTTPSErrors: true
+ }

So now if I don't modify the code, I can't download the website with expired ssl. I can't find the entry of single-file-cli to ignore the SSL certificate error, so I raise an issue to ask if it is ignored, or there is a place to set it just I did not see it.

from single-file-cli.

gildas-lormeau avatar gildas-lormeau commented on June 9, 2024

Thank you for the additional info, I just pushed the support of the new option --browser-ignore-insecure-certs. It should work fine with all back-ends used by the CLI.

from single-file-cli.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.