GithubHelp home page GithubHelp logo

Comments (6)

kevinzakka avatar kevinzakka commented on June 2, 2024

It connects joints and body center-of-masses as mentioned here.

from mujoco.

vikashplus avatar vikashplus commented on June 2, 2024

Do you understand, why it is conceptually useful?

I'm not sure it's implemented properly, even at its face value. For example

  1. The connect shooting back from the ankle in the humanoid is neither the joint-location nor the body COM.
  2. Below is another model with connect having weird patterns at the knee, elbow, and something that shoots up in the sky from the torso. Again these aren't joints or COMs.
image

from mujoco.

kevinzakka avatar kevinzakka commented on June 2, 2024

I modified the visualization code to plot all body COMs along with the joints and autoconnect. I get the below for model/humanoid/humanoid.xml:

autoconnect

I would encourage you to plot the body CoMs in your model, you may have weird inertial values? Note that body frame CoM is not necessarily equal to body inertial CoM.

from mujoco.

kevinzakka avatar kevinzakka commented on June 2, 2024

@vikashplus I just inspected the code and it looks like when inertias are turned on, the body frame visualization will switch from xpos to xipos so no need to visualize the spheres as I did. So just redo your inspection with inertias turned on (hit I). Might be hard to see with all the red but it should confirm that autoconnect is correctly drawn.

from mujoco.

vikashplus avatar vikashplus commented on June 2, 2024

It gets confused for bodies with no geoms.
I still don't understand what's the use of this visualization. Won't it be more useful if it was rendering just the kinematic chain?

from mujoco.

yuvaltassa avatar yuvaltassa commented on June 2, 2024

@vikashplus the code is right here, how do you want to change it? If you think there is something better just modify the code and send us a PR. This is very easy, I know you can do it 🙂

If that's too hard, attach a minimal model that doesn't do what you expect and we can fix it.

from mujoco.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.