graduateddylinder / prj-rev-bwfs-dasmoto Goto Github PK

Good job specifying the span css selector class and good choice of name. Clear and concise names are the best. This gives you more flexibility as your code grows in size and makes your code more reusable since if you need to do similar highlighting in the future, you can just reference this again.

https://github.com/dhickson/prj-rev-bwfs-dasmoto/blob/master/Dasmotos/index.html#L24

Make your header font smaller. When the screen is narrow, it takes up too much space. In the future, you can use mobile resizing to change the font size and your screen size changes.

https://github.com/dhickson/prj-rev-bwfs-dasmoto/blob/master/Dasmotos/resources/css/style.css#L10

Try adding comments to your css page. Unlike html, css code is not naturally defined by its structure. So having comments helps you organize it and quickly navigate it. As a suggestion, add comments at the start of each section of the corresponding html code so readers can follow clearly between the two files. This will become very useful in the future as your code grows and your css becomes more complicated.

https://github.com/dhickson/prj-rev-bwfs-dasmoto/blob/master/Dasmotos/resources/css/style.css#L1

Try to save your images locally instead of adding a link. Saving images adds to the stability of your website because your website is not reliant on the link to be valid all the time. So next time, save all the images under resources/images/

https://github.com/dhickson/prj-rev-bwfs-dasmoto/blob/master/Dasmotos/index.html#L13

Use the html & sign instead of just &, which is &

https://github.com/dhickson/prj-rev-bwfs-dasmoto/blob/master/Dasmotos/index.html#L9

Summary Grade: Satisfactory

Good job with your code! I really like the use of indentation and whitespace in your html code! Makes your code very easy to read! Also, good decisions on the classes and ids name. It makes it very clear what its purpose is and makes grouping your sections very effective. These organizational skills come in handy as you expand your code. Great start to the Ready program!

I included a few notes in both the html can css files for you to think more critically about. First, try to save your images locally instead of adding a link. Saving images adds to the stability of your website because your website is not reliant on the link to be valid all the time. Also, make sure to use the html & sign instead of just &, which is &. This is just a convention.