prj-rev-bwfs-dasmoto's Issues
Use proper html & sign
Use the html & sign instead of just &, which is &
https://github.com/dhickson/prj-rev-bwfs-dasmoto/blob/master/Dasmotos/index.html#L9
Great use of span and class to specify code
Good job specifying the span css selector class and good choice of name. Clear and concise names are the best. This gives you more flexibility as your code grows in size and makes your code more reusable since if you need to do similar highlighting in the future, you can just reference this again.
https://github.com/dhickson/prj-rev-bwfs-dasmoto/blob/master/Dasmotos/index.html#L24
Make font smaller
Make your header font smaller. When the screen is narrow, it takes up too much space. In the future, you can use mobile resizing to change the font size and your screen size changes.
https://github.com/dhickson/prj-rev-bwfs-dasmoto/blob/master/Dasmotos/resources/css/style.css#L10
Add comments to your css
Try adding comments to your css page. Unlike html, css code is not naturally defined by its structure. So having comments helps you organize it and quickly navigate it. As a suggestion, add comments at the start of each section of the corresponding html code so readers can follow clearly between the two files. This will become very useful in the future as your code grows and your css becomes more complicated.
https://github.com/dhickson/prj-rev-bwfs-dasmoto/blob/master/Dasmotos/resources/css/style.css#L1
SUMMARY
Summary Grade: Satisfactory
Good job with your code! I really like the use of indentation and whitespace in your html code! Makes your code very easy to read! Also, good decisions on the classes and ids name. It makes it very clear what its purpose is and makes grouping your sections very effective. These organizational skills come in handy as you expand your code. Great start to the Ready program!
I included a few notes in both the html can css files for you to think more critically about. First, try to save your images locally instead of adding a link. Saving images adds to the stability of your website because your website is not reliant on the link to be valid all the time. Also, make sure to use the html & sign instead of just &, which is &.
This is just a convention.
Save images locally
Try to save your images locally instead of adding a link. Saving images adds to the stability of your website because your website is not reliant on the link to be valid all the time. So next time, save all the images under resources/images/
https://github.com/dhickson/prj-rev-bwfs-dasmoto/blob/master/Dasmotos/index.html#L13
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.