grafana / k6-circleci-orb Goto Github PK

Orb version: grafana/[email protected]

What happened:

I am using a near copy of the guidance from the tutorial document I shared below:

version: 2.1
orbs:
grafana: grafana/[email protected]
workflows:
load_test:
jobs:

• grafana/k6:
  script: loadtests/performance-test.js --out json=full.json > /tmp/artifacts

While I can see there is output occurring due to circleCI artifacts tab having the following contents (I have broken the link on purpose for security reasons):

tmp/artifacts

When I click on that artifact, it is not json, it is typical output you get in CLI, such as this:

execution: local
script: loadtests/performance-test.js
output: json (full.json)

scenarios: (100.00%) 1 scenario, 1 max VUs, 40s max duration (incl. graceful stop):
* protocol: 1 looping VUs for 10s (exec: protocol, gracefulStop: 30s)

There is no JSON file on the filesystem

Expected behavior:

I would expect the JSON file to be available on the filesystem. I see the uploading artifacts step occur but I cannot see that JSON file anywhere. Perhaps I'm missing something?

Uploading /tmp/artifacts to tmp/artifacts
Uploading /tmp/artifacts (3.1 kB): DONE
Total size uploaded: 3.1 KiB

Additional Information:

Hello,

I'm attempting to use the k6 orb to run k6 tests via circleCI. I am able to achieve this by following the guidance here: https://grafana.com/blog/2022/03/06/load-testing-with-circleci/

Hello All,

My name is Kyle from the CircleCI Community and Partner Engineering team following up on my email with some review items on the current orb.

1. If the command is not meant to be used by end-users, do not create it.
   a. Instead, simply contain all logic within the job. No commands are needed.
   b. https://github.com/k6io/circleci-orb/blob/main/src/commands/run-test.yml
2. Allow the user to specify a specific docker tag.
   a. https://github.com/k6io/circleci-orb/blob/a1ae46a30dcd2fd80640c3a98f2fb3c95f1771fe/src/jobs/test.yml#L4
   b. Parameterize the tag portion of the docker image.
   c. Specifying a tag is important for CI so users can test against known and good versions.
   e. Example: https://github.com/CircleCI-Public/node-orb/blob/3d313ec2fbc9dd2a5c804d9b142e2419c4176ca4/src/executors/default.yml#L14
3. Private information should be accessed via environment variables, not hard-coded strings in the config.
   a. https://github.com/k6io/circleci-orb/blob/a1ae46a30dcd2fd80640c3a98f2fb3c95f1771fe/src/jobs/test.yml#L23
   b. https://circleci.com/docs/2.0/orb-author-faq/?section=configuration#secure-api-tokens