gveitbatz / katch Goto Github PK

After testing the code, I found it is a approximate solution, not exact shortest travel time for a query.
But see from the readme, it called TCH, which is exact query. Is there any misunderstanding?

Thank you for your time.

I am doing experiments on TDRoadNetwork too, but there is no way to get a access to real world day.
Please refers me a way to get data.
Thanks anyway.

Best regard.

I could not understand how the TFFs are defined in the tgpr(what is x and y coordinates in TTFs) input file and how to generate the demand file as binary
Examples with explanation would be really helpful.

The function in ttf_wrapper.h at line 302 declared type is pair, but may return double, which may cause compile errors in some platforms.

    std::pair<double,double> get_min_max() const noexcept
    {
        if ( _is_constant ) return _constant_value;

        assert( _ttf_impl_ptr );
        return std::make_pair(_ttf_impl_ptr->get_min(), _ttf_impl_ptr->get_max());
    }

Hi,

I needed quite some time to notice that the constructor TchEAQuery always moves the graph, even though no std::move is present at the caller site. More usually C++ patterns are either passing the graph by const reference or passing it by value. In the later case the caller can use std::move to elude the copy. The advantage of this pattern is that there is an indication at the caller site that the internals of the caller's graph object have been ripped out. This indication is missing in your code.

Another problem is that I need the graph to lookup details of the extracted path, such as for example the TTF of each edge. With the current design, this is not possible. The only graph instance has been moved into the query object. The query object has no get_graph function and therefore the graph has become inaccessible to the caller.

The cleanest solution would in my eyes be to have TchEAQuery only reference the graph object and not copy it. This way you could also have several query objects, as needed for multiple worker threads, on the same graph.

The easier to implement solution is to remove the && from the constructor, add std::move to the examples, and add a get_graph method.

Best Regards
Ben

Hi, I am trying to compiling your work but find error alert.

Error Messages like
"/home/syc/boost_1_64_0/boost_1_64_0/boost/type_traits/integral_promotion.hpp:151:32: error: ‘value’ has not been declared"
"/home/syc/boost_1_64_0/boost_1_64_0/boost/lexical_cast/try_lexical_convert.hpp:29:28: error: expected ‘}’ before end of line"
pops up when I type in

"g++ -O3 -DNDEBUG -fopenmp -I.. -isystem /home/syc/boost_1_64_0/boost_1_64_0 -std=c++11 -o run_ordering run_ordering.cpp"

Would mind tell me how could I fix this problem?

search_graph.h line number 54 and order_edge_data.h line number 56 state:

    static constexpr double PERIOD = 864000.0;

A day has 86400 seconds, i.e., one zero less. Is this a bug?

Why is the period a compile time constant, when doc/tpgr_format.html states that the input format may override the default?