[BUG] Log flood in the debug console by default. about cursive

[gyscos]

Hi,
That's interesting; what kind of debug logs are you seeing?

Grepping for log:: in the repo, I see a couple warn!, but that's about it. It's possible some dependencies do emit logs of their own though; emitting a lot of things at the DEBUG level doesn't sound unreasonable.

The current logger implementation is also very basic, and doesn't offer much filtering. Something like flexi-logger should allow you to specify per-module levels, so you could only allow warnings and errors from cursive (and other dependencies), but see info logs from your own module.

[blaisdellma]

Running the above example, I'm seeing logs from

• LinearLayout::required_size().
• TextArea::required_size()
• TextArea::soft_compute_rows()
• TextArea::draw()

I'm using tracing with tracing-subscriber and it has a feature 'env-filter' which allows you to set per-module logging levels. Without it I get spammed with debug messages from LinearLayout.

It seems like even when at the bottom of a ScrollView scrolling causes a redraw and triggers more debug messages. I think this is because the debug console is added as a layer on the current screen so scrolling the debug console causes the rest of the screen to be redrawn. I guess this didn't get caught cause only some views have debug messages in draw(). Searching for log::debug shows that only 3 views (LinearLayout, TextArea, and ListView) use debug messages at all . The only other parts of cursive that use log::debug are the ncurses and pancurses backends.

Also, the reason that setting RUST_LOG=info is ineffective is because CursiveLogger::enabled() is hardcoded to true, instead of checking the log level. There's even a TODO in CursiveLogger::init() for this.

I think this can be addressed by:

• changing CursiveLogger to set a log level by checking RUST_LOG or as an argument to cursive::logger::init()
• changing the debug console to use a new screen instead of just a layer on the current screen to avoid redrawing application and triggering lots of extra debug messages when scrolling

[Tandolf]

i experienced this today also, in the debug console, logs are flooded with cursive logs. Nice to see that this is being addressed. When might we see a new release with the fixed?