Registering the service one should provide absolute path, otherwise exception is thrown about my.extensions.localization.json

[hishamco]

@shahabganji let me try your scenario to make sure that I can reproduce the bug, if you think your fix is a real bug, you could send a PR if you want ..

Thanks

[shahabganji]

@hishamco The PR created, hope it helps

[hishamco]

I see, I don't now you are running on Mac OS, so I need to create a functional test, so AzurePipeline should fail if there's issue

I will try create it ASAP

Thanks again

[hishamco]

Also I will try your change to check if it's work with me too on Windows

[shahabganji]

Dear @hishamco, check PR #44 . I've added functional tests for one of the samples, LocalizationSample, do we need another one for LocalizationSample.Mvc?

[hishamco]

I need to add some new features, then I will release 2.1.0 hope this will not take more than few days

[hishamco]

Thanks for reporting this, but did you try to run the sample, it should work as expected

[shahabganji]

Dear @hishamco, thanks for the prompt reply, yes I ran the sample with a controller trying to use IStringLocalizer

    [Route("")]
    public class TestController : ControllerBase
    {
        private readonly IStringLocalizer _localizer;

        public TestController(IStringLocalizer localizer)
        {
            _localizer = localizer;
        }

        [HttpGet]
        public string Get() => _localizer["Hello"];
    }

---- EDIT ------

The startup method Configure:

public void Configure(IApplicationBuilder app, IHostEnvironment env, IStringLocalizer localizer1, IStringLocalizer<Startup> localizer2)
        {
            var supportedCultures = new List<CultureInfo>
            {
                new CultureInfo("en-US"),
                new CultureInfo("fr-FR")
            };
            var options = new RequestLocalizationOptions
            {
                DefaultRequestCulture = new RequestCulture("en-US"),
                SupportedCultures = supportedCultures,
                SupportedUICultures = supportedCultures
            };

            app.UseRequestLocalization(options);

            if (env.IsDevelopment())
            {
                app.UseDeveloperExceptionPage();
            }

            app.Run(async (context) =>
            {
                await context.Response.WriteAsync($"{localizer1["Hello"]}!!");
                await context.Response.WriteAsync($"{localizer2["Hello"]}!!");
            });

            app.UseRouting();
            app.UseEndpoints(endpoints => { endpoints.MapControllers(); });
        }

[hishamco]

I need to check the sample with your changes first before I review the PR

Thanks

[hishamco]

@shahabganji I think there's some confusion here you 're using IStringLocalizer instead of IStringlocalizer<T> which is may causes a strange behavior

Please refer to my new added sample here

Hope it clarifies what's the preferred localizer you should use as well as resource name conventions

[hishamco]

Merged into dev

[shahabganji]

@hishamco
I still get the same error, even with IStringLocalizer<HomeController>; besides using IStringLocalizer<T> only loads messages from T.{culture}.json file, right? however, using non-generic IStringLocalizer will load messages which are not only for a specific class/controller, like some global shared messages.

I added the following to resolve problem in Startup -> ConfigureServices

services.AddJsonLocalization(
                options => options.ResourcesPath = Path.Combine(
                    Directory.GetCurrentDirectory(), "Resources"));

without that it is like :

note that the response is 500 Internal Server Error

and this is the log :

Microsoft.AspNetCore.Server.Kestrel: Error: Connection id "0HLUNLKCTNMP6", Request id "0HLUNLKCTNMP6:00000001": An unhandled exception was thrown by the application.

System.ArgumentException: The path must be absolute. (Parameter 'root')
   at Microsoft.Extensions.FileProviders.PhysicalFileProvider..ctor(String root, ExclusionFilters filters)
   at Microsoft.Extensions.FileProviders.PhysicalFileProvider..ctor(String root)
   at Microsoft.Extensions.Configuration.FileConfigurationExtensions.SetBasePath(IConfigurationBuilder builder, String basePath)
   at My.Extensions.Localization.Json.JsonStringLocalizer.<>c__DisplayClass16_0.<BuildResourcesCache>b__0(String _) in /Users/shahab/dev/playground/My.Extensions.Localization.Json/src/My.Extensions.Localization.Json/JsonStringLocalizer.cs:line 173
   at System.Collections.Concurrent.ConcurrentDictionary`2.GetOrAdd(TKey key, Func`2 valueFactory)
   at My.Extensions.Localization.Json.JsonStringLocalizer.BuildResourcesCache(String culture) in /Users/shahab/dev/playground/My.Extensions.Localization.Json/src/My.Extensions.Localization.Json/JsonStringLocalizer.cs:line 162
   at My.Extensions.Localization.Json.JsonStringLocalizer.GetStringSafely(String name) in /Users/shahab/dev/playground/My.Extensions.Localization.Json/src/My.Extensions.Localization.Json/JsonStringLocalizer.cs:line 101
   at My.Extensions.Localization.Json.JsonStringLocalizer.get_Item(String name) in /Users/shahab/dev/playground/My.Extensions.Localization.Json/src/My.Extensions.Localization.Json/JsonStringLocalizer.cs:line 42
   at Microsoft.Extensions.Localization.StringLocalizer`1.get_Item(String name)
   at LocalizationSample.Mvc.Controllers.HomeController.Index() in /Users/shahab/dev/playground/My.Extensions.Localization.Json/samples/LocalizationSample.Mvc/Controllers/HomeController.cs:line 19
   at lambda_method(Closure , Object , Object[] )
   at Microsoft.Extensions.Internal.ObjectMethodExecutor.Execute(Object target, Object[] parameters)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ActionMethodExecutor.SyncObjectResultExecutor.Execute(IActionResultTypeMapper mapper, ObjectMethodExecutor executor, Object controller, Object[] arguments)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.InvokeActionMethodAsync()
   at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.Next(State& next, Scope& scope, Object& state, Boolean& isCompleted)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.InvokeNextActionFilterAsync()
--- End of stack trace from previous location where exception was thrown ---
   at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.Rethrow(ActionExecutedContextSealed context)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.Next(State& next, Scope& scope, Object& state, Boolean& isCompleted)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.InvokeInnerFilterAsync()
--- End of stack trace from previous location where exception was thrown ---
   at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.<InvokeFilterPipelineAsync>g__Awaited|19_0(ResourceInvoker invoker, Task lastTask, State next, Scope scope, Object state, Boolean isCompleted)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.<InvokeAsync>g__Awaited|17_0(ResourceInvoker invoker, Task task, IDisposable scope)
   at Microsoft.AspNetCore.Routing.EndpointMiddleware.<Invoke>g__AwaitRequestTask|6_0(Endpoint endpoint, Task requestTask, ILogger logger)
   at Microsoft.AspNetCore.Localization.RequestLocalizationMiddleware.Invoke(HttpContext context)
   at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.HttpProtocol.ProcessRequests[TContext](IHttpApplication`1 application)

[hishamco]

That means the error occurs when you are using IStringLocalizer alone or beside IStringLocalizer<T> right?

[shahabganji]

I just checked out the project and run the new sample as dotnet project. I have the same error no matter which type of usage, IStringLocalizer<T> alone also produces the error. using both together also produces error.

my current controller :

using System;
using Microsoft.AspNetCore.Mvc;
using Microsoft.Extensions.Localization;

namespace LocalizationSample.Mvc.Controllers
{
    [Route("")]
    public class HomeController : Controller
    {
        private readonly IStringLocalizer<HomeController> _localizer;

        public HomeController(IStringLocalizer<HomeController> localizer)
        {
            _localizer = localizer ?? throw new ArgumentNullException(nameof(localizer));
        }

        public string Index()
        {
            var result = _localizer["Hello"].Value;
            
            return result;
        }
    }
}

and Startup.cs

using Microsoft.AspNetCore.Builder;
using Microsoft.AspNetCore.Hosting;
using Microsoft.Extensions.DependencyInjection;
using Microsoft.Extensions.Hosting;

namespace LocalizationSample.Mvc
{
    public class Startup
    {
        public void ConfigureServices(IServiceCollection services)
        {
            services.AddControllers();
            services.AddJsonLocalization(options => options.ResourcesPath = "Resources");
        }

        public void Configure(IApplicationBuilder app, IWebHostEnvironment env)
        {
            app.UseRequestLocalization("en-US", "fr-FR");

            if (env.IsDevelopment())
            {
                app.UseDeveloperExceptionPage();
            }

            app.UseRouting();

            app.UseEndpoints(endpoints => endpoints.MapControllers());
        }
    }
}

I have two resource files, HomeController.fr-FR.json and fr-FR.json

changed the line to services.AddJsonLocalization( options => options.ResourcesPath = Path.Combine(Directory.GetCurrentDirectory(), "Resources")); and it works like a charm.

[shahabganji]

Also changing Line 174 to

.SetBasePath(Path.Combine(Directory.GetCurrentDirectory() ,_resourcesPath))

solved the issue.

[hishamco]

I did few updates after I support JsonHtmlLocalizer, I will try to use IStringLocalizer alongside with IStringLocalizer to reproduce the error

[shahabganji]

You meant IStringLocalizer alongside IStringLocalizer<T>? but in this case IStringLocalizer<T> alone also throws an exception. Anyway thanks for the follow ups.

[hishamco]

Seems I confused, could please try the latest sample LocalizationSample.Mvc and let me know what are the required changes to raise the error

[shahabganji]

I exactly did that. No Changes required. please check here and here

I just checked out the project and run the new sample as dotnet project. I have the same error no matter which type of usage, IStringLocalizer <T> alone also produces the error. using both together also produces error.

[hishamco]

Seems you didn't fetch the latest bits ;) I just merged a new commits anyhow I don't have such T.{culture}.json file, furthermore there's no error occurs on IStringLocalizer<HomeController> at all

[hishamco]

This is a French version of how Privacy page is look like at my end

[shahabganji]

By T I meant HomeController, I pulled the latest version, however, the problem still exist. I did no changes just the ran the sample

• URL: https://localhost:8001/Home/Privacy/?culture-fr-FR&ui-culture=fr-FR
• error the same as before:

Microsoft.AspNetCore.Server.Kestrel: Error: Connection id "0HLUNMASR1PM7", Request id "0HLUNMASR1PM7:00000001": An unhandled exception was thrown by the application.

System.ArgumentException: The path must be absolute. (Parameter 'root')
   at Microsoft.Extensions.FileProviders.PhysicalFileProvider..ctor(String root, ExclusionFilters filters)
   at Microsoft.Extensions.FileProviders.PhysicalFileProvider..ctor(String root)
   at Microsoft.Extensions.Configuration.FileConfigurationExtensions.SetBasePath(IConfigurationBuilder builder, String basePath)
   at My.Extensions.Localization.Json.JsonStringLocalizer.<>c__DisplayClass16_0.<BuildResourcesCache>b__0(String _) in /Users/shahab/dev/playground/My.Extensions.Localization.Json/src/My.Extensions.Localization.Json/JsonStringLocalizer.cs:line 173
   at System.Collections.Concurrent.ConcurrentDictionary`2.GetOrAdd(TKey key, Func`2 valueFactory)
   at My.Extensions.Localization.Json.JsonStringLocalizer.BuildResourcesCache(String culture) in /Users/shahab/dev/playground/My.Extensions.Localization.Json/src/My.Extensions.Localization.Json/JsonStringLocalizer.cs:line 162
   at My.Extensions.Localization.Json.JsonStringLocalizer.GetStringSafely(String name) in /Users/shahab/dev/playground/My.Extensions.Localization.Json/src/My.Extensions.Localization.Json/JsonStringLocalizer.cs:line 101
   at My.Extensions.Localization.Json.JsonStringLocalizer.get_Item(String name) in /Users/shahab/dev/playground/My.Extensions.Localization.Json/src/My.Extensions.Localization.Json/JsonStringLocalizer.cs:line 42
   at Microsoft.Extensions.Localization.StringLocalizer`1.get_Item(String name)
   at LocalizationSample.Mvc.Controllers.HomeController.Privacy() in /Users/shahab/dev/playground/My.Extensions.Localization.Json/samples/LocalizationSample.Mvc/Controllers/HomeController.cs:line 22
   at lambda_method(Closure , Object , Object[] )
   at Microsoft.Extensions.Internal.ObjectMethodExecutor.Execute(Object target, Object[] parameters)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ActionMethodExecutor.SyncActionResultExecutor.Execute(IActionResultTypeMapper mapper, ObjectMethodExecutor executor, Object controller, Object[] arguments)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.InvokeActionMethodAsync()
   at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.Next(State& next, Scope& scope, Object& state, Boolean& isCompleted)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.InvokeNextActionFilterAsync()
--- End of stack trace from previous location where exception was thrown ---
   at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.Rethrow(ActionExecutedContextSealed context)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.Next(State& next, Scope& scope, Object& state, Boolean& isCompleted)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.InvokeInnerFilterAsync()
--- End of stack trace from previous location where exception was thrown ---
   at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.<InvokeNextResourceFilter>g__Awaited|24_0(ResourceInvoker invoker, Task lastTask, State next, Scope scope, Object state, Boolean isCompleted)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.Rethrow(ResourceExecutedContextSealed context)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.Next(State& next, Scope& scope, Object& state, Boolean& isCompleted)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.InvokeFilterPipelineAsync()
--- End of stack trace from previous location where exception was thrown ---
   at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.<InvokeAsync>g__Awaited|17_0(ResourceInvoker invoker, Task task, IDisposable scope)
   at Microsoft.AspNetCore.Routing.EndpointMiddleware.<Invoke>g__AwaitRequestTask|6_0(Endpoint endpoint, Task requestTask, ILogger logger)
   at Microsoft.AspNetCore.Localization.RequestLocalizationMiddleware.Invoke(HttpContext context)
   at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.HttpProtocol.ProcessRequests[TContext](IHttpApplication`1 application)

I did the same thing to solve the problem and it worked.
I don't know whether the OS matters or not, mine is Mac OS X

[hishamco]

If you wish to create a functional test that runs the LocalizationSample.Mvc that I created in you PR it will be very good to make sure that your changes works on ever OS

[shahabganji]

No problem I'll put a time on that.

[hishamco]

I request few changes on your PR, please fix them and let me know if you need help on creating a functional test

Thanks Saeed

[shahabganji]

Sure, just give me some time till evening, currently at the middle of some important stuff, is that okay?

[hishamco]

Take your time .. I will try to fix and improve something else meanwhile

[hishamco]

I will have a look ...

Thanks

[shahabganji]

@hishamco Please also update the nuget feed. thanks 🙏

[hishamco]

Do you mean upload a NuGet package?

[shahabganji]

Yes.

…

Am 03.04.2020 um 20:19 schrieb Hisham Bin Ateya ***@***.***>:  Do you mean upload a NuGet package? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.