GithubHelp home page GithubHelp logo

Comments (14)

hishamco avatar hishamco commented on July 20, 2024

Hi @GreenShadeZhang I did some localization in Oqtane Framework (Blazor), I may look again into the JsonLocalizer

Also, can the name of this library be changed to a more formal name? The name gives a less formal feel.

I'm not sure if it's the right time, I followed the same naming convension of ASP.NET Core Extensions at the beginning, I think it's not a big issue while there's a tags attached on the NuGet package

Thanks

from my.extensions.localization.json.

GreenShadeZhang avatar GreenShadeZhang commented on July 20, 2024

Hi @GreenShadeZhang I did some localization in Oqtane Framework (Blazor), I may look again into the JsonLocalizer

Also, can the name of this library be changed to a more formal name? The name gives a less formal feel.

I'm not sure if it's the right time, I followed the same naming convension of ASP.NET Core Extensions at the beginning, I think it's not a big issue while there's a tags attached on the NuGet package

Thanks

Hello, have you tested some problems in the NET5.0 Blazor WebAssembly project?

from my.extensions.localization.json.

hishamco avatar hishamco commented on July 20, 2024

Sorry @GreenShadeZhang I was busy last few days, hope to do it today or tommrow, could you please create a minimal repo, so I can easily figure out the issue and test it

from my.extensions.localization.json.

GreenShadeZhang avatar GreenShadeZhang commented on July 20, 2024

Sorry @GreenShadeZhang I was busy last few days, hope to do it today or tommrow, could you please create a minimal repo, so I can easily figure out the issue and test it

https://github.com/GreenShadeZhang/BlazorAppTest

This is a NET5.0 Blazor WebAssembly test project, the main reason is to expose Microsoft.AspNetCore.Mvc namespace problems, I looked at the source code NET5.0 Blazor WebAssembly multi-language only used Microsoft.Extensions.Localization, your library is implemented razor page and mvc interface, I hope you'll help you see if you're going to leave the library alone for Blackzor Web Assembly or continue in compatibility mode.

from my.extensions.localization.json.

hishamco avatar hishamco commented on July 20, 2024

Thanks @GreenShadeZhang, I will have a look ...

from my.extensions.localization.json.

hishamco avatar hishamco commented on July 20, 2024

Seems I was wrong when I add Microsoft.AspNetCore.Mvc.Localization I will try to look to the commits history

from my.extensions.localization.json.

hishamco avatar hishamco commented on July 20, 2024

I figure out the issue, which came from introduing JsonHtmlLocalizer, so I will move into into another assembly, so Blazor will not complain then ...

from my.extensions.localization.json.

hishamco avatar hishamco commented on July 20, 2024

PR #46 is the main reason for this, a better solution is to create another package for MVC specific localization

from my.extensions.localization.json.

hishamco avatar hishamco commented on July 20, 2024

@GreenShadeZhang I just removed the dependency, hopefully I will release the upcoming release with few days, you could try GitHub Packages for now without waiting https://github.com/hishamco?tab=packages&repo_name=My.Extensions.Localization.Json please let me know if this fix your issue

from my.extensions.localization.json.

GreenShadeZhang avatar GreenShadeZhang commented on July 20, 2024

@GreenShadeZhang I just removed the dependency, hopefully I will release the upcoming release with few days, you could try GitHub Packages for now without waiting https://github.com/hishamco?tab=packages&repo_name=My.Extensions.Localization.Json please let me know if this fix your issue

When I use the package you remove, there will also be an error, as if it were an error caused by a resource path read, and it is recommended that you test it with the NET5.0 Blazor WebAssembly project.

image

from my.extensions.localization.json.

hishamco avatar hishamco commented on July 20, 2024

Please refer me to the page that causes the issue, I will try to update the blazor sample to NET5.0

from my.extensions.localization.json.

GreenShadeZhang avatar GreenShadeZhang commented on July 20, 2024

Please refer me to the page that causes the issue, I will try to update the blazor sample to NET5.0

Hello this time I test your code, I upgraded sdk to net5.0, managed in server mode, running your code is normal, but when I use WebAssembly to produce file read problems, the cause of the problem is that the json file read place blazor has adjustments, resulting in not being able to take the path to get jason files, this is my guess, I hope you have time also test, originally I intended to give a pr but I did not test successfully.

from my.extensions.localization.json.

hishamco avatar hishamco commented on July 20, 2024

Feel free to submit a PR if it's required, I will check the Blazor WebAssembly app too

from my.extensions.localization.json.

hishamco avatar hishamco commented on July 20, 2024

We update to .NET 7 reopen if you still facing the issue

from my.extensions.localization.json.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.