System.ArgumentOutOfRangeException: startIndex cannot be larger than length of string. about my.extensions.localization.json

[hishamco]

Thanks for reporting this @mwillems1994, could you please try LocalizationSample.Mvc it uses AddDataAnnotationsLocalization

[mwillems1994]

In your example you pass RegisterViewModel instead of type
options.DataAnnotationLocalizerProvider = (type, factory) => factory.Create(typeof(RegisterViewModel));
Therefore it never passes types such as string or guid

[hishamco]

Therefore it never passes types such as string or guid

Could please elaborate? or share a minimal repo, so I can see the bug

[mwillems1994]

Thanks for your quick reply.

To reproduce this to the following:

Add this to your startuo
services.AddControllers() .AddDataAnnotationsLocalization(options => { options.DataAnnotationLocalizerProvider = (type, factory) => factory.Create(type); });

Note that i pass type to factory.Create instead of typeof(RegisterViewModel).

Now add this controller
`[AllowAnonymous]
public class TestController: ControllerBase
{
[HttpGet("working")]
public async Task TestWorkingAsync()
{
return "Working";
}

[HttpGet("{test}/NotWorking")]
public async Task<string> TestNotWorkingAsync(Guid test)
{
    return "Not working";
}

}`

When you request Test/guid here/NotWorking, you get the error.

[hishamco]

Thanks for the info, hope to check this ASAP

[mwillems1994]

Thanks

[hishamco]

One more thing, how the action is related to the DataAnnotation?

[mwillems1994]

That is a good question, i think it is because the parameter is passed to the function and therefore it counts as a DataAnnotation.

[hishamco]

Hmmm, first time I saw this behavior, I will try to debug this one

[mwillems1994]

I took a quick look yesterday and it seems that you use the substring only to make a key in the dictionary. Maybe find an alternative way to build the key.

I'll see if i can make some time in the weekend and have a better look.

[hishamco]

Feel free to submit a PR if you have a better way

Thanks