hive-engine / hivesmartcontracts

Hive-Engine node software

Hive Engine

Frontend for hive-engine.com

Recommended IDE Setup

VSCode + Volar (and disable Vetur) + TypeScript Vue Plugin (Volar).

Customize configuration

See Vite Configuration Reference.

Project Setup

npm install

Compile and Hot-Reload for Development

npm run dev

Compile and Minify for Production

npm run build

Lint with ESLint

npm run lint

hivesmartcontracts's Issues

transferOwnership action of nft contract lacks emits

transferOwnership emits no success message. It also emits no error when the NFT doesn't exist. This makes the outcome unknowable as pass and fail are both silent. For recent transactions, checking against an engine api or attempting a transaction can confirm the outcome. This workaround is not effective for historical data

Cannot start node as non light node

When attempting to start a node for the first time syncing from genesis, with no data, and disabling light mode in the config, the following error occurs:

Can't switch from a node, which was previously a light node, to a full node. Please restore your database from a full node dump.

NFTs not getting sold due to nft not being on the market emits no logs

example: https://he.dtools.dev/tx/c1d0a25188dd5a3c6fc8b406cde9caa64cef59d0 that particular NFT is not for sale, but does not emit an error

Add Timeout For RPC Calls

RPC calls that take longer than an arbitrary number of ms(defined in config) should be killed and the mongo query killed too with a request took too long error message

Cannot get transaction details of batched customjson actions

url: "https://engine.rishipanthee.com/blockchain"

params:
{"jsonrpc":"2.0","id":1,"method":"getTransactionInfo","params":{"txid":"0ce321d8f434c89ce0d8ef335126228b6e2d6811"}}

Customjson returns this txid 5cdf10b629cbf2d148d416d0f41aa6be7625b806. I have batched multiple actions inside the same json to get around the engine limits. When fetching the result using the transaction id received from the customjson, the above api call returns null. The call needs to be modified as txid-0, txid-1 for each batched action.

An alternate route that provides info for the entire transaction would be helpful.

Discussion: Increase Backup Witness Pay To Be 5x T20 rate

Backup witnesses get selected less often than regular witnesses, and to compensate them for that, Hive pays them at an increased rate of 5x of T20. Engine should consider doing the same as backups earn a lot less than T20 as of now.

Add totalStakedAmount to stakable tokens

Should have an easy way to see total amount staked rather than having to calculate it.

Discussion: RPC server automatic recovery

Wanted to start a discussion to see if anyone has ideas on how to improve the reliability of the RPC server.

The recent issues with batch requests caused the behavior where the RPC server stops responding and does not auto-recover. PM2 does not detect the issue and does not restart the service automatically. The node operator has to notice there is an issue and go call pm2 restart. Not ideal when it happens in the middle of the night.

How can we make it more resilient? Can the node detect the problem and restart itself? Currently, the death of the RPC server does not crash the whole service, so PM2/docker cannot know if it needs to be restarted.

Maybe needs more investigation to understand why the server stops responding. without throwing exception

setProperties in nft contract missing emit

See https://he.dtools.dev/tx/fbf3c18b153e3683c6264605412d5ea2bae885b4

Investigate Why Auto Node Switching Doesn't Always Work

In some cases, auto node switching doesn't work. It's based off the dhive implementation, so looking at the upstream codebase might be necessary.

Add equivalent of Hive fill_or_kill to market contract

Idea from stoodkev:

On Hive internal market you can make a transaction like this :
https://hiveblocks.com/tx/29184b361fe8eceaaeac44d38e1dbb807d4e7ee5

Basically saying I want to sell all of this amount of HIVE, and cancel it if the result is not at least this amount of HBD
That makes it possible to define a kind of slippage on the market buy or market sell.

That would be super helpful because as it is, we can only implement "soft slippage" based on a market estimate at a given time, but we can't make sure that the slippage would be respected.

NFT Add Authorized Issuing Account Not Appearing On History For Added Account

For example in this trx: https://he.dtools.dev/tx/920592c5e119703ae2ef48819f4a6b5c49a0daf8 betterdev was added as an authorized account. The log shows up for poshtoken but not for betterdev.

Add Test For Witness_Actions Script

The witness actions script should have tests to ensure it's functionality hasn't been broken.

Resolve NFTMarket Contract Silent Fail

There exists a silent fail condition on the nftmarket contract: https://he.dtools.dev/tx/b6cb80d68027aa5dbc600ef4a786ee67b3e7e2e1-0

That should be fixed.

No Test For witness disabling

There exists no test for witness meeting missedRoundsInARow and a new witness being selected. One should be created.

Discussion: Only reward witness who produced the round

Right now, all witnesses involved in a round get rewarded. We might potentially want to change this to only pay out the one witness who produced the round, and increase the amount they get by a factor of top witness count. In the long term, it should even out to being the same amount paid out to the witnesses.