ichunjo / vardautomation Goto Github PK

mkvmerge returns exit code 1 if a warning is thrown (see: docs). However, currently this forcibly halts the muxing in vardautomation, because it errors before it can actually output anything it appears (and consequently, no cleaning up can be run either).

There should be an additional check to catch the exit code, if possible, and let vardautomation know that it's a non-fatal error and it should otherwise continue (and maybe throw a warning if you want, such as the one stderr should return).

Currently when passing externally indexed files (like for example dgi or d2v files), FileInfo2 will not include any audio. I'd like for there to be an automatic check in the pah's directory for any externally demuxed audio.

My idea is as follows:

1. Check if audios is empty (ideally prior to trimming and whatnot)
2. If it is, check for a set list of extensions for the input file (I propose just dgi and d2v files for now due to easy repeatability, but this can be expanded if you so choose)
3. If there's a match, use a glob to get all the audio files that match the same name + a common set of audio extensions (to stop it from picking up other junk).¹
4. Check if there's a PCM file. If there is, set that as a_src. If not, use the first file found.²³
5. Process the files as normally

Why the current implementation doesn't work

Right now, users can set an a_src themselves. But that doesn't result in a usable audio node for previewing. So if for example you're processing an episode in a DVD that's not at the start, you'll get the episode 1 audio unless you load bas yourself and handle all the trimming. Handling this automatically is much easier on the user, and falls within the scope of vardautomation's implementations.

Caveats

This implementation would probably not work well if the user passed an indexer that automatically indexed using dgindexnv (like for example a hypothetical future rewrite of lvsfunc.misc.source), as it would instead try to use the file passed to that indexer to determine the audio situation. I don't know how to best handle that.

BestAudioSource is discontinued as stated there. Its replacement is BestSource.

Waiting for official dll and stable release.
DLL provided on doom9 are still testing ones.

https://discord.com/channels/@me/599711298275770398/972537849524154378

Some unknown error can occur when running mkvmerge that can't be caught in a try/except clause. The final output is still being muxed, but it seems to throw an error when trying to exit, taking the entire process down with it.

Removing check=True in tooling/base.py:44 as done here seems to resolve the error

-            subprocess.run(self.params, check=True, text=True, encoding='utf-8')
+            subprocess.run(self.params, text=True, encoding='utf-8')

This might be a temporary solution for the time being, but a more permanent solution should be found asap.