GithubHelp home page GithubHelp logo

Comments (2)

paurkedal avatar paurkedal commented on August 21, 2024

I investigated this a bit further, and the remaining connections handlers after wrk exists seems to be stuck in read. This is likely the issue described e.g. in Detection of Half-Open (Dropped) Connections, which explicitly mentions timeout as the solution for HTTP servers which support persistent connections. So, it's not a bug.

For a production-ready server we would need a timeout. I don't know Async well, but Lwt this can be easily done by joining the handle thread with an Lwt_unix.timeout, but this is not fully correct, since a big transfer could be cancelled even though it's still streaming. So, maybe the handler constructors should take a ~idle_timout or ~read_idle_timeout parameter? (Same semantics, different name suggestions.)

from httpaf.

seliopou avatar seliopou commented on August 21, 2024

Thanks for the report, Closing in favor of #86.

from httpaf.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.