int-72h / oftoast2 Goto Github PK
View Code? Open in Web Editor NEWThe New Generation of OFToast.
License: MIT License
The New Generation of OFToast.
License: MIT License
When the user does not have a open_fortress/
folder where OFToast expects it (ie. a new user or the install path does not find one), leaving the Advanced Menu crashes the application entirely. This is fixed when the folder is created upon reopening OFToast.
This was tested using Steam (native and flatpak) and without Steam installed. The terminal output bellows happens regardless of Steam installation.
open_fortress/
folder where Toast expects it to be (usually sourcemods/open_fortress/
).I should be able to return back to the main menu.
OFToast crashes.
With latest downloads from open fortress last year, it suffer a lot of crashes and corrupted files from servers errors when a update relased, i had to manually download a mirror loosing my save data and having to recreate all of my config again, So it would be preferable to make an option to make a copy of your saves or configs, (or skin customization) so you can drag and drop on a new build.
The option could be in advanced options or it could be a pop up windows if the downloads fails, and its created in a easy to reach folder like the documents or downloads folder with the files copied to drag and drop in a new downloaded build.
When the user does not have Open Fortress installed and they're opening OFToast, the update and verify buttons are disabled, preventing any attempt in installing the game through the launcher. This seems to happen irregardless of if Steam is installed (flatpak or native) or not.
This can be fixed by re-opening OFToast, as it'll create a sourcemods/open_fortress/
folder where it's expected.
open_fortress/
folder where Toast expects it to be (usually sourcemods/open_fortress/
).I should be able to initiate the installation procedure using the update button.
It is impossible to verify or update on first boot.
Add a button to Launch the game if its installed.
this would improve the user experience and simplify the workflow needed for updating and launching the game while also potentially cutting out the need to restart steam on initial installs.
When the user selects a blog post from the far left or far right, it will subsequently shuffle the rest of the posts towards that general direction. This is contrasted to behaviour when selecting the centre post and going back to the original selection, which does not move anything on the horizontal axis.
The blog posts probably should not be moving around like this.
The whole stack of blog posts get pulled in the direction towards your selection.
Current behaviour navigates users to wherever OFToast is installed to. It might be beneficial to instead put them wherever the directory states to backtrack from that current position. If the install directory cannot be found, it should then resort to opening up where OFToast is, if applicable.
When changing settings in advanced options, relaucnhing toast will reset any modifications made.
Changes made in this menu persist across subsequent sessions.
Changes revert back to their original state, meaning all options changed are temporary and will only last until the user ends OFToast.
By and large, this is a nitpick, but figured I should note it down. The title text here is not centred in the middle.
It should probably be centred.
It's slightly adjusted to the left.
In most appearances of a button, there is no visual feedback when a cursor is hovering over it. The install directory button seems to be the only place where this behaviour is seen.
The colours of the button would change, prompting feedback to the user that this item is awaiting for a response.
Nothing happens, which could lead to OFToast feeling static and unresponsive.
When OFToast has a decimal in the threads amount setting, you can get stuck infinitely waiting for an update or verification.
OFToast should not allow me to have decimal numbers of threads to begin with.
It lets me proceed up to the verification and update process, which causes a softlock.
In places such as the blog post, the dark purple frame can be hard to make out and blend too easily into the background. At a quick glance, it can seem as though the placeholder thumbnails are floating images without clearly defined tabs separating each one individually. Even with fairly good eyesight, this can prove to be a problem. The frame itself should be updated to use a darker purple or the background should be adjusted to use a lighter colour instead.
OK I have to get everything in before I can even remotely call it beta.
Compat Table of Ultimate Toasting | OF installed | OF not installed | Steam not installed |
---|---|---|---|
Windows | Generally | ? | don't think so |
Linux | Yes | ? | ? |
Linux (flatpak) | ? | ? | ? |
Linux (non-standard, nixos etc) | ? | ? | ? |
The sounds that play at the beginning/end of the verify/update processes are very loud even though my system volume is set to 39 out of 100. Adding a volume slider that effects the notification & error handler would be nice as they tend to be way too loud.
If no revision information is available Toast simply downloads objects and saves them where they are suppose to go.
On installations with no revision information this will spend time downloading and writing files that are already on disk
NotQuiteApex also showed it - it doesn't correctly detect a lack of steam or OF possibly.
Needs fixing ASAP.
Options that are confined to a specific narrow range like number of threads should have a dropdown menu for what you can pick from. This would be helpful in resolving issues like #10 and #13 by preventing inputs that shouldn't be allowed and streamlining the acceptable range clearly. It also doesn't make sense for certain settings to be text fields.
Moving this from the Discord to here for proper documenting.
When using the input popup box when an incorrect number of threads is entered, its possible to lock yourself into the advanced settings menu without being able to exit.
When OFToast has letters or symbols in the threads amount setting, you can get stuck infinitely waiting for an update or verification. This is an issue similar to #10.
OFToast should not allow me to have letters or symbols as an acceptable input and should hand me an error prompt.
It lets me proceed up to the verification and update process, which causes a softlock.
Verification is for when the game IS installed, Check Existing is when the game ISN'T. However, after I installed the game "Check Existing" was an option. I clicked on it and it just says "Verifying". Clicking on the advanced options button and then out of it allows "Check Existing" to be clicked again
I waited for it finish verifying and nothing special seemed to happen.
Being able to see the progress of the verification / updating process from anywhere, including the advanced options menu, would be convenient as it'd appear everywhere in the application. It may also be helpful if #24 gets added and volume sliders get put into launcher settings, thus being able to quickly change audio levels before music / sounds play or stop.
In blog posts, posts with links in them don't open in an external browser. Hovering over them will give visual cursor feedback that the item is clickable, however.
The link should open up in an external browser. In canonical order from those listed above, it should open https://openfortress.fun/blog and https://github.com/brysondev/OF-Install-Script/blob/main/README.md
Clicking on the links does nothing.
Next to a few of the settings, there should be an included info box tooltip you can hover over to deliver a quick explanation of proper usage and what the setting will adjust. This would improve user facing behaviour by lessening confusion over what is considered a proper input, such in the case of how many threads are valid. It also allows users to make informed decisions on what they should be touching based on its properties.
In all input fields, there is no blinking cursor to help indicate where the user is currently selected and ready to type in. This feedback would otherwise inform whether the program is anticipating a response.
There should be a blinking line on the currently selected portion to let the user know where they are about to type in.
There isn't one, which keeps the user guessing if they're able to type and precisely where they are.
Issue:
When Toast is redownloading files in the verification process, it does not make any progress.
Here is the debug log and a picture of what it looks like:
Debug Log.txt
My specs:
System info:
Microsoft Windows 10 Home 21H2 (OS Build 19044.2486)
CPU: AMD Ryzen 7 2700X Eight-Core Processor 3.70 GHz
RAM: 16.0 GB DDR4 RAM (two sticks)
GPU: NVIDIA GeForce GTX 1070
3 Storage Drives: C (500GB SSD), D (1TB HD), and E (2TB HD)
Hover text can be hard to read under certain circumstances because the background and text colour are too similar to each other, especially if there is text underneath it already.
The text colour would be something darker like purple to improve contrast.
It inherits the default text colour used everywhere else in toast leading to an unideal experience, as mentioned previously.
When inserting invalid revision numbers, the "Quit" and "Use Input" buttons on the error prompt will crash OFToast.
OFToast would be able to continue functionality and let me self-correct to a valid revision number.
OFToast fails to return back to the original input and crashes.
This only works for negative integers and numbers above the current version.
The prompt does not appear when decimal numbers (ex. 11.2) or zero are inputs.
Inputs in this screen are not saved once crashing.
the issue:
do_thing
do_thing
gddl_download_file(large_file)
do_thing
will hang on that download call (seen as how long the download takes.)
ideal solution:
do_thing
do_thing
gddl_download_file(large_file)
yield(self, download_file_finish)
do_thing
this isn't an issue when the downloads are threaded though.
When OFToast gets an error prompt for invalid thread values, typing a second invalid thread for "Use Input" prevents Advanced from being interacted with.
OFToast should reject the second invalid input.
It accepts it and locks out the ability to press Advanced.
yeah
When launching the latest build of oftoast2 on Windows 10 22H2 x64 with a shell (with or without --verbose argument), it doesn't check for Team Fortress 2 and Source SDK. This has worked in alpha5.
Alpha 5:
alpha5log.txt
Latest build:
latest log.txt
It's in the name. No toast spinning, no toaster dinging (although there is a quieter sound) just a perpetually empty verifying progress bar. This is not the case with the first pre alpha at all, only the second. Here's footage.
When launching oftoast2 from a console, it always reports that tf2 and Source SDK are installed.
Using Windows 10 22H2 x64
TF2_removed.log
TF2+SDK_removed.log
PS: my internet cut out here, so it couldn't connect to the mirror
nothing_removed.log
SDK_removed.log
When OFToast succesfully finds /sourcemods/open_fortress/
but has not yet installed the game, starting the update process will prompt a "failed to unzip" error. Clicking "continue" or "retry" continues the updating process, though may not actually be installing anything.
This was tested using Steam (native and flatpak).
open_fortress/
folder where Toast expects it to be (usually sourcemods/open_fortress/
).The installation process should continue as expected without any errors. After some time, the game should be installed.
We are informed that we have failed to unzip and it doesn't appear that we're actually installing anything.
When OFToast succesfully finds /sourcemods/open_fortress/
but has not yet installed the game, the verifying procedure will seemingly last forever.
This was tested using Steam (native).
open_fortress/
folder where Toast expects it to be (usually sourcemods/open_fortress/
).The process probably shouldn't proceed since we do not have the game installed yet. Instead, the button should be disabled.
We can verify, and it seems to last a very, very long time.
When inserting invalid thread numbers, the "Quit" and "Use Input" buttons on the error prompt will crash OFToast. This is a similar issue to #7.
OFToast would be able to continue functionality and let me self-correct to a valid number of threads.
OFToast fails to return back to the original input and crashes.
OFToast always shows Update
and Verify
buttons as well as the installed version even if no install was found.
If you're on the latest revision, you can force OFToast to update by reopening the main menu through the Advanced menu. It's implied this behaviour shouldn't be happening because we're only fetching updates if we have a revision number that mismatches the latest.
The update button should continue to be greyed out because we still have a revision that matches the latest number.
I can continue with an update process, though it's really just verifying the files are there.
If you click on the advanced button twice and do not have Open Fortress installed, Toast 2 crashes.
System info:
Microsoft Windows 11 Home 21H2 (OS Build 22000.1696)
CPU: 12th Gen Intel(R) Core(TM) i7-12700H 2.70 GHz
RAM: 16.0 GB
GPU: NVIDIA GeForce GTX 3070 Laptop GPU
Storage Drive: C: 512GB SSD
When an update / verification has finished, the happy toast mascot in the top-left will spin, but not in the centre. It slightly orbits around farther than it should.
Only the toast inside the circle would spin in place.
The whole image spins around including the toast and circle, meaning the centre point of the image isn't rotated on its centre.
Even though Steam was not installed on my computer, Toast 2 claims it is.
System info:
Microsoft Windows 11 Home 21H2 (OS Build 22000.1696)
CPU: 12th Gen Intel(R) Core(TM) i7-12700H 2.70 GHz
RAM: 16.0 GB
GPU: NVIDIA GeForce GTX 3070 Laptop GPU
Storage Drive: C: 512GB SSD
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.