GithubHelp home page GithubHelp logo

oftoast2's People

Contributors

int-72h avatar jan200101 avatar sloofy avatar tcharchar avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

Forkers

sloofy jan200101

oftoast2's Issues

Segmentation fault when leaving Advanced Menu if no Open Fortress folder exists

Summary

When the user does not have a open_fortress/ folder where OFToast expects it (ie. a new user or the install path does not find one), leaving the Advanced Menu crashes the application entirely. This is fixed when the folder is created upon reopening OFToast.

This was tested using Steam (native and flatpak) and without Steam installed. The terminal output bellows happens regardless of Steam installation.

image

Step to reproduce

  1. Do not have an open_fortress/ folder where Toast expects it to be (usually sourcemods/open_fortress/).
  2. Launch OFToast.
  3. Open the Advanced Menu screen using the "Advanced" button.
  4. Try to leave the menu by pressing the "Advanced" button again.

What I expected

I should be able to return back to the main menu.

What actually happened

OFToast crashes.

System Specifications

  • OFToast Version: v0.0.0-gitcommit
  • OS: Fedora Linux 37 (KDE Plasma) (64 bit)
  • CPU: AMD Ryzen 5 2600 Six-Core
  • GPU: AMD Radeon RX 580 Series (polaris10, LLVM 15.0.7, DRM 3.49, 6.1.14-200.fc37.x86_64)
  • Driver Version: 4.6 (Compatibility Profile) Mesa 22.3.6
  • OpenGL Version: 4.6
  • Screen resolution: 1920x1080

[Request] Add a option to make a copy of your saves from a failed/corrupted download or game

Summary:

With latest downloads from open fortress last year, it suffer a lot of crashes and corrupted files from servers errors when a update relased, i had to manually download a mirror loosing my save data and having to recreate all of my config again, So it would be preferable to make an option to make a copy of your saves or configs, (or skin customization) so you can drag and drop on a new build.

What I expected:

The option could be in advanced options or it could be a pop up windows if the downloads fails, and its created in a easy to reach folder like the documents or downloads folder with the files copied to drag and drop in a new downloaded build.

Unable to update or verify when no Open Fortress folder exists

Summary

When the user does not have Open Fortress installed and they're opening OFToast, the update and verify buttons are disabled, preventing any attempt in installing the game through the launcher. This seems to happen irregardless of if Steam is installed (flatpak or native) or not.

This can be fixed by re-opening OFToast, as it'll create a sourcemods/open_fortress/ folder where it's expected.

image

Step to reproduce

  1. Do not have an open_fortress/ folder where Toast expects it to be (usually sourcemods/open_fortress/).
  2. Launch OFToast.
  3. Observe that the update and verify buttons are uninteractable.

What I expected

I should be able to initiate the installation procedure using the update button.

What actually happened

It is impossible to verify or update on first boot.

System Specifications

  • OFToast Version: v0.0.0-gitcommit
  • OS: Fedora Linux 37 (KDE Plasma) (64 bit)
  • CPU: AMD Ryzen 5 2600 Six-Core
  • GPU: AMD Radeon RX 580 Series (polaris10, LLVM 15.0.7, DRM 3.49, 6.1.14-200.fc37.x86_64)
  • Driver Version: 4.6 (Compatibility Profile) Mesa 22.3.6
  • OpenGL Version: 4.6
  • Screen resolution: 1920x1080

[Request] Add support for Launching the game.

Summary

Add a button to Launch the game if its installed.

this would improve the user experience and simplify the workflow needed for updating and launching the game while also potentially cutting out the need to restart steam on initial installs.

Blog posts "pull" each other on either end when selected

Summary

When the user selects a blog post from the far left or far right, it will subsequently shuffle the rest of the posts towards that general direction. This is contrasted to behaviour when selecting the centre post and going back to the original selection, which does not move anything on the horizontal axis.

blog1.mp4

Step to reproduce

  1. Launch OFToast
  2. Select a blog post from either farthest side (first or third post from left-to-right order).
  3. Observe the tabs position change.

What I expected

The blog posts probably should not be moving around like this.

What actually happened

The whole stack of blog posts get pulled in the direction towards your selection.

Additional notes

  • Clicking the centre post only shuffles the post next to what was previously selected.
  • If this behaviour is done intentionally to show the user what they have selected, I think it's better to vertically raise the tab than to horizontally adjust it.

System Specifications

  • OFToast Version: v0.0.0-alpha2
  • OS: Fedora Linux 37 (KDE Plasma) (64 bit)
  • CPU: AMD Ryzen 5 2600 Six-Core
  • GPU: AMD Radeon RX 580 Series (polaris10, LLVM 15.0.7, DRM 3.49, 6.1.7-200.fc37.x86_64)
  • Driver Version: 4.6 (Compatibility Profile) Mesa 22.3.3
  • OpenGL Version: 4.6
  • Screen resolution: 1920x1080

[Request] Open file directory in currently assigned install path

Summary

Current behaviour navigates users to wherever OFToast is installed to. It might be beneficial to instead put them wherever the directory states to backtrack from that current position. If the install directory cannot be found, it should then resort to opening up where OFToast is, if applicable.

Advanced options get reset to default values on startup

Summary

When changing settings in advanced options, relaucnhing toast will reset any modifications made.

Step to reproduce

  1. Launch OFToast
  2. Go into Advanced
  3. Modify number of threads, install directory, or mirrors to anything else.
  4. Relaunch OFToast
  5. Observe the current values in Advanced

What I expected

Changes made in this menu persist across subsequent sessions.

What actually happened

Changes revert back to their original state, meaning all options changed are temporary and will only last until the user ends OFToast.

System Specifications

  • OFToast Version: v0.0.0-alpha4
  • OS: Fedora Linux 37 (KDE Plasma) (64 bit)
  • CPU: AMD Ryzen 5 2600 Six-Core
  • GPU: AMD Radeon RX 580 Series (polaris10, LLVM 15.0.7, DRM 3.49, 6.1.7-200.fc37.x86_64)
  • Driver Version: 4.6 (Compatibility Profile) Mesa 22.3.3
  • OpenGL Version: 4.6
  • Screen resolution: 1920x1080

The "Advanced Options" title is not centred

Summary

By and large, this is a nitpick, but figured I should note it down. The title text here is not centred in the middle.

Screenshot_20230128_112147

Step to reproduce

  1. Launch OFToast
  2. Go into Advanced
  3. Observe title

What I expected

It should probably be centred.

What actually happened

It's slightly adjusted to the left.

Additional notes

  • It's probably a carryover from the "Latest from the blog" text as they're in similar starting positions, though this is just a guess.

System Specifications

  • OFToast Version: v0.0.0-alpha2
  • OS: Fedora Linux 37 (KDE Plasma) (64 bit)
  • CPU: AMD Ryzen 5 2600 Six-Core
  • GPU: AMD Radeon RX 580 Series (polaris10, LLVM 15.0.7, DRM 3.49, 6.1.7-200.fc37.x86_64)
  • Driver Version: 4.6 (Compatibility Profile) Mesa 22.3.3
  • OpenGL Version: 4.6
  • Screen resolution: 1920x1080

Most buttons do not change colour while hovering over them

Summary

In most appearances of a button, there is no visual feedback when a cursor is hovering over it. The install directory button seems to be the only place where this behaviour is seen.

Step to reproduce

  1. Launch OFToast
  2. Find any clickable button and place your cursor over it (don't click it).

What I expected

The colours of the button would change, prompting feedback to the user that this item is awaiting for a response.

What actually happened

Nothing happens, which could lead to OFToast feeling static and unresponsive.

System Specifications

  • OFToast Version: v0.0.0-alpha4
  • OS: Fedora Linux 37 (KDE Plasma) (64 bit)
  • CPU: AMD Ryzen 5 2600 Six-Core
  • GPU: AMD Radeon RX 580 Series (polaris10, LLVM 15.0.7, DRM 3.49, 6.1.7-200.fc37.x86_64)
  • Driver Version: 4.6 (Compatibility Profile) Mesa 22.3.3
  • OpenGL Version: 4.6
  • Screen resolution: 1920x1080

Decimal thread amounts cause verification and updates to infinitely load

Summary

When OFToast has a decimal in the threads amount setting, you can get stuck infinitely waiting for an update or verification.

Screenshot_20230127_203955
Screenshot_20230127_204337

Step to reproduce

  1. Launch OFToast
  2. Navigate to Advanced.
  3. Change the number of threads to a decimal within the valid range of 1-4.
  4. Click Advanced again to close the menu
  5. Click Verify or Update

What I expected

OFToast should not allow me to have decimal numbers of threads to begin with.

What actually happened

It lets me proceed up to the verification and update process, which causes a softlock.

System Specifications

  • OFToast Version: v0.0.0-alpha2
  • OS: Fedora Linux 37 (KDE Plasma) (64 bit)
  • CPU: AMD Ryzen 5 2600 Six-Core
  • GPU: AMD Radeon RX 580 Series (polaris10, LLVM 15.0.7, DRM 3.49, 6.1.7-200.fc37.x86_64)
  • Driver Version: 4.6 (Compatibility Profile) Mesa 22.3.3
  • OpenGL Version: 4.6
  • Screen resolution: 1920x1080

[Request] Increase visual contrast in blog post frame

Summary

In places such as the blog post, the dark purple frame can be hard to make out and blend too easily into the background. At a quick glance, it can seem as though the placeholder thumbnails are floating images without clearly defined tabs separating each one individually. Even with fairly good eyesight, this can prove to be a problem. The frame itself should be updated to use a darker purple or the background should be adjusted to use a lighter colour instead.

Current behaviour:
Screenshot_20230128_092526

Proposed behaviour (lighter background, same frame colour):
proposed1

Proposed behaviour (same background, darker frame colour):
proposed2

0.0.1 Beta Feature List

OK I have to get everything in before I can even remotely call it beta.

  • Music player functionality
  • Harden things (do sig verification, etc)
  • Backend endpoints implemented in pytoast and on toastware.org as an example
  • Launching functionality
  • General Polish (no outstanding major/medium bugs...)
  • About page
  • Able to install on all reasonable systems, and handle unreasonable ones
Compat Table of Ultimate Toasting OF installed OF not installed Steam not installed
Windows Generally ? don't think so
Linux Yes ? ?
Linux (flatpak) ? ? ?
Linux (non-standard, nixos etc) ? ? ?

[Request] Please add a volume slider.

The sounds that play at the beginning/end of the verify/update processes are very loud even though my system volume is set to 39 out of 100. Adding a volume slider that effects the notification & error handler would be nice as they tend to be way too loud.

[Request] check if file is already present on install

Summary

If no revision information is available Toast simply downloads objects and saves them where they are suppose to go.

On installations with no revision information this will spend time downloading and writing files that are already on disk

[Request] Dropdown menus for advanced options

Summary

Options that are confined to a specific narrow range like number of threads should have a dropdown menu for what you can pick from. This would be helpful in resolving issues like #10 and #13 by preventing inputs that shouldn't be allowed and streamlining the acceptable range clearly. It also doesn't make sense for certain settings to be text fields.

Current behaviour:
Screenshot_20230128_085153

Proposed behaviour:
Screenshot_20230128_085153

OFToast reporting the incorrect latest revision

When using the latest build of OFToast on Windows 10 22H2 x64, it reports that revision 13 is the latest. The alpha5 build reports that revision 14 is the latest.
Latest build:
image
Alpha 5:
image

Advanced settings softlock when using input popup

Moving this from the Discord to here for proper documenting.

When using the input popup box when an incorrect number of threads is entered, its possible to lock yourself into the advanced settings menu without being able to exit.

Steps to reproduce

  1. open toast
  2. click advanced
  3. click in the thread count box, type some number greater than 4
  4. error box pops up. type some number between 1 and 4 in the input
  5. press input, box wont disappear
  6. press input again, window disappears but you cant exit advanced and the thread count box stays the same (same as in step 3)

System Specifications

  • OFToast Version: v0.0.0-alpha2
  • OS: Windows 11 (64 bit)
  • CPU: AMD Ryzen 5 3800x
  • GPU: Nvidia RTX 3070

Non-numerical thread amounts are allowed, causing update and verification softlocks.

Summary

When OFToast has letters or symbols in the threads amount setting, you can get stuck infinitely waiting for an update or verification. This is an issue similar to #10.

Screenshot_20230128_090847
Screenshot_20230127_204337

Step to reproduce

  1. Launch OFToast
  2. Navigate to Advanced.
  3. Change the number of threads to an alphanumeric string, containing Latin letters or symbols.
  4. Click Advanced again to close the menu
  5. Click Verify or Update

What I expected

OFToast should not allow me to have letters or symbols as an acceptable input and should hand me an error prompt.

What actually happened

It lets me proceed up to the verification and update process, which causes a softlock.

Additional notes

  • Non-English inputs do not get copied over into this field already and won't cause issues (ex. ์šฐ์œ 2 will be accepted as just 2).
  • You can have a mix of symbols / letters and numbers, but the inclusion of the latter will notify OFToast that this is an invalid number of threads (ex. ABC is acceptable but ABC23 is invalid).

System Specifications

  • OFToast Version: v0.0.0-alpha2
  • OS: Fedora Linux 37 (KDE Plasma) (64 bit)
  • CPU: AMD Ryzen 5 2600 Six-Core
  • GPU: AMD Radeon RX 580 Series (polaris10, LLVM 15.0.7, DRM 3.49, 6.1.7-200.fc37.x86_64)
  • Driver Version: 4.6 (Compatibility Profile) Mesa 22.3.3
  • OpenGL Version: 4.6
  • Screen resolution: 1920x1080

Verification/Check Existing kinda screwed up

Verification is for when the game IS installed, Check Existing is when the game ISN'T. However, after I installed the game "Check Existing" was an option. I clicked on it and it just says "Verifying". Clicking on the advanced options button and then out of it allows "Check Existing" to be clicked again
I waited for it finish verifying and nothing special seemed to happen.

[Request] Allow verifying / update loading bar to persist in advanced options

Summary

Being able to see the progress of the verification / updating process from anywhere, including the advanced options menu, would be convenient as it'd appear everywhere in the application. It may also be helpful if #24 gets added and volume sliders get put into launcher settings, thus being able to quickly change audio levels before music / sounds play or stop.

Current behaviour:
Screenshot_20230128_201955

Proposed behaviour:
Screenshot_20230128_201852

Links do not open in browser

Summary

In blog posts, posts with links in them don't open in an external browser. Hovering over them will give visual cursor feedback that the item is clickable, however.

Screenshot_20230128_134641

Step to reproduce

  1. Launch OFToast
  2. Find a blog post that has a link in it (Currently, "Go, Move It!" has two as "download page" (first sentence) and "here" (last sentence)).
  3. Click on the text.

What I expected

The link should open up in an external browser. In canonical order from those listed above, it should open https://openfortress.fun/blog and https://github.com/brysondev/OF-Install-Script/blob/main/README.md

What actually happened

Clicking on the links does nothing.

System Specifications

  • OFToast Version: v0.0.0-alpha3
  • OS: Fedora Linux 37 (KDE Plasma) (64 bit)
  • CPU: AMD Ryzen 5 2600 Six-Core
  • GPU: AMD Radeon RX 580 Series (polaris10, LLVM 15.0.7, DRM 3.49, 6.1.7-200.fc37.x86_64)
  • Driver Version: 4.6 (Compatibility Profile) Mesa 22.3.3
  • OpenGL Version: 4.6
  • Screen resolution: 1920x1080

[Request] Implement info boxes explaining proper setting usage

Summary

Next to a few of the settings, there should be an included info box tooltip you can hover over to deliver a quick explanation of proper usage and what the setting will adjust. This would improve user facing behaviour by lessening confusion over what is considered a proper input, such in the case of how many threads are valid. It also allows users to make informed decisions on what they should be touching based on its properties.

Current behaviour:
Screenshot_20230127_204629

Proposed behaviour:
Screenshot_20230127_204629

Text fields lack a blinking cursor

Summary

In all input fields, there is no blinking cursor to help indicate where the user is currently selected and ready to type in. This feedback would otherwise inform whether the program is anticipating a response.

Step to reproduce

  1. Launch OFToast
  2. Go into Advanced
  3. Click on either input fields (currently either number of threads or mirrors).

What I expected

There should be a blinking line on the currently selected portion to let the user know where they are about to type in.

What actually happened

There isn't one, which keeps the user guessing if they're able to type and precisely where they are.

System Specifications

  • OFToast Version: v0.0.0-alpha3
  • OS: Fedora Linux 37 (KDE Plasma) (64 bit)
  • CPU: AMD Ryzen 5 2600 Six-Core
  • GPU: AMD Radeon RX 580 Series (polaris10, LLVM 15.0.7, DRM 3.49, 6.1.7-200.fc37.x86_64)
  • Driver Version: 4.6 (Compatibility Profile) Mesa 22.3.3
  • OpenGL Version: 4.6
  • Screen resolution: 1920x1080

Toast does not make any progress during the re-downloading files section of verification process.

Issue:
When Toast is redownloading files in the verification process, it does not make any progress.

Here is the debug log and a picture of what it looks like:
Debug Log.txt
image_2023-03-16_141750628

My specs:
System info:
Microsoft Windows 10 Home 21H2 (OS Build 19044.2486)
CPU: AMD Ryzen 7 2700X Eight-Core Processor 3.70 GHz
RAM: 16.0 GB DDR4 RAM (two sticks)
GPU: NVIDIA GeForce GTX 1070
3 Storage Drives: C (500GB SSD), D (1TB HD), and E (2TB HD)

Hover over text in file explorer has readibility issues

Summary

Hover text can be hard to read under certain circumstances because the background and text colour are too similar to each other, especially if there is text underneath it already.

Screenshot_20230129_093836

Step to reproduce

  1. Launch OFToast
  2. Go into Advanced
  3. Open the file explorer by clicking on the install directory
  4. Hover over any symbol to reveal hover text (ex. upward arrow to show "Go to parent folder.")

What I expected

The text colour would be something darker like purple to improve contrast.

What actually happened

It inherits the default text colour used everywhere else in toast leading to an unideal experience, as mentioned previously.

System Specifications

  • OFToast Version: v0.0.0-alpha4
  • OS: Fedora Linux 37 (KDE Plasma) (64 bit)
  • CPU: AMD Ryzen 5 2600 Six-Core
  • GPU: AMD Radeon RX 580 Series (polaris10, LLVM 15.0.7, DRM 3.49, 6.1.7-200.fc37.x86_64)
  • Driver Version: 4.6 (Compatibility Profile) Mesa 22.3.3
  • OpenGL Version: 4.6
  • Screen resolution: 1920x1080

Error prompt buttons "Quit" and "Use Input" crash

Summary

When inserting invalid revision numbers, the "Quit" and "Use Input" buttons on the error prompt will crash OFToast.

image

Step to reproduce

  1. Launch OFToast
  2. Navigate to Advanced.
  3. Change the revision to update to a negative integer or version that's above the current one (ex. We are on revision 12, so 13 will crash).
  4. Click Advanced again for the error prompt to appear.
  5. Choose either Quit or Use Input.
  6. Crash

What I expected

OFToast would be able to continue functionality and let me self-correct to a valid revision number.

What actually happened

OFToast fails to return back to the original input and crashes.

Additional information

This only works for negative integers and numbers above the current version.

The prompt does not appear when decimal numbers (ex. 11.2) or zero are inputs.

Inputs in this screen are not saved once crashing.

System Specifications

  • OFToast Version: v0.0.0-alpha1
  • OS: Fedora Linux 37 (KDE Plasma) (64 bit)
  • CPU: AMD Ryzen 5 2600 Six-Core
  • GPU: AMD Radeon RX 580 Series (polaris10, LLVM 15.0.7, DRM 3.49, 6.1.7-200.fc37.x86_64)
  • Driver Version: 4.6 (Compatibility Profile) Mesa 22.3.3
  • OpenGL Version: 4.6
  • Screen resolution: 1920x1080

[feature] Make single-threaded downloads less blocking

the issue:

do_thing
do_thing
gddl_download_file(large_file)
do_thing

will hang on that download call (seen as how long the download takes.)
ideal solution:

do_thing
do_thing
gddl_download_file(large_file)
yield(self, download_file_finish)
do_thing

this isn't an issue when the downloads are threaded though.

Invalid thread values cause softlock on "Use Input"

Summary

When OFToast gets an error prompt for invalid thread values, typing a second invalid thread for "Use Input" prevents Advanced from being interacted with.

Screenshot_20230128_132747
Screenshot_20230128_132351

Step to reproduce

  1. Launch OFToast
  2. Navigate to Advanced.
  3. Change the number of threads to an invalid amount (decimal, alphanumeric, symbols, etc).
  4. In the error prompt, type in the text field another invalid amount.
  5. Click "Use Input"

What I expected

OFToast should reject the second invalid input.

What actually happened

It accepts it and locks out the ability to press Advanced.

System Specifications

  • OFToast Version: v0.0.0-alpha3
  • OS: Fedora Linux 37 (KDE Plasma) (64 bit)
  • CPU: AMD Ryzen 5 2600 Six-Core
  • GPU: AMD Radeon RX 580 Series (polaris10, LLVM 15.0.7, DRM 3.49, 6.1.7-200.fc37.x86_64)
  • Driver Version: 4.6 (Compatibility Profile) Mesa 22.3.3
  • OpenGL Version: 4.6
  • Screen resolution: 1920x1080

Updating and Verifying currently non-functional on my end.

It's in the name. No toast spinning, no toaster dinging (although there is a quieter sound) just a perpetually empty verifying progress bar. This is not the case with the first pre alpha at all, only the second. Here's footage.

  1. OFTOAST II alpha 1
    https://user-images.githubusercontent.com/85916614/215282965-030a6d3b-caf2-475c-9026-d328c512d28e.mp4

  2. OFTOAST II alpha 2
    https://user-images.githubusercontent.com/85916614/215282972-5c3e1257-b610-4a39-8c48-0b5d1f1448fe.mp4

"Failed to unzip" if game has not been installed

Summary

When OFToast succesfully finds /sourcemods/open_fortress/ but has not yet installed the game, starting the update process will prompt a "failed to unzip" error. Clicking "continue" or "retry" continues the updating process, though may not actually be installing anything.

This was tested using Steam (native and flatpak).

image
image

Step to reproduce

  1. Have an open_fortress/ folder where Toast expects it to be (usually sourcemods/open_fortress/).
  2. Do not have the game's contents installed, however
  3. Launch OFToast.
  4. Click "Update"

What I expected

The installation process should continue as expected without any errors. After some time, the game should be installed.

What actually happened

We are informed that we have failed to unzip and it doesn't appear that we're actually installing anything.

System Specifications

  • OFToast Version: v0.0.0-gitcommit
  • OS: Fedora Linux 37 (KDE Plasma) (64 bit)
  • CPU: AMD Ryzen 5 2600 Six-Core
  • GPU: AMD Radeon RX 580 Series (polaris10, LLVM 15.0.7, DRM 3.49, 6.1.14-200.fc37.x86_64)
  • Driver Version: 4.6 (Compatibility Profile) Mesa 22.3.6
  • OpenGL Version: 4.6
  • Screen resolution: 1920x1080

Seemingly indefinite verify process when game hasn't been installed

Summary

When OFToast succesfully finds /sourcemods/open_fortress/ but has not yet installed the game, the verifying procedure will seemingly last forever.

This was tested using Steam (native).

image
image

Step to reproduce

  1. Have an open_fortress/ folder where Toast expects it to be (usually sourcemods/open_fortress/).
  2. Do not have the game's contents installed, however
  3. Launch OFToast.
  4. Click "Verify"

What I expected

The process probably shouldn't proceed since we do not have the game installed yet. Instead, the button should be disabled.

What actually happened

We can verify, and it seems to last a very, very long time.

System Specifications

  • OFToast Version: v0.0.0-gitcommit
  • OS: Fedora Linux 37 (KDE Plasma) (64 bit)
  • CPU: AMD Ryzen 5 2600 Six-Core
  • GPU: AMD Radeon RX 580 Series (polaris10, LLVM 15.0.7, DRM 3.49, 6.1.14-200.fc37.x86_64)
  • Driver Version: 4.6 (Compatibility Profile) Mesa 22.3.6
  • OpenGL Version: 4.6
  • Screen resolution: 1920x1080

Invalid threads error prompt buttons "Quit" and "Use Input" crash

Summary

When inserting invalid thread numbers, the "Quit" and "Use Input" buttons on the error prompt will crash OFToast. This is a similar issue to #7.

Screenshot_20230127_203716

Step to reproduce

  1. Launch OFToast
  2. Navigate to Advanced.
  3. Change the number of threads to an invalid amount (negative or higher than 4).
  4. Click Advanced again for the error prompt to appear.
  5. Choose either Quit or Use Input.
  6. Crash

What I expected

OFToast would be able to continue functionality and let me self-correct to a valid number of threads.

What actually happened

OFToast fails to return back to the original input and crashes.

System Specifications

  • OFToast Version: v0.0.0-alpha2
  • OS: Fedora Linux 37 (KDE Plasma) (64 bit)
  • CPU: AMD Ryzen 5 2600 Six-Core
  • GPU: AMD Radeon RX 580 Series (polaris10, LLVM 15.0.7, DRM 3.49, 6.1.7-200.fc37.x86_64)
  • Driver Version: 4.6 (Compatibility Profile) Mesa 22.3.3
  • OpenGL Version: 4.6
  • Screen resolution: 1920x1080

Able to force update on latest revision by accessing Advanced menu

Summary

If you're on the latest revision, you can force OFToast to update by reopening the main menu through the Advanced menu. It's implied this behaviour shouldn't be happening because we're only fetching updates if we have a revision number that mismatches the latest.

Step to reproduce

  1. Launch OFToast
  2. Be on the same revision number as the latest (ex. if current is 12, then we are on 12).
  3. Observe that on the latest revision, you cannot update
  4. Go into Advanced
  5. Return back to the main menu

What I expected

The update button should continue to be greyed out because we still have a revision that matches the latest number.

What actually happened

I can continue with an update process, though it's really just verifying the files are there.

System Specifications

  • OFToast Version: v0.0.0-alpha4
  • OS: Fedora Linux 37 (KDE Plasma) (64 bit)
  • CPU: AMD Ryzen 5 2600 Six-Core
  • GPU: AMD Radeon RX 580 Series (polaris10, LLVM 15.0.7, DRM 3.49, 6.1.7-200.fc37.x86_64)
  • Driver Version: 4.6 (Compatibility Profile) Mesa 22.3.3
  • OpenGL Version: 4.6
  • Screen resolution: 1920x1080

The happy toast icon does not spin in the centre

Summary

When an update / verification has finished, the happy toast mascot in the top-left will spin, but not in the centre. It slightly orbits around farther than it should.

The mascot in question:
Screenshot_20230127_194929

Step to reproduce

  1. Launch OFToast
  2. Complete a verification / update
  3. Watch the top-left icon spin around

What I expected

Only the toast inside the circle would spin in place.

What actually happened

The whole image spins around including the toast and circle, meaning the centre point of the image isn't rotated on its centre.

System Specifications

  • OFToast Version: v0.0.0-alpha1
  • OS: Fedora Linux 37 (KDE Plasma) (64 bit)
  • CPU: AMD Ryzen 5 2600 Six-Core
  • GPU: AMD Radeon RX 580 Series (polaris10, LLVM 15.0.7, DRM 3.49, 6.1.7-200.fc37.x86_64)
  • Driver Version: 4.6 (Compatibility Profile) Mesa 22.3.3
  • OpenGL Version: 4.6
  • Screen resolution: 1920x1080

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.