jakobbossek / grapherator Goto Github PK

Rename intercluster to intercenter. For intercluster, we select each k random nodes from each cluster and apply the generator to these.

Many new features are not covered yet.

Only relevant if by.centers is TRUE. Applies edge generator only to the subset of clusters

Bascially this one should return a string concatenation of node, edge and weiht types.

We pass addEdges{...} or addNodes{...} functions to addEdges and addNodes respectively. However, we pass a character to specify the method in addWeights.

The following vignettes are needed:

• Graph generation
• Writing generators (e.g., addEdgesThreshold)

Regarding the review openjournals/joss-reviews#528 I have the following comments:

• In the vignette "Graph generation with grapherator", there are some references missing. In particular, the MOST paper, which is linked to, but not mentioned in the list of references.

• To improve documentation, I suggest adding links from the addEdges, addNodes, and addWeights to their respective set of generator functions. A single link in the parameter description should work.

• The tag @title shows in the name of edgeGenerators (see here). Removing the @title tag should be OK.

Other than that, everything looks OK to me. I was able to install the package from github and CRAN and compile/test it myself without any problem.

Graphs with only one weight are possible as well. Come up with a new S3 class name

Implement rounding of weights to next integer in addWeights.

xhi, nu and M should be parameters.

Symmetry property should be ensured by addWeights, not by each weight generator itself.

Implement at least the following getters:

• getNumberOfNodes()
• getNumberOfEdges()
• getNumberOfClusters()
• getNodeDegrees()
• getAdjacencyMatrix()
• getWeightMatrix(obj)

Should call addEdgesComplete if no edge generator has been called by the user.

Code is already there. Rafactor, add docs and export.

Most flexible and consistent with node/weight generators.

At the moment we have 1e6 as a magic number. Should be infinity or max double value.

Since addCoordinates was renamed to addNodes we need to use the word nodes instead of coordinates in the docs.