jasenhuang / nsobjectsafe Goto Github PK

View Code? Open in Web Editor NEW

591.0 19.0 114.0 84 KB

Swizzle commonly used function of Foundation container to prevent nil crash

Objective-C 100.00%

swizzle crash ios unrecognized-selecto class-cluster nsattributestring

nsobjectsafe's People

Stargazers

Watchers

Forkers

security111588 hypoyao xztl ganvinalix nullxw sukeyang itlingmao shicuf tierz dreambuddy fengong derclown managerorganization woshiqyb mafaming ivoidcat seaburg zikex wangxumin yrocky hellchine readopensourcecode blucehn magiciandl richyleo simbahj xueselangman91 coderxl leo-lv duhongxing louis0391 jmaxwells niuxianbin xxhank icoderro nsblacker igithubmaster luozhonghua1991 lukelark zhugongyuan humein xxdzyyh ilovequake3 bone111 hero2000 wm219 tianmingfu ioscommonlibrary thorfei czboosj chenhuchang lleihai123 ovveii xujim cxtretar somiw summerhearts zhangguozhong angel-cry yulekwok heliumin sh0rt2020 keymonwong zbwbb muxuechen walkerzhu limcrazy andy-jiangbin yinjianhua472392556 fantasticskybaby softboys hughkli olafli zzminwuhan lostpengk dodubaby lgq2015 changyiyinet nihaolifei999 bulaidebao li010 sophiasong youngshingjun ryanqinqhw sanwcoder looseyi cuiluaini y1503 skateliu csfuwwc welltang xnxy fendouzhe kingofqueen fengyang0329 klt595571349 captain9911 yongbaowang shshjing jungleninja

nsobjectsafe's Issues

crash at this place,NSMutableArray->hookObjectAtIndex

objectForKey 没有必要防御

系统 framework 其实在 objectForKey 传 nil 的时候不会 crash，我这边检测到有些时候弹出键盘系统线程自己就会传 nil 进来

跟ReactiveCocoa不兼容

用你这个,ReactiveCocoa就不兼容了,报错

(RACSignal *)rac_valuesForKeyPath:(NSString *)keyPath observer:(__weak NSObject *)observer;
(RACSignal *)rac_valuesAndChangesForKeyPath:(NSString *)keyPath options:(NSKeyValueObservingOptions)options observer:(__weak NSObject *)observer;
不能使用__weak

编译错误

Unknown class name 'NSAttributedStringKey'; did you mean 'NSAttributedString'?

NSString && NSMutableString not hook ''stringByAppendingString'' Method

NSString && NSMutableString not hook ''stringByAppendingString:'' In load Method, 造成崩溃

NSObjectSafe crash for iOS8

for iOS9
[[NSArray alloc] init] --> __NSArray0
for iOS8 and lower
[[NSArray alloc] init] --> __NArrayI

so for iOS8 and lower, we don't need to swizzle for two times:
'''
/* 数组有内容obj类型才是__NSArrayI /
NSArray obj = [[NSArray alloc] initWithObjects:@0, nil];
[obj swizzleInstanceMethod:@selector(objectAtIndex:) withMethod:@selector(hookObjectAtIndex:)];

/* 没内容类型是__NSArray0 */
obj = [[NSArray alloc] init];
[obj swizzleInstanceMethod:@selector(objectAtIndex:) withMethod:@selector(hookObjectAtIndex0:)];
'''

怎么用啊？

有没有具体的使用方法啊？？

iOS11 使用导航的搜索控制器属性，崩溃

这是一个能稳定复现的崩溃
从页面A 模态弹出页面B（页面B中使用self.navigationItem.searchController = self.searchController 添加搜索栏）
此时使用该类库会稳定崩溃，打开僵尸对象，控制台打印*** -[UINavigationBar release]: message sent to deallocated instance 0x7fa305303970
若移除该类库则正常
若无法复现我可以上传demo

为什么不使用ARC？

为什么不使用ARC？是否可以将release去掉变成ARC？

编译时候提示RAC里的文件报错

Cannot create __weak reference in file using manual reference counting

能否出一版，获取具体是哪个控制器哪个方法有问题

获取具体是哪个控制器哪个方法有问题

部分可变类型的类别容易导致数据被截断

例如NSMutableData类别中[hookReplaceBytesInRange:withBytes:]，如果有需要替换长度超过原数据长度的情况下，超过长度的数据就被截断，这样的做法容易产生意想不到的后果，希望能再被优化，不是简单地截断后面的数据，其实不截断处理也不会崩溃，不是吗？请尽快想办法优化，已经有开发者遇到此问题了 @jasenhuang @hypoyao @tedzhou

I've had a crash in this line by using RNCryptor library

NSObjectSafe/NSObjectSafe/NSObjectSafe.m

Line 868 in 703982e

if (range.location < self.length) {

Setting <= self.length fixed the crash but I don't know whether something else will be broken or not

NSCache无需拦截key为空的情况

NSCache进行swizzing交换时，无需判断key为nil的情况，因为setObject:forKey方法里key不遵循NSCoping协议，而且通过本地测试（我用的iOS13）测试，当key为nil时，执行上述set方法不会crash,仍然可以继续执行

Crashed when AirDrop present UIActivityViewController on iOS13.0/Xcode 11

Scene:
UIActivityViewController *shareVC = [[UIActivityViewController alloc]initWithActivityItems:@[self.debugText.string] applicationActivities:nil];
[self presentViewController:shareVC animated:YES completion:nil];

Crash:
crash at NSCache(safe) hookSetObject:forKey: ,because input an nil key, but when I don't use NSObjectSafe , it doesn't crash .

Here is screenshot:

+ (void)swizzleClassMethod:(SEL)origSelector withMethod:(SEL)newSelector
{
    Class cls = [self class];
    
    Method originalMethod = class_getClassMethod(cls, origSelector);
    Method swizzledMethod = class_getClassMethod(cls, newSelector);
    
    Class metacls = objc_getMetaClass(NSStringFromClass(cls).UTF8String);
    if (class_addMethod(metacls,
                        origSelector,
                        method_getImplementation(swizzledMethod),
                        method_getTypeEncoding(swizzledMethod)) ) {
        /* swizzing super class method, added if not exist */
        class_replaceMethod(metacls,
                            newSelector,
                            method_getImplementation(originalMethod),
                            method_getTypeEncoding(originalMethod));
        
    } else {
        method_exchangeImplementations(originalMethod, swizzledMethod);
    }
}
- (void)swizzleInstanceMethod:(SEL)origSelector withMethod:(SEL)newSelector
{
    Class cls = [self class];
    /* if current class not exist selector, then get super*/
    Method originalMethod = class_getInstanceMethod(cls, origSelector);
    Method swizzledMethod = class_getInstanceMethod(cls, newSelector);
    /* add selector if not exist, implement append with method */
    if (class_addMethod(cls,
                        origSelector,
                        method_getImplementation(swizzledMethod),
                        method_getTypeEncoding(swizzledMethod)) ) {
        /* replace class instance method, added if selector not exist */
        /* for class cluster , it always add new selector here */
        class_replaceMethod(cls,
                            newSelector,
                            method_getImplementation(originalMethod),
                            method_getTypeEncoding(originalMethod));
        
    } else {
        /* swizzleMethod maybe belong to super */
        class_replaceMethod(cls,
                            newSelector,
                            class_replaceMethod(cls,
                                                origSelector,
                                                method_getImplementation(swizzledMethod),
                                                method_getTypeEncoding(swizzledMethod)),
                            method_getTypeEncoding(originalMethod));
    }
}

为什么交换实例方法的时候需要

class_replaceMethod(cls,
                            newSelector,
                            class_replaceMethod(cls,
                                                origSelector,
                                                method_getImplementation(swizzledMethod),
                                                method_getTypeEncoding(swizzledMethod)),
                            method_getTypeEncoding(originalMethod));

而交换类方法是只需要

method_exchangeImplementations(originalMethod, swizzledMethod);

看了许久，希望能得到帮助和理解

debug模式下如果想生效，怎么使用？

你好，我想在debug模式下生效，怎么使用？

jasenhuang / nsobjectsafe Goto Github PK

nsobjectsafe's People

Stargazers

Watchers

Forkers

nsobjectsafe's Issues

Recommend Projects

Recommend Topics

Recommend Org

Jobs