Comments (3)
Do you see any difference in the resulting rendering?
Django forms use mark_safe() in conjunction with escape(). Here the template languages gives us escaping for free (unless |safe
is used) and return SafeStrings
which should already be marked as safe.
from django-floppyforms.
The difference I see is this
Assume I have a form with the following field:
name = forms.CharField(max_length=5, help_text='<b>Name</b>')
If I use django form I get Name (in bold, as I want). While if I use floppyforms it always appears as Name, which is not what I want, and it is the same if I use |safe
or autoescape off
from django-floppyforms.
I think that is an imparity between Django and Floppyforms that we should not resolve. Django is a little inconsistent with which values are marked as safe and which are not.
For example form.as_p()
will give you a "safe" string which will not be escaped in the template where as form['name'].help_text
will give you a pure string which will be escaped when used in the template.
Floppyform should keep the more consistent behaviour of always sticking with one of those. The safer bet here is probably to go with autoescaping by default. If you want the string to be displayed as is in the template, then use mark_safe
in the definition:
from django.utils.html import mark_safe
name = forms.CharField(help_text=mark_safe('<b>Name</b>')
That is something that we should document.
Thanks for the report!
from django-floppyforms.
Related Issues (20)
- How to use bootstrap style to `datalist`?!
- gis warning when I don't want to use gis HOT 5
- TypeError: get_context() got an unexpected keyword argument 'renderer' on Django 1.11.3 HOT 27
- VariableDoesNotExist: Failed lookup for key [help_text] in u'iban' HOT 1
- Custom radioselect required attrs Widget or rendered? HOT 1
- Endless Loop with django-debug-toolbar HOT 2
- the image_thumbnail.html example causes an error when image exist HOT 3
- Django 2.1 update causing for error, renderer() HOT 4
- Widgets not rendering extra attrs HOT 2
- Removed ORGException causes issues when using GeoDjango after 2.0 HOT 1
- Prepare 1.8.0 release
- Implement Jazzband guidelines for project django-floppyforms HOT 4
- [1.8.0 release blocker] Django templates breaking change? HOT 1
- GeoDjango widgets in admin site cannot be used as regular widgets with the Meta widgets attribute HOT 3
- Django 3 'six' incompatability HOT 2
- Is this project dead? HOT 7
- geodjango floppyform issue
- set extent of map using map_options HOT 3
- How to filter widget input datalist with user name
- Drop support for Python 3.6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from django-floppyforms.