jcgay / send-notification Goto Github PK

Vulnerabilities

DepShield reports that this application's usage of org.eclipse.jetty:jetty-server:9.2.26.v20180806 results in the following vulnerability(s):

• (CVSS 7.5) [CVE-2017-9735] Information Exposure

Occurrences

org.eclipse.jetty:jetty-server:9.2.26.v20180806 is a transitive dependency introduced by the following direct dependency(s):

• com.github.tomakehurst:wiremock:2.22.0
        └─ org.eclipse.jetty:jetty-server:9.2.26.v20180806

_{This is an automated GitHub Issue created by Sonatype DepShield. Details on managing GitHub Apps, including DepShield, are available for personal and organization accounts. Please submit questions or feedback about DepShield to the Sonatype DepShield Community.}

Vulnerabilities

DepShield reports that this application's usage of com.google.guava:guava:18.0 results in the following vulnerability(s):

• (CVSS 5.9) [CVE-2018-10237] Deserialization of Untrusted Data

Occurrences

com.google.guava:guava:18.0 is a transitive dependency introduced by the following direct dependency(s):

• com.google.guava:guava:18.0

• fr.jcgay.send-notification:send-notification:0.15.1-SNAPSHOT
        └─ com.google.guava:guava:18.0

_{This is an automated GitHub Issue created by Sonatype DepShield. Details on managing GitHub Apps, including DepShield, are available for personal and organization accounts. Please submit questions or feedback about DepShield to the Sonatype DepShield Community.}

Hi,

Is there a way to configure how long a notification is visible?

The BurntToast Notifer got its AppId parameter removed in version v0.6.1: https://github.com/Windos/BurntToast.
Please remove it also from your BurntToast notifier, otherwise all calls to the BurntToast notifier fail.

Some notifier are always displayed (like AnyBar).
These should be flagged somewhere (probably Notifier).

It would be useful in maven-notifier or grade-notifier to not bypass the notification
if the notifier is persistent. When using AnyBar actually the build tool icon is displayed when
starting the build, but the result is not sent for short live build...

When I have integrated this notifier into Gradle plugin, there is being created a file named "null" (on CWD) with contents "Active code page: 1250". This is annoying for my plugin users, because this file is created under directory using VCS.

Now I am forced to remove that file manually, even just after Notifier.close() (it is not cleaning :/)

Environment: Windows 10, 64-bit
Send-notification: 0.14.0
Java: 8

#9
jcgay/maven-notifier#26

When possible try to make a duration configurable instead of sometimes rely on timeout.

I am using linux notify-send module and I would want to use native icon instead of specifying one but API do not support it.

Please would you consider this feature ?

As a developer,
When I want to send a notification from my app,
Then I need to provide both an Application and Notification to the library
And Application seems superfluous.

Full code:

        fr.jcgay.notification.Notifier notifier = new SendNotification()
                .setApplication(Application.builder()
                        .id("an-id")
                        .name("a-name")
                        .icon(buildIcon())
                        .build())
                .initNotifier();

        try {
            notifier.send(Notification.builder()
                    .title("Title")
                    .message("Message")
                    .icon(buildIcon())
                    .build());
        } finally {
            notifier.close();
        }

What I expected:

        try {
                    fr.jcgay.notification.Notifier notifier = new SendNotification().send(Notification.builder()
                    .title("Title")
                    .message("Message")
                    .icon(buildIcon())
                    .build());
        } finally {
            notifier.close();
        }

Technically, why Application is required ?

When credentials are not valid, Pushbullet notifier just try to authenticate forever...
We should detect this case and just fail when credentials do not work: https://github.com/square/okhttp/wiki/Recipes#handling-authentication

Vulnerabilities

DepShield reports that this application's usage of org.jboss.netty:netty:3.2.1.Final results in the following vulnerability(s):

• (CVSS 7.5) [CVE-2015-2156] Netty before 3.9.8.Final, 3.10.x before 3.10.3.Final, 4.0.x before 4.0.28.Final,...

Occurrences

org.jboss.netty:netty:3.2.1.Final is a transitive dependency introduced by the following direct dependency(s):

• com.google.code.jgntp:jgntp:1.2.1
        └─ org.jboss.netty:netty:3.2.1.Final

• fr.jcgay.send-notification:send-notification:0.15.1-SNAPSHOT
        └─ com.google.code.jgntp:jgntp:1.2.1
              └─ org.jboss.netty:netty:3.2.1.Final

_{This is an automated GitHub Issue created by Sonatype DepShield. Details on managing GitHub Apps, including DepShield, are available for personal and organization accounts. Please submit questions or feedback about DepShield to the Sonatype DepShield Community.}

It would be useful to support multiple notifications e.g.

notifier.implementation=kdialog,pushbullet

Also, does the extension log information anywhere?

I found maven-notifier to be very slow on Windows 10 with default configuration (ie no config). Maven commands which had taken about 1 second started taking about 10 seconds, and I eventually traced it to BurntToastNotifier.tryInit. (I didn't have BurntToast installed.)

I just installed BurntToast to see if Get-Module -ListAvailable -Name BurntToast | Format-Table Name could detect it faster, and I think it's far too slow to activate automatically.

Would you accept a PR to remove BurntToast from the automatic detection in NotifierProvider.available()?

Vulnerabilities

DepShield reports that this application's usage of org.eclipse.jetty:jetty-http:9.2.26.v20180806 results in the following vulnerability(s):

• (CVSS 7.5) [CVE-2017-9735] Information Exposure

Occurrences

org.eclipse.jetty:jetty-http:9.2.26.v20180806 is a transitive dependency introduced by the following direct dependency(s):

• com.github.tomakehurst:wiremock:2.22.0
        └─ org.eclipse.jetty:jetty-server:9.2.26.v20180806
              └─ org.eclipse.jetty:jetty-http:9.2.26.v20180806

_{This is an automated GitHub Issue created by Sonatype DepShield. Details on managing GitHub Apps, including DepShield, are available for personal and organization accounts. Please submit questions or feedback about DepShield to the Sonatype DepShield Community.}

Following release v0.2.0: https://github.com/tonsky/AnyBar/releases/tag/0.2.0

Choosing a default notifier is based on hard-coded rules:

• Windows, OS X -> growl
• Linux -> notify-send

It would be great to have a system which can automatically discover available notifier.

When no notifier implementation is provided, notifiers try to initialize themselves until one succeed.
They should not log an error when they can be initialized.
Actually for example Growl is polluting logs with errors where it shouldn't.