joefitzgerald / go-plus Goto Github PK
View Code? Open in Web Editor NEWAn Enhanced Go Experience For The Atom Editor
Home Page: https://atom.io/packages/go-plus
License: Other
An Enhanced Go Experience For The Atom Editor
Home Page: https://atom.io/packages/go-plus
License: Other
With the 2.0.2 release of go-plus and atom 0.120, I seem to be unable to click on any of the error messages to navigate to that line. I assume this is due to the changes made to close issue #44.
go-plus/spec/golint-spec.coffee
Line 31 in 3b46077
... to ensure that others can run them also.
I just updated to 2.0.1 and I was getting a formatting error. Go-plus said:
Format Tool Missing
How do i install the missing tools (manually at least)?
I did research that question
I did notice that this should be enabled automatically:
Defaults
By default, the package has the following preferences enabled:
...
Get Missing Tools: run go get -u on startup for all missing tools
...
I checked the settings for the package and it does I have it selected. Then, why is the gofmt not running on save then? Is it a problem with the Go-plus update?
Yet another tool to improve Go code quality.
http://godoc.org/code.google.com/p/go.tools/cmd/vet
Output is very similar to gofmt, but it doesn't rewrite your code.
Dependent on atom-archive/autocomplete#18, or the inclusion of some of the core autocomplete functionality in this plugin.
There shouldn't be a message saying "No issues". It should simply not show. It should at least be optional.
Apologies if this is covered elsewhere, I couldn't see it.
I use "gohtml" as my extension for html templates, and use [[ and ]] to delimit the template instructions to avoid clashing with Angular.
I don't want to create a new Atom package to deal with this... it'd be fantastic if go-plus could support this. Of course, it would need to understand the template library and tell me when I got a template instruction wrong.
Totally not an actual issue, just a feature request. Ignore at will, and keep up the amazing work :)
I am having problems re producing this "error" but last night (I think before I downloaded 2.0.1) Go-plus was giving me yellow warnings about the fmt package.
I didn't really understand what the problem was but my go file ran just fin with go run
.
I think the yellow warnings are meant to say that this is not good but it probably won't crash your code or something similar. I was wondering if it was possible make them optional to appear at the bottom window.
For example, it doesn't want me to use underscore in a package name, but going through all the source code already written just to change that is not something my team can do right now, having the yellow arrows optional might be useful. So I thought it might be useful to have this feature (maybe not).
I'm using the Google App Engine local dev environment and they use a goapp binary instead of the normal go binary, which includes their "appengine" packages to be referenced as if they were part of the standard library. If the "Go Installation" variable allowed for setting a binary as well as the path, that should make things work peachy. :)
https://developers.google.com/appengine/docs/go/tools/devserver#Go_Using_the_goapp_tool
Hi,
i'm not sure if this is intentional or a bug but when running go test
fails there is no output of any kind only the abscensce of the coverage hints at something beeing wrong.
Would be nice to have a pane display the output. Extra awesomeness would be to parse that output to jump to where it failed.
Using Go: (@/usr/local/bin/go)
GOPATH: /Users/user/src/go
Cover Tool: Not Found
Vet Tool: Not Found
Format Tool: /Users/user/src/go/bin/goimports
Lint Tool: /Users/user/src/go/bin/golint
Oracle Tool: /Users/user/src/go/bin/oracle
Breakpoints, code stepping, the works...
That would be awesome, please.
This was mentioned by mrwong here earlier today, but it might not get noticed in a closed issue.
The request is to have a file (like .goplus
) that defines what the GOPATH (and other env variables) are per-project. While having multiple go paths is not necessarily idiomatic, many people do use this approach. Having the option to change to a different GOPATH based on the project would be incredibly helpful.
As originally raised at: atom/language-go#10
If https://github.com/tcarlsen/atom-message-panel doesn't have everything needed, create PRs against it.
When collecting error / warning information from multiple tools, we should avoid duplicating the logic for displaying these for the user, collecting them and displaying them consistently.
See: #46 (comment) for background detail.
apm
I'm trying to get test coverage to work on my machine and it doesn't seem to be doing anything. I'm not getting any error messages or popups of any kind. I also don't see the temp file coverage.out that is supposed to be created, so I'm wondering if that's the culprit. I've tried running Atom in both administrator and normal modes. What's the best way to debug what's happening?
This makes the use of goimports easier ($GOPATH/bin/goimports
vs a fully qualified path). This is already done for golint (https://github.com/joefitzgerald/go-plus/blob/master/lib/golint.coffee#L39).
I think startup info (Using Go: go1.2.1 linux/amd64 (@/usr/bin/go)...
) should be hidden at startup. Especially when there is no error and Show Panel When No Issues Exist
is unchecked.
PS: Thanks for this nice plugin!
We could do a better job of:
This is inspired by comments from @mreynolds.
/usr/local/go/bin/go
(indicating package or binary installed go)/usr/local/opt/go/bin/go
(indicating brew-installed go)C:\Go\bin\go
(hello, Windows!)which go
(except on Windows) to determine if go
from the PATH is the same as a detected gogo env
and inspect values for GOROOT and GOPATH to determine the location of the go and gofmt executablescover
needs to be manually installedvet
needs to be manually installedgodoc
needs to be manually installedcover
vet
godoc
Note: This is now a mega-issue and needs to be broken up into smaller, achievable chunks.
When i press Ctrl+s, i get the warning:
Warning: GOPATH [c] does not exist
My enveroment:
c:>echo %GOPATH%
C:\Users\samsung\workspace
c:>cd %GOPATH%
C:\Users\samsung\workspace>dir
14.07.2014 17:20
.What's wrong?
Add support for golint to display warnings (suggested by @darkhelmet).
golint
path and the ability to enable / disable its usegolint
golint
I noticed gofmt did not detect an obvious error in my code that is used to detect just fine. Wondering why I went around my files to see if this was the case for all my files, and in all of my files except one it said nothing. When I fixed the error in this file gofmt worked properly again in my original file.
Is there any way to let the user know if there is an error somewhere else in your project directory? Placing markers/colors in the sidebar maybe? Or is something like this not possible with how gofmt works?
... help potential contributors understand how to get set up for development of the plugin, and ensure that tests pass.
Currently saving a file causes the tree-view to flicker because a temporary file is created and then removed. Is there any chance this file could be located in /tmp or be hidden somehow?
This is a minor detail and time is probably better spent integrating geocode but thought I should mention it while your available π
Overhead from @soundcloud at @gophercon, gocov looks worthy of integration.
Could also investigate integrating directly against go
using:
go test -cover -coverprofile cover.out
go tool cover -func=cover.out
Steps to reproduce:
go-plus
package.go
file with an obvious syntax error; notice that there is only one message panel showing with any issuesgo-plus
package; enable the go-plus
package.go
file againI'm not sure if this is an issue with atom-message-panel
or go-plus
use of it.
Originally reported in #44.
https://code.google.com/p/go-wiki/wiki/GOPATH
Since the $GOPATH variable can be a list, the rest of this document will use $GOPATH to mean the first element unless otherwise specified.
Gofmt Path
and Golint Path
preferences#18
Does not seem be be fixed in 1.1.4
I have a composed GOPATH="/home/user/.go:/home/user/go-project" and Go-Plus seems to ignore the second. The following error occurs importing a package from the second path:
cannot find package "xyz" in any of: /opt/google/go/src/pkg/xyz (from $GOROOT) /home/user/.go/src/xyz (from $GOPATH)
in a file go-project/src/xyz/abc/file.go which imports "xyz".
Note that I need /home/user/.go to be the first element in $GOPATH because I want dependencies (with go get) and binaries to be installed there.
It would be nice to have a keyboard shortcut / right click menu item / menu item to go to definition for the current cursor position.
Hi,
I was wondering how to resolve an issue where go-plus isn't picking up the gofmt tool. It's definitely installed and available on my system.
β teamstats [update-readme] which gofmt
/usr/local/go/bin/gofmt
Any ideas?
See: #46 (comment) for background detail.
... Because it's pretty obvious the current package won't work due to paths and the environment.
Can we get some kind of ctrl-left-elbow function for finding the definition of the identifier I have selected? like func refs, vars refs, etc?
As suggested here: atom/language-go#2
gocode
process lifecyclegocode
for the current fileIs go-plus not suppose to analyze your code if its open on a different pane?
I had a different file open on a right pane and when I saved, it didn't do syntax analysis or anything like that. Is that expected behaviour?
Also, when I save only with one file, two little windows at the bottom with the same message open, even though there is only one file open. These bugs are happening only after the update to 2.0.1, not sure if I should open a new gitissue...
Hello,
I just installed Atom and Go Plus and it isn't allowing me to build from the command palette. It simply just does nothing. I am hitting Cmd+Shift+P and typing "go build". It finds a "Golang: Go build" command and when I select it nothing happens.
Is there something else I am supposed to be doing to build my Go code in Atom with Go Plus? Everything else works - I can confirm that gofmt and govet work fine on save.. so I can safely assume that Go Plus is finding my Go binaries fine (they are in /usr/local/go).
Any help would be great. If you need any other system information or anything let me know.
Cheers,
Simon
... one should work without the other.
Format On Save
is false, Vet On Save
works...with the following error
Installing β[email protected]β failed. Lessβ¦
npm http GET https://registry.npmjs.org/fs-plus
npm http GET https://registry.npmjs.org/underscore-plus
npm http GET https://registry.npmjs.org/temp
npm http GET https://registry.npmjs.org/emissary
npm http 304 https://registry.npmjs.org/emissary
npm http 304 https://registry.npmjs.org/underscore-plus
npm http 304 https://registry.npmjs.org/temp
npm http 304 https://registry.npmjs.org/fs-plus
npm http GET https://registry.npmjs.org/underscore
npm http GET https://registry.npmjs.org/rimraf
npm http GET https://registry.npmjs.org/mkdirp
npm http GET https://registry.npmjs.org/async
npm http GET https://registry.npmjs.org/rimraf
npm http GET https://registry.npmjs.org/osenv/0.0.3
npm http GET https://registry.npmjs.org/mixto
npm http GET https://registry.npmjs.org/property-accessors
npm http 304 https://registry.npmjs.org/rimraf
npm http 304 https://registry.npmjs.org/rimraf
npm http 304 https://registry.npmjs.org/underscore
npm http 304 https://registry.npmjs.org/async
npm http 304 https://registry.npmjs.org/osenv/0.0.3
npm http GET https://registry.npmjs.org/graceful-fs
npm http 304 https://registry.npmjs.org/property-accessors
npm http 304 https://registry.npmjs.org/mkdirp
npm http 304 https://registry.npmjs.org/mixto
npm http 304 https://registry.npmjs.org/graceful-fs
npm ERR! Failed resolving git HEAD (https://github.com/Benvie/harmony-collections.git) fatal: bad object e81b4b808359e2def9eeeabfdee69c2989e1fe96
npm ERR! Failed resolving git HEAD (https://github.com/Benvie/harmony-collections.git)
npm ERR! Error: Command failed: fatal: bad object e81b4b808359e2def9eeeabfdee69c2989e1fe96
npm ERR!
npm ERR! at ChildProcess.exithandler (child_process.js:637:15)
npm ERR! at ChildProcess.EventEmitter.emit (events.js:98:17)
npm ERR! at maybeClose (child_process.js:743:16)
npm ERR! at Socket.<anonymous> (child_process.js:956:11)
npm ERR! at Socket.EventEmitter.emit (events.js:95:17)
npm ERR! at Pipe.close (net.js:465:12)
npm ERR! If you need help, you may report this *entire* log,
npm ERR! including the npm and node versions, at:
npm ERR! <http://github.com/npm/npm/issues>
npm ERR! System Darwin 13.1.0
npm ERR! command "/Applications/Atom.app/Contents/Resources/app/apm/node_modules/atom-package-manager/bin/node_darwin_x64" "/Applications/Atom.app/Contents/Resources/app/apm/node_modules/atom-package-manager/node_modules/npm/bin/npm-cli.js" "--userconfig" "/Applications/Atom.app/Contents/Resources/app/apm/node_modules/atom-package-manager/.apmrc" "install" "/Users/piotr/.atom/.node-gyp/.atom/.apm/go-plus/0.5.2/package.tgz" "--target=0.11.10" "--arch=x64"
npm ERR! cwd /private/var/folders/j6/mx2fn8_s555d2fcxtzdzt4540000gn/T/apm-install-dir-114222-51964-zh6vy2
npm ERR! node -v v0.10.26
npm ERR! npm -v 1.4.4
npm ERR! code 128
npm ERR!
npm ERR! Additional logging details can be found in:
npm ERR! /private/var/folders/j6/mx2fn8_s555d2fcxtzdzt4540000gn/T/apm-install-dir-114222-51964-zh6vy2/npm-debug.log
npm ERR! not ok code 0
For some reason, I can't copy the output of the go-plus error window, but it's basically telling me that my GOPATH ("/Users/mreynolds/Desktop/Projects/:/usr/local/opt/go") doesn't exist, which is correct, since it's a PATH, not a single directory.
I'm using 1.0.10 with Brew installed go. I haven't tried manually overriding my env vars in settings.
... it's an indicator that perhaps your $GOPATH is not valid.
Would be nice to view the godoc for the selected item.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. πππ
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google β€οΈ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.