GithubHelp home page GithubHelp logo

Baseline Storybook stories about guppy HOT 9 OPEN

joshwcomeau avatar joshwcomeau commented on July 4, 2024 1
Baseline Storybook stories

from guppy.

Comments (9)

Futuro212 avatar Futuro212 commented on July 4, 2024 3

I'm gonna make some of the stories 👍

from guppy.

joshwcomeau avatar joshwcomeau commented on July 4, 2024 2

@Leodau and anyone else, this is good to be worked on!

Check out the example stories ProgressBar, Button, and ButtonWithIcon to use as templates for the future stories you write :)

from guppy.

superhawk610 avatar superhawk610 commented on July 4, 2024 2

@Futuro212 great question! I would probably stick to 3 to 5 component stories per PR, that way it keeps your changes concise and easy to review in a single session (this is something I struggle with, as @joshwcomeau can attest 😁).

I would also update your comment with a checklist of the stories you're in progress on, that way if someone else wants to contribute they'll know which ones to skip so you're not duplicating each others' work.

from guppy.

joshwcomeau avatar joshwcomeau commented on July 4, 2024 1

Hey @Leodau - created this issue. While it's not yet ready to be worked on, I figure you could get started (if you want) by picking a few components, learning about them, and thinking about how you'd create stories to best highlight them?

from guppy.

joshwcomeau avatar joshwcomeau commented on July 4, 2024

@Futuro212 awesome, thanks!

Could be helpful to post the ones you're thinking of tackling, to make sure work isn't duplicated with someone else :)

from guppy.

Futuro212 avatar Futuro212 commented on July 4, 2024

I'm going by the order of the list :)

Should I submit pull requests after doing some stories? First time contributing :)

The ones I'm tackling:

  • Card
  • tbd

from guppy.

joshwcomeau avatar joshwcomeau commented on July 4, 2024

Hi @Futuro212,

We're starting to think about moving from Storybook to Docz. If you've already done Card, I'd just open a PR with that one, and hold off from doing any more :)

We'd love to get your help adding stories in Docz instead! Let us know if you're interested in that. The process is quite similar, but Docz use a Markdown+JSX syntax that is much nicer to work with

from guppy.

Futuro212 avatar Futuro212 commented on July 4, 2024

hey @joshwcomeau, lately I didn't have much time to progress with the task and since the card was simple, ill try the Docz approach :)

from guppy.

joshwcomeau avatar joshwcomeau commented on July 4, 2024

Hi @Futuro212,

Ah, so we haven't actually merged Docz in yet (it's #254). I think we do want to switch to it, but the first task is to fix whatever's causing the tests to fail, and convert all existing stories (since I don't really wanna have two conflicting solutions).

If you're up for it, feel free to take over that task :) but otherwise, maybe just open a PR with the work you've already done (if anything's ready - I saw the "Card" checkbox was ticked, but no worries if it's not quite ready for merging yet), and hang on until that stuff's ready to go.

from guppy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.