Comments (4)
Oh just noticed this also broke the develop server which was also running. Which is probably something we need to fix as we could probably detect this and die and restart (maybe?).
from guppy.
Hi Kyle! Thanks for checking Guppy out, glad you enjoyed it :D It's still super early days, but I'm excited to see where it goes from here.
There's some general weirdness with trying to do things while deps are installing (tracked in #33). My current not-very-great solution is to disable all dependency actions while one is in progress (since yeah trying to install a dependency while one is already installing will fail, as the package.json is currently write-locked). I could extend that solution to disable tasks while dependencies are installing.
It's very odd that it crashed the dev server! I don't remember running into that. I'll see if I can reproduce and follow-up if I can't for more info.
from guppy.
Alright, finally had some time to dig into this!
I wasn't able to reproduce this error. I tried the following:
- Create a new Gatsby project
- Start the development server
- Start installing a new dependency (
hello
) - While it was installing, start a build
I repeated this a couple times with different dependencies (redux
, lodash
), as well as tried other things like formatting, and stopping/starting the dev server during installation.
@KyleAMathews if you can reproduce, can you share what the build failure + dev server crash were? For the dev server crash, I think we should be able to intercept that error and trigger a restart. For the build failure, we can just append additional error logs, something like "This may have failed because a dependency install was in progress. Please try again once the dependency installation has completed".
from guppy.
Ah, so I was actually able to replicate the build failure:
It's disguised as a success, so I probably didn't notice it in my earlier testing.
It should be an easy fix; disable builds while there's an active dependency queue for the project. Will tackle shortly.
(have not been able to replicate the dev-server crash 🤔)
from guppy.
Related Issues (20)
- Export to Codesandbox
- Batch start multiple tasks
- Change test script to interactive mode HOT 2
- react-scripts not found HOT 4
- package.json gets wiped and committed sometimes (inconsistent)
- Improve reinstall loading screen status message UI HOT 4
- can't finde local nodejs HOT 2
- Test killProcessId after bumping ps-tree HOT 1
- Improve UX by cancelling blocking tasks or paralleling tasks
- Disable actions that require an internet connection HOT 8
- Node Missing HOT 1
- Confirmation prompt upon exit if the servers are still in running state. HOT 6
- Theming of the UI HOT 4
- Color normalization
- Sidebar reorder blocked by component overlay HOT 9
- Tab-nabbing vulnerability on the guppy5.02.09 CMS HOT 1
- Mark or highlight an outdated dependency HOT 1
- Why only create-react-app or Gatsby projects?
- Templates options
- Is this project dead?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from guppy.