kamkeel / customnpc-plus

Custom Version of 1.7.10 CustomNPC with backported features and original expansions

👋 Welcome to the CustomNPC+ Repository.

CustomNPC+ is a Minecraft mod that allows you to add custom NPCs to your world. It is developed for creative and storytelling players who want to make their Minecraft worlds more in-depth and unique. CustomNPC+ is only a branch version of the 1.7.10 Forge version of the original (down below) and has no plans to add or update any other version. This is not an official version of CustomNPC.

---

---

❗ Notice

I am not the original creator of CustomNPC. The original creator is @Noppes. I have been permitted to update and develop my own branch version for 1.7.10. The original mod that is updated to the latest versions of Minecraft can be found on these links: CurseForge, kodevelopment

⬇️ Downloads

• Modrinth: Download
• CurseForge: Download

🔹 Installation

This mod is an update to CustomNPC and not an add-on. Do not install CustomNPC with CustomNPC-Plus. CustomNPC-Plus does not remove any functional features from the original mod. It expands upon CustomNPC with original features and backported features from newer versions. Simply drag CustomNPC-Plus into any client/server mods folder to utilize. Please backup before using as this could still have unforeseen errors. Report any bugs if found, thank you and enjoy.

❓ Features:

• Flying NPC (Smart Pathfinding)
• 1.8 Skin Support (64x64) (Alex/Steve64)
• Full URL64 Selector (Downloads FULL Size Images for Custom Mob Skins)
• Additional Parts: [Wings, Fins, Capes, Horns, Tail]
• Hide Body Parts [Arms, Legs, Head, Body]
• Custom Overlays
• Animation Maker
• Enhanced Cloner GUI (More Tabs, Filters, Tags)
• Markov Name Generator
• Dark Mode GUI (Link Below)
• 1.12 Scripting Features (Details below)

Scripting:

• CustomNPC+ Api: API
• Java Doc: kamkeel.github.io/CustomNPC-Plus
• Scripted Items
• Player Overlays
• Script Timers
• Global Scripts
• Script Logging
• GUI Overlays
• Event Scripting (We never remove script functionality, only add on existing functions)

🔰 Skin Model Feature:

*Majority of these cape designs are taken from the internet with fair-usage.

❔ Please note all local skins in this version of CustomNPC, must match the model selected.

Flying NPCs:

Url64:

DarkMode + Cloner GUI:

🔗 Want to check out my other projects?

Plugin Mod is a mod designed to add more aesthetic items for RPG and storytelling. It is compatible with CustomNPC+ and has many items intended to be used and wielded by created NPCs.

RPG Messenger is a bukkit plugin designed to allow operators to create messagable NPCs for RPG Servers. Allows a 'RPG Controller' to reply quickly as NPCs, form groupchats, and messagable parties.

CustomNPC+ Dark Mode is a resource pack for CustomNPC+ that alters all GUIs within the mod to a dark variant that is both clean and pleasing to look at.

Cloning / Compiling / Building

git clone call git submodule update --init --recursive

Using IntelliJ, take the following steps:

1. Run setupDecompWorkspace under the forgegradle tab.
2. Refresh Gradle.
3. Run genIntellijRuns under the other tab to set up your Minecraft runs.

or for Eclipse, run gradlew setupDecompWorkspace eclipse then import the project.

Mixin code will not work if you do not add --tweakClass org.spongepowered.asm.launch.MixinTweaker --mixin customnpcs.mixins.json to your program arguments.

customnpc-plus's Issues

CNPC+ API for modding

Issue description:

Hi. This is great that u dudes decided to improve original modification. But I have a question - are you going to add any API so other mods would be able to communicate with CNPC, subscribe to it's own events, etc.? I suppose this could be a great help to other modmakers
I see that original author also made API for this (sadly, only for minecraft 1.8+ versions).

Versions:

• Minecraft: 1.7.10
• Forge: 1.7.10-10.13.4.1614
• CustomNPC+: *

[Bug] Player Scripts somehow disable themselves sometimes with no error/warning

Issue description:
all was well, I was programming in some sort of pseudo block place detection with utilisation of mouse events and item stacks. after I finished getting mouse button ids, the code just stopped running inexplicably. I restarted my game, rejoined, added checks for other events, tested in local and only a server restart resolved the issue.
no errors appeared in my console or client log.
the code I was using will be below incase it's useful
Versions:

• Minecraft: 1.7.10
• Forge: 10.13.4.1558
• CustomNPC+: 1.8.1

offending script

function mouseClicked(event) {
var cStack = event.player.getHeldItem();
var LStack = event.player.getTempData("lItem");
if(cStack != null){
if (cStack.getName() != LStack){
var cNm = cStack.getName();
event.player.sendMessage(event.player.getHeldItem().getName());
event.player.setTempData("lItem", cNm);
}}}

function breakBlock(event){
event.player.sendMessage("cring");
}

Implement quest tab scroll function

This have been an issue for a long time and it annoyed me so much back in the day.
Whenever you have too many active quests your other quest tabs are out of screen and to view them you have to lower the GUI scale and then revert it.

The fix for this would be to add a scroll function to the quest tab

Idea. The final point of movement of the NPC.

How about adding to movingtype the ability to move the NPC to the end point and stay there until, say, morning. So you can make the illusion of NPC life in the morning and at night. For example the NPC works in the morning and then appears in bed at night as a doll

Question about the compatibility of this version of the mod with the original mod

Hello, I have a couple of questions:

1. can I put this modification on the server
2. if I replace the original mod with CustomNPC-Plus, will there be any conflicts?

1.19.4 support

Hi @KAMKEEL, would be possible to update the mod to be usable at 1.19.4 version? Thank you in advance!!

CNPCs + 3D Model Weapons Render Issue (TechGuns, Matter Overdrive and etc.)

Issue description:

Hi. NPCs just can't figure out how to hold any 3D Model guns and weapons from other mods. This problem has been haunting the mod since its earliest versions, unfortunately, it has not been fixed.
Of course, mod authors just slamdunk'd the support for mods on 1.12.2- Minecraft versions, like a Michael Jordan in basketball.

Versions:

• Minecraft: 1.7.10
• Forge: 1.7.10-10.13.4.1614
• CustomNPC+: literally any version

To reproduce this issue you need:

• Matter Overdrive

• TechGuns

Poor 9mm pistol guy.

NPCs cant deal damage with ranged attacks

This appeal should not have happened. excuse me

[bug] itemslots not using the id that's set

Issue description:
When an itemslot is created via: event.gui.addItemSlot(int id, int x, int y);
the id is completely detached from the itemSlot events, so it has no real use currently.
Versions:

• Minecraft: 1.7.10
• Forge: the sameold sameold
• CustomNPC+: 1.8.3
  
  https://media.discordapp.net/attachments/1003994806457999461/1110557599360884857/image.png?width=401&height=105

Spawning a Custom NPC crashes my game.

When ever I try to spawn an NPC, the game crashes.

crash-2023-05-09_23.41.52-server.txt

**Versions:1.8

• Minecraft: 1.7.10
• Forge: 10.13.4.1614-1.7.10
• CustomNPC+:

Can it be reproduced with just CustomNPC+? If not, list the other mods required to reproduce the issue.

Dupe Immersive Engineering

Issue description: Dupe blast furnace and coke oven (possibly other multiblock structures), the video shows how to dupe.
Without CustomNPC Plus, this dupe does not work, so the problem is most likely in CustomNPC Plus

If crashed, link to crash report (use a site such as pastebin):

Versions: Immersive Engineering v0.7.7

• Minecraft: 1.7.10
• Forge: 10.13.4.1614
• CustomNPC+: 1.6.1

Can it be reproduced with just CustomNPC+? If not, list the other mods required to reproduce the issue. Immersive Engineering

https://www.youtube.com/watch?v=dB-MPtl73XE

desynced armor on animation

Issue description:
when rotating or changing pivot positions by significant margins, armour model seems to animate at different speeds to the main body.

Versions:

• Minecraft: 1.7.10
• Forge: 10.13.4.1558
• CustomNPC+: 1.8

Can it be reproduced with just CustomNPC+? If not, list the other mods required to reproduce the issue.
can be reproduced both offline and online with CNPC+
https://github.com/KAMKEEL/CustomNPC-Plus/assets/31368984/27d13cd9-07e2-4da2-b313-b47815348e99

Quest and NPC's data cant load

Issue description:

Stacktrace of bug
https://pastebin.com/vfppmmRp

Versions:

• Minecraft: 1.7.10
• Forge: 10.13.4.1614
• CustomNPC+: All versions and default CustomNPC build

Can it be reproduced with just CustomNPC+? If not, list the other mods required to reproduce the issue.
ThermalMods

Quest data like a .json
https://pastebin.com/H0QERj61

performance problems

i spawned about 100 npcs, separated to 2 groups and made them fight, thing were normal. but when i set to gamemode 0 and tried to make them fight with me, lag happened and tps dropped very low. things got even worse when i tried to move around or flying over them quickly.their aggrorange were 64.
i tried this in 1.16.5 as well, and the situation were much better in 1.16. so i'm wondering what caused this problem and how can i solve it.

Itemslots created via script don't have an id - also a visual itemslot /*duplication*/ bug when creating new itemslots

Issue description:
creating itemslots via script seems to duplicate them, duplicated itemslots and normal itemslots created via script aren't acessible via id.
can be produced in single player and multiplayer.

Versions:

• Minecraft: 1.7.10
• Forge: 10.13.4.1558
• CustomNPC+: 1.8.5

Can it be reproduced with just CustomNPC+? If not, list the other mods required to reproduce the issue.
I'm fairly certain this is just cnpc+
https://github.com/KAMKEEL/CustomNPC-Plus/assets/31368984/d2f74da4-20bf-4acd-b131-1a46c8100dd3

https://github.com/KAMKEEL/CustomNPC-Plus/assets/31368984/3f82e052-332d-4423-9c33-6e0bae963f97
as shown in this video, they are still the correct amount of slots? so I'm confused by the way the ui updates

Crashing when summing npc

So I added the mod to the mod folder and used it with flans mod for npc, after opening a world and trying to place a npc it crashes and says "The game crashed whilst exception in server tick loop
Error: java.lang.NoSuchFieldError: NpcNavRange" I tried removing other mods but it still crashes

here is the crash report: ---- Minecraft Crash Report ----
// On the bright side, I bought you a teddy bear!

Time:
Description: Exception in server tick loop

java.lang.NoSuchFieldError: NpcNavRange
at noppes.npcs.entity.EntityNPCInterface.func_110147_ax(EntityNPCInterface.java:288)
at net.minecraft.entity.EntityLivingBase.(EntityLivingBase.java:120)
at net.minecraft.entity.EntityLiving.(EntityLiving.java:68)
at net.minecraft.entity.EntityCreature.(SourceFile:23)
at noppes.npcs.entity.EntityNPCInterface.(EntityNPCInterface.java:243)
at noppes.npcs.entity.EntityNPCFlying.(EntityNPCFlying.java:13)
at noppes.npcs.entity.EntityCustomNpc.(EntityCustomNpc.java:27)
at noppes.npcs.items.ItemNpcWand.func_77648_a(ItemNpcWand.java:46)
at net.minecraftforge.common.ForgeHooks.onPlaceItemIntoWorld(ForgeHooks.java:505)
at net.minecraft.item.ItemStack.func_77943_a(ItemStack.java:128)
at net.minecraft.server.management.ItemInWorldManager.func_73078_a(ItemInWorldManager.java:389)
at net.minecraft.network.NetHandlerPlayServer.func_147346_a(NetHandlerPlayServer.java:556)
at net.minecraft.network.play.client.C08PacketPlayerBlockPlacement.func_148833_a(SourceFile:60)
at net.minecraft.network.play.client.C08PacketPlayerBlockPlacement.func_148833_a(SourceFile:9)
at net.minecraft.network.NetworkManager.func_74428_b(NetworkManager.java:212)
at net.minecraft.network.NetworkSystem.func_151269_c(NetworkSystem.java:165)
at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:659)
at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:547)
at net.minecraft.server.integrated.IntegratedServer.func_71217_p(IntegratedServer.java:111)
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:427)
at net.minecraft.server.MinecraftServer$2.run(MinecraftServer.java:685)

A detailed walkthrough of the error, its code path and all known details is as follows:

-- System Details --
Details:
Minecraft Version: 1.7.10
Operating System: Mac OS X (x86_64) version 10.16
Java Version: 1.8.0_74, Oracle Corporation
Java VM Version: Java HotSpot(TM) 64-Bit Server VM (mixed mode), Oracle Corporation
Memory: 135271016 bytes (129 MB) / 2147483648 bytes (2048 MB) up to 2147483648 bytes (2048 MB)
JVM Flags: 7 total; -Xmx2G -XX:+UnlockExperimentalVMOptions -XX:+UseG1GC -XX:G1NewSizePercent=20 -XX:G1ReservePercent=20 -XX:MaxGCPauseMillis=50 -XX:G1HeapRegionSize=32M
AABB Pool Size: 0 (0 bytes; 0 MB) allocated, 0 (0 bytes; 0 MB) used
IntCache: cache: 0, tcache: 0, allocated: 0, tallocated: 0
FML: MCP v9.05 FML v7.10.99.99 Minecraft Forge 10.13.4.1614 22 mods loaded, 22 mods active
States: 'U' = Unloaded 'L' = Loaded 'C' = Constructed 'H' = Pre-initialized 'I' = Initialized 'J' = Post-initialized 'A' = Available 'D' = Disabled 'E' = Errored
UCHIJAAAA mcp{9.05} [Minecraft Coder Pack] (minecraft.jar)
UCHIJAAAA FML{7.10.99.99} [Forge Mod Loader] (forge-1.7.10-10.13.4.1614-1.7.10.jar)
UCHIJAAAA Forge{10.13.4.1614} [Minecraft Forge] (forge-1.7.10-10.13.4.1614-1.7.10.jar)
UCHIJAAAA bspkrsCore{6.16} [bspkrsCore] (1.7.10bspkrsCore-universal-6.16.jar)
UCHIJAAAA DamageIndicatorsMod{3.2.0} [Damage Indicators] (1.7.10DamageIndicatorsMod-3.2.0.jar)
UCHIJAAAA Treecapitator{1.7.10} [Treecapitator] (1.7.10Treecapitator-universal-2.0.4.jar)
UCHIJAAAA customnpcs{1.8.5} [CustomNPC+] (CustomNPC-Plus-1.8.5.jar)
UCHIJAAAA flansmod{1.56} [Flan's Mod Ultimate] (Flan's+Mod+Ultimate+Stability+Edition-1.56.jar)
UCHIJAAAA npcflancompatibility{1.0} [CustomNPCs Flan Compatibility Mod] ([1.7.10]-Flan's-Mod-NPC-Vehicles-4.0.jar)
UCHIJAAAA wolffsmod{4.0} [Flan's Mod NPC Vehicles] ([1.7.10]-Flan's-Mod-NPC-Vehicles-4.0.jar)
UCHIJAAAA mod.ymt.air.HariboteAirCraft{172v2 hiten} [HariboteAirCraft] (aircraft-mod-1.7.2.zip)
UCHIJAAAA AquaTweaks{1.0} [AquaTweaks] (AquaTweaks-1.7.10-1.0.jar)
UCHIJAAAA ArchitectureCraft{1.7.2} [ArchitectureCraft] (architecturecraft-1.7.2-mc1.7.10.jar)
UCHIJAAAA journeymap{5.1.4p2} [JourneyMap] (journeymap-1.7.10-5.1.4p2-unlimited.jar)
UCHIJAAAA cfm{3.4.8} [�9MrCrayfish's Furniture Mod] (MrCrayfishFurnitureModv3.4.81.7.10.jar)
UCHIJAAAA mw{0.4.2.4} [Modern Warfare Contagion] (mw_2.0-0.4.2.4+(Halloween+Update)_mc1.7.10.jar)
UCHIJAAAA roadstuff{0.4.0} [Road Stuff] (RoadStuff_mc1.7.10_0.4.0.jar)
UCHIJAAAA signpic{2.8.0} [SignPicture] (SignPicture_1.7.10_2.8.0_universal.jar)
UCHIJAAAA staircraftmod{1.7} [Staircraft] (staircraftmod-1.7-1.7.10-forge.jar)
UCHIJAAAA Waila{1.5.10} [Waila] (Waila_1.5.10_1.7.10.jar)
UCHIJAAAA WailaHarvestability{1.1.6} [Waila Harvestability] (wailaharvestability-mc1.7.10-1.1.6.jar)
UCHIJAAAA worldedit{6.0-beta-01} [WorldEdit] (worldedit-forge-mc1.7.10-6.0-beta-01.jar)
GL info: ERROR RuntimeException: No OpenGL context found in the current thread.
Flan's Mod Content Packs:
flans_simple_parts_pack_1.7.10.jar (filepath: /Users/noorullah/Library/Application Support/minecraft/Flan/flans_simple_parts_pack_1.7.10.jar)
Monolith Pack Version 3 Ausf. C (filepath: /Users/noorullah/Library/Application Support/minecraft/Flan/Monolith Pack Version 3 Ausf. C)
Warfare44ContentPackForMTS-Version_1.0.0.jar (filepath: /Users/noorullah/Library/Application Support/minecraft/Flan/Warfare44ContentPackForMTS-Version_1.0.0.jar)
Minecraft SMP Parts Package 4.0-Content Pack-1.7.10-4.10.0 (2).jar (filepath: /Users/noorullah/Library/Application Support/minecraft/Flan/Minecraft SMP Parts Package 4.0-Content Pack-1.7.10-4.10.0 (2).jar)
WW2-Content Pack-1.7.10-4.10.0(1).jar (filepath: /Users/noorullah/Library/Application Support/minecraft/Flan/WW2-Content Pack-1.7.10-4.10.0(1).jar)
warfare-44-content-pack-1_7_10.jar (filepath: /Users/noorullah/Library/Application Support/minecraft/Flan/warfare-44-content-pack-1_7_10.jar)
ManusWW2Package-Content Pack V4.0-1.7.10-4.10.0.jar (filepath: /Users/noorullah/Library/Application Support/minecraft/Flan/ManusWW2Package-Content Pack V4.0-1.7.10-4.10.0.jar)
italian-ww2-pack-3d-v1.3.zip (filepath: /Users/noorullah/Library/Application Support/minecraft/Flan/italian-ww2-pack-3d-v1.3.zip)
British-Military-Pack-V1.12.jar (filepath: /Users/noorullah/Library/Application Support/minecraft/Flan/British-Military-Pack-V1.12.jar)
[1.7.10]+Wolff's+Germany+WW2+Pack-2.3.jar (filepath: /Users/noorullah/Library/Application Support/minecraft/Flan/[1.7.10]+Wolff's+Germany+WW2+Pack-2.3.jar)
dr_prof_luigis_pack_1_7_10.zip (filepath: /Users/noorullah/Library/Application Support/minecraft/Flan/dr_prof_luigis_pack_1_7_10.zip)
akaku-vehicle-package-3.1-for-1.7.10.zip (filepath: /Users/noorullah/Library/Application Support/minecraft/Flan/akaku-vehicle-package-3.1-for-1.7.10.zip)
Profiler Position: N/A (disabled)
Vec3 Pool Size: 0 (0 bytes; 0 MB) allocated, 0 (0 bytes; 0 MB) used
Player Count: 1 / 8; [EntityPlayerMP['RickyTheMoleRat'/38, l='New World', x=1278.52, y=4.00, z=142.58]]
Type: Integrated Server (map_client.txt)
Is Modded: Definitely; Client brand changed to 'fml,forge'

Versions:

• Minecraft: 1.7.10
• Forge:
• CustomNPC+:

Some The bug of the respawn of the NPC

Good afternoon. Can I order some fixes from you to modify the custom Npc plus? The fact is that there is a very annoying bug in the original Custom Npc, because of which enemy NPCs (for example, those who are placed in a dungeon) do not count down to respawn after death, if the player is not in the same chunk with them. As a result, a player who comes to the dungeon after another player finds that the dungeon is empty, and he has to stand and wait in the chunk until the enemy NPC is respawn again, if the respawn time of the NPC is for example 5 minutes or more.

There is also another related error.
Custom Npc as the best mod for NPCs is often used on servers to play over the network on cores such as thermos or crucible, but there is an error in these server cores, due to which NPCs who died outside the chunk where they were created are automatically deleted by the server core to avoid failure.
About 3 years ago, I ordered the fix of these errors from my programmer friend, but unfortunately, since then I have lost both his contacts and the correction itself.
Can you fix it for a fee? And I, and a very large number of people who want to play with this mod with friends, will be very grateful to you, I can pay for your work using pay pal, just tell me how much you want for your work.

Now I want to tell you exactly how we fixed this bug with the help of this programmer. A new block called Custom npc spawner has been added to the mod. This block was assigned an linked npc, the time of the npc's respawn after death, the distance in blocks at which the npc appears when the player is nearby, and the function of whether this block sees players through walls.
And we set the "Natural Disappearance" respawn mode for the linked NPC. Since with this method, the NPC as an entity disappears while the player is not in the chunk, and in their place is a block installed by the administrator, in addition to correcting the errors that I described above, we significantly optimize the server itself, since it does not need to constantly keep a bunch of inactive entities in the server memory.

(The server administrator assigns the linked npc to this block by right-clicking on it and selecting in the GUI that opens. Also in this GUI, the time of respawn, the distance to the player for spawn and the parameter responsible for detecting players through walls are prescribed.
This block will call this npc from under it - for example, if the NPC has a growth of 2 blocks, then we place the rebirth block 2 blocks above the ground. The block itself is invisible to players in survival mode, but visible to administrators in the creative. Also, the block has no collision and arrows and other projectiles can fly through it)

There is also an annoying bug: if there is too much information in the player's data (data on completed quests, read dialogues), then when he is killed and revived, the server is overloaded with the volume of the player's data file and freezes for half a second, which is terribly annoying. We fixed this bug by optimizing the player's death data file.
Thank you for reading, I really hope you can accept this order from me.
If it is convenient for you, then you can contact me in discord. My discord: wasteland4013
I apologize in advance for my English, it is not my native language.

[bug] UI creation of itemslot and subequent updated UI causing crash when new itemslot is clicked

If crashed, link to crash report (use a site such as pastebin):
paste.ee containing the player script required to reproduce.
https://paste.ee/p/5ujXl
Versions:

• Minecraft: 1.7.10
• Forge:
• CustomNPC+: 1.8.4 beta
  client crash in sp and client kicked from server in mp - I sent the same script to Hanad or Zaxar#2257 on discord to try and he had similar results.

24.05 15:40:25 [Server] INFO java.lang.IndexOutOfBoundsException: Index: 74, Size: 37
24.05 15:40:25 [Server] INFO at java.util.ArrayList.rangeCheck(ArrayList.java:659) ~[?:1.8.0_362]
24.05 15:40:25 [Server] INFO at java.util.ArrayList.get(ArrayList.java:435) ~[?:1.8.0_362]
24.05 15:40:25 [Server] INFO at noppes.npcs.containers.ContainerCustomGui.func_75144_a(ContainerCustomGui.java:111) ~[ContainerCustomGui.class:?]
24.05 15:40:25 [Server] INFO at net.minecraft.network.NetHandlerPlayServer.func_147351_a(NetHandlerPlayServer.java:2086) ~[nh.class:?]
24.05 15:40:25 [Server] INFO at net.minecraft.network.play.client.C0EPacketClickWindow.func_148833_a(SourceFile:32) ~[ix.class:?]
24.05 15:40:25 [Server] INFO at net.minecraft.network.play.client.C0EPacketClickWindow.func_148833_a(SourceFile:10) ~[ix.class:?]
24.05 15:40:25 [Server] INFO at net.minecraft.network.NetworkManager.func_74428_b(NetworkManager.java:245) ~[ej.class:?]
24.05 15:40:25 [Server] INFO at net.minecraft.network.NetworkSystem.func_151269_c(NetworkSystem.java:181) [nc.class:?]
24.05 15:40:25 [Server] INFO at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:1023) [MinecraftServer.class:?]
24.05 15:40:25 [Server] INFO at net.minecraft.server.dedicated.DedicatedServer.func_71190_q(DedicatedServer.java:431) [lt.class:?]
24.05 15:40:25 [Server] INFO at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:842) [MinecraftServer.class:?]
24.05 15:40:25 [Server] INFO at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:692) [MinecraftServer.class:?]
24.05 15:40:25 [Server] INFO at java.lang.Thread.run(Thread.java:750) [?:1.8.0_362]

[Bug] Multiple Items as condition + "Takes the items"=true + Quest Completed Text --> No reward given & only first item taken

Issue description:
There is a bug whenever a Quest has more then one item as condition, "takes the items" is set to "true", give another item as reward, and there is a text for "Quest Completed". --> The Quest takes only the first defined item, leaves the others and dont't give you the reward item.

Example

To complete the quest you need (NPC takes it on Quest completion):

• 1x Pickaxe
• 2x Grass Seeds

The reward;

• 2x Glow Stone Dust

What you really get:

• Nothing!

What the NPC really takes:

• Only the Pickaxe

If crashed, link to crash report (use a site such as pastebin):
None.

Versions:

• Minecraft: 1.7.10
• Forge: 10.13.4.1614
• CustomNPC+: 1.7.0

Can it be reproduced with just CustomNPC+? If not, list the other mods required to reproduce the issue.
No other mods needed to reproduce the issue.

Flans Mod Crash

Issue description:

I get this crash when inside a flans mod vehical and an npc kills me (aka the plane, etc). However, it crashes and only kills the plane. The npcs can kill flans vehicles without crashing but only if the player is not inside of one.

If crashed, link to crash report (use a site such as pastebin):

https://paste-bin.xyz/33893

Versions:

• Minecraft: 1.7.10
• Forge: latest
• CustomNPC+: 1.4.2

Can it be reproduced with just CustomNPC+? If not, list the other mods required to reproduce the issue.
Flans Mod is needed to reproduce the issue.

CustomNPC Plus conflicts with Tinkers' Construct tabs

Issue description:
CustomNPC Plus conflicts with Tinkers' Construct tabs. You only need to switch back and forth to repeat this error.
If crashed, link to crash report (use a site such as pastebin):

Versions:

• Minecraft: 1.7.10
• Forge: 10.13.4.1614
• CustomNPC+:
  
  Can it be reproduced with just CustomNPC+? If not, list the other mods required to reproduce the issue.
  Tinkers' Construct

the enchantment ID is this the same for Electroblobs wizardry.

when ever I try to put another mod on it crashes my game and it says that there are duplicate items. I have checked my mods folder and found no doubles of the same mods. but the crash report says that custom NPC+ enchantment ID is the same as one from Electroblobs Wizardry mod for 1.7.10

https://pastebin.com/UBxKxPc5

• Minecraft: 1.7.10
• Forge: 10.12.4.1614-1.7.10
• CustomNPC+:

Can it be reproduced with just CustomNPC+? If not, list the other mods required to reproduce the issue.

electroblobs wizardry mod version 1.1.6 for minecraft 1.7.10 is required.

NPC's keep crashing

So me and some friends have a server and whenever an npc drops an item or is killed it will crash our games I don't know if this is a common issue but it keeps happening to us and we have no idea why and when we updated to a newer version of the mod more issues showed up where the npcs whenever they would just fire something it would crash the game

World Lines not showing

Issue description:
If I setup World Lines for a NPC then they will not show up (not in chat and also not in a bubble). I expect them to show up either randomly or ordered with some seconds delay if I stand in the near of the NPC.

• I tested this on Version 1.8 without any mods, a clean install and a fresh new world.
• I tested this on Version 1.9 Beta 3 with all my mods and on my prod world.

If you want some logs, feel free, I attached theme here. They are from the instance where only CustomNPC+ is isntalled (and Waila, if im right).

Do I anthing wrong or are they just not working at the moment? I remember long time ago they shown. But to be fair, this can be at least one year ago, maybe more.

Would be really glad for help or a fix. Thank you in advance!

If crashed, link to crash report (use a site such as pastebin):
2023-05-04-3.log.gz
CustomNPCs-1.log
fml-client-3.log

Versions:

• Minecraft: 1.7.10
• Forge:
• CustomNPC+: 1.6-beta (up to currently 1.9 Beta 3)

Can it be reproduced with just CustomNPC+? If not, list the other mods required to reproduce the issue. Yes, it can be reproduce with just CusotmNPC+.

Mage staff

• CustomNPC-Plus-1.1**
• Minecraft: 1.7.10
• Forge:
• CustomNPC+:

strange bug. when using the magic staff, the mage crashes *

MODS
mcp - Minecraft Coder Pack - 9.05
FML - Forge Mod Loader - 7.10.99.99
Forge - Minecraft Forge - 10.13.4.1614
kimagine - KImagine - 0.2
ColorUtility - ColorUtility - 1.0.3
CodeChickenCore - CodeChicken Core - 1.0.7.48
NotEnoughItems - Not Enough Items - 1.0.5.120
Enchiridion - Enchiridion - 1.3
Enchiridion2 - Enchiridion 2 - 2.0.2a
BiomesOPlenty - Biomes O' Plenty - 2.1.0
customnpcs - CustomNpcs - 1.1
discordintegration - DiscordIntegration - 3.0.4
Baubles - Baubles - 1.0.1.10
Thaumcraft - Thaumcraft - 4.2.3.5
etfuturum - Et Futurum Requiem - 2.1.3
Morpheus - Morpheus - 1.7.10-1.6.21
profilehandler - Profile Handler - 1.0
rpi - Role-playing-items - 0.1
skinport - SkinPort - 1.7.10-v10d
soulsconverter - soulsconverter - 1.4-fix
soulscore - SoulsCore - 1.6
trade - Trade - 1.0.1
EventHelper - EventHelper - 1.7.10-1.13
attackdelay - Ariamis attack delay mod - Minecraft 1.7.10
ariamis - Ariamis expansion - 0.2
MineTweaker3 - MineTweaker 3 - 3.0.13
minefantasy2 - MineFantasyII - 2.8.14.8
mfhealthbar - mfhealthbar - 0.9.4
bookshelf_chest - BookshelfChest - 1.0
campfirebackport - Campfire Backport - ${version}
CarpentersBlocks - Carpenter's Blocks - 3.3.8.2_fix
examplemod - Example Mod - 1.0
damagetilt - Damage Tilt - 0.1.0
doorsoplenty - Doors o Plenty - 0.1
Emotes - Emotes - 1.0
GardenContainers - Garden Containers - 1.7.10-1.7.0
GardenCore - Garden Core - 1.7.10-1.7.0
GardenStuff - Garden Stuff - 1.7.10-1.7.0
GardenTrees - Garden Trees - 1.7.10-1.7.0
MCP_Wheel - MC+ Wheel - 1.1.2
MCP_Cart - MC+ Cart - 1.3.0
MCP_WoodenBucket - MC+ WoodenBucket - 1.2.0
MTRM - MineTweakerRecipeMaker - 1.0
modtweaker2 - Mod Tweaker 2 - 0.9.6
ariamisportal - Ariamis Portal - 0.7.3
tcinventoryscan - TC Inventory Scanning - 1.0.11
ta - ThaumcraftAriamis - 1.0
thaumcraftneiplugin - Thaumcraft NEI Plugin - @Version@
thaumicdyes - Thaumic Dyes - 1.10.1
infernalskycolor - Infernal Sky Color - 0.8
plonk - Plonk - 1.7.10-0.0.7
wizardry - Electroblob's Wizardry - 1.1.5
netherlicious - ?6Netherlicious - 2.7.1
antiqueatlas - Antique Atlas - 4.4.0
betterstorage - BetterStorage - 0.13.1.128
signposts - Sign-Posts - 1.2.1
climatecontrol - Climate Control - 0.8.1
RTG - Realistic Terrain Generation - 1.7.10-1.1.1.7
bspkrsCore - bspkrsCore - 6.16

CustomNPCs saves its data on EntityPlayer.writeToNBT(), this is wrong!

The method writeToNBT() from Entity is causing a lot of lag when there are lots of requests to write the entities nbt.

The lag is caused because CustomNPCs is writing its data on a File, on the Main thread and out of place. (CustomNPC's data should be saved on "worldSave" or something similar)

When someone retrieves the "NBTTagCompound" of a Player, it does not mean that this entity is being saved.

I think the proper way would be:

1- Save it every X minutes AND on player quit
2- Save it on World Save AND on player quit

https://github.com/KAMKEEL/CustomNPC-Plus/blob/master/src/main/java/noppes/npcs/controllers/PlayerDataController.java#L89-L104

FakePlayer Error

Issue description:
There is an error with some event invokers in noppes.npcs.ScriptPlayerEventHandler, for example with method public void invoke(EntityStruckByLightningEvent event).
When a sound is played for FakePlayer entity, the class cast exception occurs.
I've found this bug when tried to open a loot bag (LootBags-1.7.10-2.0.17 mod) with an Animation Tablet (ThaumicTinkerer-2.5-1.7.10-538)
The reason why it happens is that event.entity instanceof EntityPlayer does not grant you that event.entity will be instance of EntityPlayeMP (only then there will be no class cast exception here (IPlayer) NpcAPI.Instance().getIEntity(event.entity))
If crashed, link to crash report (use a site such as pastebin):
https://pastebin.com/tnXAQjE0
Versions:

• Minecraft: 1.7.10
• Forge: forge-1.7.10-10.13.4.1614-1.7.10
• CustomNPC+: last version
• ThaumicTinkerer-2.5-1.7.10-538
  The bug can be reproduced with mods, using fake players, for example Thaumic tinkerer
  Required mods for thaumic tinkerer are: Baubles, Thaumcraft, ThaumicTinkerer, LootBags

customnpc scripts don't work with graalvm enterprise edition

Issue description:
if i start a server using graalvm enterprise edition, all the scripts stop working

for example:

• event: damaged
• script: npc.say(event.getDamage());
• result:

Sun Jul 16 16:12:05 MSK 2023 tab 5:
javax.script.ScriptException: org.graalvm.polyglot.PolyglotException: TypeError: invokeMember (getDamage) on noppes.npcs.scripted.event.ScriptEventDamaged@4c2da842 failed due to: Unknown identifier: getDamage
	at com.oracle.truffle.js.scriptengine.GraalJSScriptEngine.toScriptException(GraalJSScriptEngine.java:483)
	at com.oracle.truffle.js.scriptengine.GraalJSScriptEngine.eval(GraalJSScriptEngine.java:460)
	at com.oracle.truffle.js.scriptengine.GraalJSScriptEngine.access$400(GraalJSScriptEngine.java:83)
	at com.oracle.truffle.js.scriptengine.GraalJSScriptEngine$10.eval(GraalJSScriptEngine.java:628)
	at noppes.npcs.controllers.ScriptContainer.run(ScriptContainer.java:98)
	at noppes.npcs.DataScript.callScript(DataScript.java:142)
	at noppes.npcs.DataScript.callScript(DataScript.java:128)
	at noppes.npcs.EventHooks.onNPCDamaged(EventHooks.java:169)
	at noppes.npcs.entity.EntityNPCInterface.func_70097_a(EntityNPCInterface.java:508)
	at net.minecraft.entity.player.EntityPlayer.func_71059_n(EntityPlayer.java:1399)
	at net.minecraft.network.NetHandlerPlayServer.func_147340_a(NetHandlerPlayServer.java:1622)
	at net.minecraft.network.play.client.C02PacketUseEntity.func_148833_a(SourceFile:55)
	at net.minecraft.network.play.client.C02PacketUseEntity.func_148833_a(SourceFile:10)
	at net.minecraft.network.NetworkManager.func_74428_b(NetworkManager.java:245)
	at net.minecraft.network.NetworkSystem.func_151269_c(NetworkSystem.java:181)
	at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:990)
	at net.minecraft.server.dedicated.DedicatedServer.func_71190_q(DedicatedServer.java:431)
	at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:808)
	at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:683)
	at java.lang.Thread.run(Thread.java:750)
Caused by: org.graalvm.polyglot.PolyglotException: TypeError: invokeMember (getDamage) on noppes.npcs.scripted.event.ScriptEventDamaged@4c2da842 failed due to: Unknown identifier: getDamage
	at <js>.:program(<eval>:1)
	at org.graalvm.polyglot.Context.eval(Context.java:379)
	at com.oracle.truffle.js.scriptengine.GraalJSScriptEngine.eval(GraalJSScriptEngine.java:458)
	... 18 more

Versions:

• Minecraft: 1.7.10 and 1.12.2 (i haven't tried others)
• Forge:
• CustomNPC+: latest from curseforge (1.8.6), but i think, it actually for all versions cnpc

A null pointer exception (in script) when calling customGuiSlot(event) manually.

Issue description:

If crashed, link to crash report (use a site such as pastebin):
Sun Jun 11 14:10:51 BST 2023 tab 2:
java.lang.NullPointerException
at noppes.npcs.NoppesStringUtils.formatText(NoppesStringUtils.java:33)
at noppes.npcs.scripted.entity.ScriptPlayer.sendMessage(ScriptPlayer.java:342)
at jdk.nashorn.internal.scripts.Script$Recompilation$502$38A$^eval_.customGuiSlotClicked(:35)
at jdk.nashorn.internal.runtime.ScriptFunctionData.invoke(ScriptFunctionData.java:638)
at jdk.nashorn.internal.runtime.ScriptFunction.invoke(ScriptFunction.java:229)
at jdk.nashorn.internal.runtime.ScriptRuntime.apply(ScriptRuntime.java:387)
at jdk.nashorn.api.scripting.ScriptObjectMirror.callMember(ScriptObjectMirror.java:192)
at jdk.nashorn.api.scripting.NashornScriptEngine.invokeImpl(NashornScriptEngine.java:381)
at jdk.nashorn.api.scripting.NashornScriptEngine.invokeFunction(NashornScriptEngine.java:187)
at noppes.npcs.controllers.ScriptContainer.run(ScriptContainer.java:197)
at noppes.npcs.controllers.ScriptContainer.run(ScriptContainer.java:146)
at noppes.npcs.controllers.data.PlayerDataScript.callScript(PlayerDataScript.java:89)
at noppes.npcs.controllers.CustomGuiController.onSlotClick(CustomGuiController.jav
a:95)
at noppes.npcs.EventHooks.onCustomGuiSlotClicked(EventHooks.java:567)
at noppes.npcs.containers.ContainerCustomGui.func_75144_a(ContainerCustomGui.java:122)
at net.minecraft.network.NetHandlerPlayServer.func_147351_a(NetHandlerPlayServer.java:883)
at net.minecraft.network.play.client.C0EPacketClickWindow.func_148833_a(SourceFile:32)
at net.minecraft.network.play.client.C0EPacketClickWindow.func_148833_a(SourceFile:10)
at net.minecraft.network.NetworkManager.func_74428_b(NetworkManager.java:212)
at net.minecraft.network.NetworkSystem.func_151269_c(NetworkSystem.java:165)
at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:659)
at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:547)
at net.minecraft.server.integrated.IntegratedServer.func_71217_p(IntegratedServer.java:111)
at fastcraft.u.a(F:289)
at fastcraft.H.aq(F:36)
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:396)
at net.minecraft.server.MinecraftServer$2.run(MinecraftServer.java:685)

Versions: 1.8.5

• Minecraft: 1.7.10
• Forge: 10.13.4.1558
• CustomNPC+: 1.8.5

Can it be reproduced with just CustomNPC+? If not, list the other mods required to reproduce the issue.

2023-06-11.14-10-43.mov

a:95)

Mobs Won't Spawn

There seems to be an issue with mob spawning. I've tried messing with it and nothing makes it work, but before I switched to Custom NPC Plus I had several mobs that would spawn in various biomes, and now they've stopped spawning altogether. I've tried redoing it and it doesn't seem to work under any setting unless there's something I'm missing? I've also noticed some NPC's won't even spawn when using the mob-cloner wand, and give this error code:

though I did try to set a spawn for an NPC that didn't give that error when I tried to manually spawn it as well, and that wouldn't naturally spawn, either.

• Minecraft: 1.7.10
• Forge: 10.13.4.1614.1.7.10
• CustomNPC+: CustomNPC-Plus-1.7

Linked npc lag

Issue description:
We found a bug that causes overall lag when operating linked npc to npcwand or Mobcopywand, so we report this.
If crashed, link to crash report (use a site such as pastebin):
https://youtu.be/t0FmnFTPBuk
Versions:

• Minecraft: 1.7.10
• Forge: 1.7.10-Forge10.13.4.1614-1.7.10
• CustomNPC+: 1.5.1 beta

Can it be reproduced with just CustomNPC+? If not, list the other mods required to reproduce the issue.

Custom NPC aggro range not working as it should

I don't know if its a bug or not but when I setting up an NPC to use a range attack and setting the range attack at least 30 blocks and visibility to 40 when they are seeing the target, they are spinning around, go little bit forward and back and dont attack the target, but when the target is really close to them, then they are decide to attack, i have checked everything, vision, range attack everything and its correct

Builder Block

Your mod greatly improves the build of my server. I've been pulling the life out of custom NPC scripts for a year now, and honestly I'm very tired of writing a script for building construction. How about adding a builder block as in the new versions ?

Event Script related server crash [bug]

Issue description:
I was trying event scripting for the first time, nothing was happening in the melee attack event - I placed a comment inside and then immediately crashed. in singleplayer the melee attack event doesn't seem to be working.
If crashed, link to crash report (use a site such as pastebin):

Versions:

• Minecraft: 1.7.10
• Forge: 10.13.1.1558
• CustomNPC+: 1.8.1
  the important bit -
  |
  V
  crash-2023-05-11_01.08.12-server.txt

Crash with Fossils and Archeology/Aether/Custom Main Menu

Issue description: If your modpack has any of the 3 mods listed in the title or has all 3 like mine the mods will NOT launch and the the pack will crash

If crashed, link to crash report (use a site such as pastebin): https://pastebin.com/21UCncpN

Versions:

• Minecraft: 1.7.10
• Forge: 10.13.1614
• CustomNPC+: CustomNPC-Plus-1.7-nomixin

Can it be reproduced with just CustomNPC+? If not, list the other mods required to reproduce the issue.
aether-1.7.10-1.6
Fossils-and-Archeology-Revival-Mod-1.7.10
CustomMainMenu-MC1.7.10-1.9.2

Setting FontType has no effect

Issue description:
Setting FontType in config file has no effect
Versions:

• Minecraft: 1.7.10
• Forge: 10.13.4.1614
• CustomNPC+: 1.5.4

API discrepancy

Issue description:
API is missing the new add custom gui slot function.

gui.addItemSlot(int id, int x, int y);

[bug] offset with event.player.getLookingAtBlock();

Issue description:
There is a noticable offset from where raycast should be fired and where it hits.
If crashed, link to crash report (use a site such as pastebin):

Versions:

• Minecraft: 1.7.10
• Forge: 10.13.4.1558
• CustomNPC+: 1.8.3

Can it be reproduced with just CustomNPC+? If not, list the other mods required to reproduce the issue.

Invalid signature exception on launch

hey I just cloned the project according to the instructions on the GitHub readme.
however immediately after starting I hit runClient and get an exception that reads:
Caused by: java.lang.SecurityException: Invalid signature file digest for Manifest main attributes

the output reads like this:

`18:41:11: Executing 'runClient'...

Found AccessTransformer in main resources: customnpcs_at.cfg
Path: /Users/jacobmaynardvesely/IdeaProjects/CustomNPCplus
:compileApiJavaNote: SpongePowered MIXIN Annotation Processor Version=0.7.11
Note: ObfuscationServiceMCP supports type: "searge"
Note: ObfuscationServiceMCP supports type: "notch"
Note: /Users/jacobmaynardvesely/IdeaProjects/CustomNPCplus/src/api/java/net/minecraft/util/math/IntHashMap.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:processApiResources NO-SOURCE
:apiClasses
:sourceMainJava
:compileJavaNote: SpongePowered MIXIN Annotation Processor Version=0.8
Note: ObfuscationServiceMCP supports type: "searge"
Note: ObfuscationServiceMCP supports type: "notch"
Note: Loading searge mappings from /Users/jacobmaynardvesely/.gradle/caches/minecraft/net/minecraftforge/forge/1.7.10-10.13.4.1614-1.7.10/srgs/mcp-srg.srg
Note: Writing refmap to /Users/jacobmaynardvesely/IdeaProjects/CustomNPCplus/build/tmp/compileJava/customnpcs.refmap.json
Note: Writing refmap to /Users/jacobmaynardvesely/IdeaProjects/CustomNPCplus/build/tmp/compileJava/customnpcs.refmap.json
Note: Writing searge output SRGs to /Users/jacobmaynardvesely/IdeaProjects/CustomNPCplus/build/tmp/reobf/mixins.srg
Note: Writing refmap to /Users/jacobmaynardvesely/IdeaProjects/CustomNPCplus/build/tmp/compileJava/customnpcs.refmap.json
Note: Writing refmap to /Users/jacobmaynardvesely/IdeaProjects/CustomNPCplus/build/tmp/compileJava/customnpcs.refmap.json
Note: Writing searge output SRGs to /Users/jacobmaynardvesely/IdeaProjects/CustomNPCplus/build/tmp/reobf/mixins.srg
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:processResources
:classes
:jar
:getVersionJsonIndex UP-TO-DATE
:getVersionJson UP-TO-DATE
:extractUserDev UP-TO-DATE
:extractNatives UP-TO-DATE
:getAssetsIndex UP-TO-DATE
:getAssets UP-TO-DATE
:makeStart SKIPPED
:runClient
[18:43:40] [main/INFO] [GradleStart]: Extra: []
Exception in thread "main" java.lang.reflect.InvocationTargetException
at sun.reflect.GeneratedMethodAccessor1.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at net.minecraftforge.gradle.GradleStartCommon.searchCoremods(Unknown Source)
at net.minecraftforge.gradle.GradleStartCommon.launch(Unknown Source)
at GradleStart.main(Unknown Source)
Caused by: java.lang.SecurityException: Invalid signature file digest for Manifest main attributes
at sun.security.util.SignatureFileVerifier.processImpl(SignatureFileVerifier.java:330)
at sun.security.util.SignatureFileVerifier.process(SignatureFileVerifier.java:263)
at java.util.jar.JarVerifier.processEntry(JarVerifier.java:275)
at java.util.jar.JarVerifier.update(JarVerifier.java:230)
at java.util.jar.JarFile.initializeVerifier(JarFile.java:383)
at java.util.jar.JarFile.getInputStream(JarFile.java:450)
at cpw.mods.fml.common.asm.transformers.ModAccessTransformer$JarByteSource.openStream(ModAccessTransformer.java:69)
at com.google.common.io.ByteSource$AsCharSource.openStream(ByteSource.java:435)
at com.google.common.io.CharSource.read(CharSource.java:162)
at cpw.mods.fml.common.asm.transformers.ModAccessTransformer.addJar(ModAccessTransformer.java:52)
... 6 more
:runClient FAILED

FAILURE: Build failed with an exception.

• What went wrong:
  Execution failed for task ':runClient'.

Process 'command '/Library/Java/JavaVirtualMachines/jdk1.8.0_144.jdk/Contents/Home/bin/java'' finished with non-zero exit value 1

• Try:
  Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

• Get more help at https://help.gradle.org

BUILD FAILED in 2m 28s
12 actionable tasks: 6 executed, 6 up-to-date
18:43:41: Execution finished 'runClient'.`

solved

¿?

Sizing up overlays clips through armors

Issue description:
Sizing up over
If crashed, link to crash report (use a site such as pastebin):
no crash
Versions:

• Minecraft: 1.7.10
• Forge: the usual
• CustomNPC+: 1.9.1
  

Can it be reproduced with just CustomNPC+? If not, list the other mods required to reproduce the issue.

[Bug] "Night" feature: NPCs don't update until interaction by player

Issue description:

To reproduce...

1. ...simply place an NPC, goto Advanced->Night, enable Editing Mode.
2. Then load day data, goto Apperience and set "Visible" to false. (it doesn't work also with others, but hey, this is simple to describe)
3. Then load the night data, goto Apperience and ensure "Visible" is true.
4. Disable the Editing Mode and close the NPC editor window.
5. Now toogle between day and night using /time set night and /time set day. You see, the NPC wont show or hide itself.
6. Now interact with that NPC by right-clicking it with an empty hand. You see, it now starts to update. (Side node: In my prod world I changed the position, but it doesn't update the position and animation isntantly, it needs another few seconds and/or interactions.)

If crashed, link to crash report (use a site such as pastebin):
None.

Versions:

• Minecraft: 1.7.10
• Forge: 10.13.4.1614
• CustomNPC+: 1.7.0

Can it be reproduced with just CustomNPC+? If not, list the other mods required to reproduce the issue.
No other mods needed to reproduce the issue.

Crash upon server join

Issue description:
crash upon join
If crashed, link to crash report (use a site such as pastebin):

Versions:

• Minecraft: 1.7.10
• Forge: 10.13.4.1558
• CustomNPC+: 1.9 experim

important bit :

[B#773] [06:34:03] [Client thread/ERROR]: 1: ASM: noppes.npcs.client.PacketHandlerClient@3d6b483d onPacketData(Lcpw/mods/fml/common/network/FMLNetworkEvent$ClientCustomPacketEvent;)V
[B#773] [06:34:03] [Client thread/ERROR]: NetworkEventFiringHandler exception
[B#773] java.lang.NullPointerException
[B#773] at noppes.npcs.controllers.data.PlayerQuestData.loadNBTData(PlayerQuestData.java:60) ~[PlayerQuestData.class:?]
[B#773] at noppes.npcs.controllers.data.PlayerData.setNBT(PlayerData.java:85) ~[PlayerData.class:?]
[B#773] at noppes.npcs.client.PacketHandlerClient.client(PacketHandlerClient.java:114) ~[PacketHandlerClient.class:?]
[B#773] at noppes.npcs.client.PacketHandlerClient.onPacketData(PacketHandlerClient.java:53) ~[PacketHandlerClient.class:?]
[B#773] at cpw.mods.fml.common.eventhandler.ASMEventHandler_279_PacketHandlerClient_onPacketData_ClientCustomPacketEvent.invoke(.dynamic) ~[?:?]
[B#773] at cpw.mods.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:54) ~[ASMEventHandler.class:?]
[B#773] at cpw.mods.fml.common.eventhandler.EventBus.post(EventBus.java:140) ~[EventBus.class:?]
[B#773] at cpw.mods.fml.common.network.FMLEventChannel.fireRead(FMLEventChannel.java:103) ~[FMLEventChannel.class:?]
[B#773] at cpw.mods.fml.common.network.NetworkEventFiringHandler.channelRead0(NetworkEventFiringHandler.java:30) ~[NetworkEventFiringHandler.class:?]
[B#773] at cpw.mods.fml.common.network.NetworkEventFiringHandler.channelRead0(NetworkEventFiringHandler.java:18) ~[NetworkEventFiringHandler.class:?]
[B#773] at io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:98) ~[SimpleChannelInboundHandler.class:?]
[B#773] at io.netty.channel.DefaultChannelHandlerContext.invokeChannelRead(DefaultChannelHandlerContext.java:337) [DefaultChannelHandlerContext.class:?]
[B#773] at io.netty.channel.DefaultChannelHandlerContext.fireChannelRead(DefaultChannelHandlerContext.java:323) [DefaultChannelHandlerContext.class:?]
[B#773] at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:785) [DefaultChannelPipeline.class:?]
[B#773] at io.netty.channel.embedded.EmbeddedChannel.writeInbound(EmbeddedChannel.java:169) [EmbeddedChannel.class:?]
[B#773] at cpw.mods.fml.common.network.internal.FMLProxyPacket.func_148833_a(FMLProxyPacket.java:77) [FMLProxyPacket.class:?]
[B#773] at net.minecraft.network.NetworkManager.func_74428_b(NetworkManager.java:212) [ej.class:?]
[B#773] at net.minecraft.client.multiplayer.GuiConnecting.func_73876_c(SourceFile:78) [bcx.class:?]
[B#773] at net.minecraft.client.Minecraft.func_71407_l(Unknown Source) [bao.class:?]
[B#773] at net.minecraft.client.Minecraft.func_71411_J(Unknown Source) [bao.class:?]
[B#773] at net.minecraft.client.Minecraft.func_99999_d(Unknown Source) [bao.class:?]
[B#773] at net.minecraft.client.main.Main.main(SourceFile:148) [Main.class:?]
[B#773] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_51]
[B#773] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_51]
[B#773] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_51]
[B#773] at java.lang.reflect.Method.invoke(Method.java:497) ~[?:1.8.0_51]
[B#773] at net.minecraft.launchwrapper.Launch.launch(Launch.java:135) [launchwrapper-1.12.jar:?]
[B#773] at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.12.jar:?]
[B#773] [06:34:03] [Client thread/ERROR]: There was a critical exception handling a packet on channel CustomNPCs
[B#773] java.lang.NullPointerException
[B#773] at noppes.npcs.controllers.data.PlayerQuestData.loadNBTData(PlayerQuestData.java:60) ~[PlayerQuestData.class:?]
[B#773] at noppes.npcs.controllers.data.PlayerData.setNBT(PlayerData.java:85) ~[PlayerData.class:?]
[B#773] at noppes.npcs.client.PacketHandlerClient.client(PacketHandlerClient.java:114) ~[PacketHandlerClient.class:?]
[B#773] at noppes.npcs.client.PacketHandlerClient.onPacketData(PacketHandlerClient.java:53) ~[PacketHandlerClient.class:?]
[B#773] at cpw.mods.fml.common.eventhandler.ASMEventHandler_279_PacketHandlerClient_onPacketData_ClientCustomPacketEvent.invoke(.dynamic) ~[?:?]
[B#773] at cpw.mods.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:54) ~[ASMEventHandler.class:?]
[B#773] at cpw.mods.fml.common.eventhandler.EventBus.post(EventBus.java:140) ~[EventBus.class:?]
[B#773] at cpw.mods.fml.common.network.FMLEventChannel.fireRead(FMLEventChannel.java:103) ~[FMLEventChannel.class:?]
[B#773] at cpw.mods.fml.common.network.NetworkEventFiringHandler.channelRead0(NetworkEventFiringHandler.java:30) ~[NetworkEventFiringHandler.class:?]
[B#773] at cpw.mods.fml.common.network.NetworkEventFiringHandler.channelRead0(NetworkEventFiringHandler.java:18) ~[NetworkEventFiringHandler.class:?]
[B#773] at io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:98) ~[SimpleChannelInboundHandler.class:?]
[B#773] at io.netty.channel.DefaultChannelHandlerContext.invokeChannelRead(DefaultChannelHandlerContext.java:337) ~[DefaultChannelHandlerContext.class:?]
[B#773] at io.netty.channel.DefaultChannelHandlerContext.fireChannelRead(DefaultChannelHandlerContext.java:323) ~[DefaultChannelHandlerContext.class:?]
[B#773] at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:785) ~[DefaultChannelPipeline.class:?]
[B#773] at io.netty.channel.embedded.EmbeddedChannel.writeInbound(EmbeddedChannel.java:169) ~[EmbeddedChannel.class:?]
[B#773] at cpw.mods.fml.common.network.internal.FMLProxyPacket.func_148833_a(FMLProxyPacket.java:77) [FMLProxyPacket.class:?]
[B#773] at net.minecraft.network.NetworkManager.func_74428_b(NetworkManager.java:212) [ej.class:?]
[B#773] at net.minecraft.client.multiplayer.GuiConnecting.func_73876_c(SourceFile:78) [bcx.class:?]
[B#773] at net.minecraft.client.Minecraft.func_71407_l(Unknown Source) [bao.class:?]
[B#773] at net.minecraft.client.Minecraft.func_71411_J(Unknown Source) [bao.class:?]
[B#773] at net.minecraft.client.Minecraft.func_99999_d(Unknown Source) [bao.class:?]
[B#773] at net.minecraft.client.main.Main.main(SourceFile:148) [Main.class:?]
[B#773] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_51]
[B#773] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_51]
[B#773] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_51]
[B#773] at java.lang.reflect.Method.invoke(Method.java:497) ~[?:1.8.0_51]
[B#773] at net.minecraft.launchwrapper.Launch.launch(Launch.java:135) [launchwrapper-1.12.jar:?]
[B#773] at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.12.jar:?]
techniclauncher_2023-05-17.log

Projectile Trails not working

Issue description:
When setting a trail for a projectile (like redstone or smoke) it doesn't show the particles
If crashed, link to crash report (use a site such as pastebin):

Versions:

• Minecraft: 1.7.10
• Forge:
• CustomNPC+:

Can it be reproduced with just CustomNPC+? If not, list the other mods required to reproduce the issue.

Waypoint block problems in server game

We are getting a server crash for the game when two players are in range of the "customnpcs:npcWaypoint" block when it is for a quest.
If one person enters the zone of operation of this block with the right quest for the trigger of this block, everything happens in the order of things. But if two players fall into this zone to trigger this block, the server gets a crash.

Crash click

• Minecraft: 1.7.10
• Server core: KCaldron
• CustomNPC+: v1.6-beta2
  I do not deny the possibility of a problem with another mod, however I do not see a single hint in the crash log to even suggest which mod caused this error...

Conflict with InfiniteInvo and NPC trade window

Issue description:
Game crashes when you, have InfiniteInvo installed, and you try to scroll down through your inventory (with extra inventory slots added by InfiniteInvo) while in the NPC trader GUI.

If crashed, link to crash report (use a site such as pastebin):
https://pastebin.com/HiJ4LvQy

Versions:

• Minecraft: 1.7.10
• Forge: 10.13.4.1614
• CustomNPC+: 1.6.1

Can it be reproduced with just CustomNPC+? If not, list the other mods required to reproduce the issue.
InfiniteInvo for 1.7.10

CNPCs Knockback Resistance Issue + Sprint Attack and Item Knockback Enchantment

Issue description:

Hi. There is knockback resistance attribute on NPC's stats screen, that just not working for attacks while sprinting. So, npc's gets knocked back even in you managed to change this value on npc's json file. The problem also happens, when your item has knockback enchantment.

Versions:

Minecraft: 1.7.10
Forge: 1.7.10-10.13.4.1614
CustomNPC+: literally any version
To reproduce this issue you need CNPC+

Video demonstation:

https://youtu.be/9VHcuD3sKOg

Ticking entity crashed

Issue description:
Crash when using Custom Npcs, then I tried using CustomNPC+, still the same.
If crashed, link to crash report (use a site such as pastebin):
https://api.mclo.gs/1/raw/YeKrmCd
Versions:

• Minecraft: 1.7.10
• Forge: 10.13.4.1614
• CustomNPC+: 1.8.6

Can it be reproduced with just CustomNPC+? If not, list the other mods required to reproduce the issue.

Accessing Huge files/Lots of files in the CNPC Playerdata freezes / crashes server

Opening huge playerdata quest json freezes server for a while.

Basically server's hangs for a while if a player with, lets say, 155kb+ of data JOINS server.
We have some servers where we use a lot of Customnpcs, there are lots of quests, dialogs and (not anymore, we learn that's not a good idea specially because of the file's size) item-givers npcs.

This is perfectly fine on 1.12, i believe its because of the Buffer thing.

Also, the buffer thing fixes some critical issues, like crashing the server if you try opening your playerdata thru your npc wand and it has lots of files or try to set/read/complete dialog/quest thru noppes command and has lots of files... Let's say 4000+ files you can already see what i'm talking about...

• Minecraft: 1.7.10
• Forge 10.13.4.1614:
• CustomNPCs_1.7.10d(29oct17):

Disabling items or blocks causes a crash.

Issue description:
See title.

If crashed, link to crash report (use a site such as pastebin):
https://pastebin.com/rDLwYvKH

Versions:
Crash reports usually come with a modlist in them. Pastebin link has what you need.

Can it be reproduced with just CustomNPC+? If not, list the other mods required to reproduce the issue.
Yes. CustomNPC and this fork don't need other mods. Again, see the Pastebin for the modlist.