Comments (2)
So I gave this a go today. It didn't go well. You cannot get the full file contents using Github v3 APIs due to CORS 😢
- Follow
download_url
to get file content - This barfs with:
Fetch API cannot load https://github.com/illicitonion/testrepo/raw/f4d96cf91157db83a055b8ec0e3dbaf6777f42de/README.md. The 'Access-Control-Allow-Origin' header has a value 'https://render.githubusercontent.com' that is not equal to the supplied origin. Origin 'http://localhost:8080' is therefore not allowed access. Have the server send the header with a valid value, or, if an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled.
We can't even use JSONP because that only works on api.github.com
:/ other people have got around this by basically having a proxy. Very frustrating... http://stackoverflow.com/questions/24895891/loading-a-readme-from-github
from github-pull-review.
Blocked until we can find a way to do this (may involve gitrust) - ping @illicitonion
from github-pull-review.
Related Issues (20)
- Comment line is wrong when viewing non BASE-HEAD diffs HOT 1
- `/list` should show mentioned/involved_with
- Clicking on a line number should draw focus to the new comment box
- Annotate references to PRs with their status
- Action todo state should actually be tri-state HOT 1
- `pre` blocks overflow
- Store system HOT 1
- Sort out list / auth pages HOT 1
- Report travis/similar results on Merge page
- File moves look weird in diffs page HOT 1
- PR with only comments from the author should be "Awaiting review" not "Reviewed"
- Put PR number and repo in title
- Show commit comments HOT 2
- Diff parser breaks for submodule updates
- Merge pull request commit message repeats itself
- Add LGTM button to pull requests
- Toggle button to make all diffs in a PR be unified rather than split.
- Overview page incorrectly says "awaiting your response"
- Show a ruler in diffs
- Comments on moved files fail with 422 Unprocessable Entity
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from github-pull-review.