GithubHelp home page GithubHelp logo

Done markers about github-pull-review HOT 2 OPEN

kegsay avatar kegsay commented on June 12, 2024
Done markers

from github-pull-review.

Comments (2)

kegsay avatar kegsay commented on June 12, 2024

Structure:

class Action {
  Comments[] comments; // line comments or overview comments linked via comment ID URLs somewhere in the body
  boolean isDone; // true if last comment is "Done."
  string owner; // person who made the original comment
}

Processing the block of comments in a PR to actions:

  • Create new Action for each set of line comments on the same line.
  • Create new Action for each set of overview comments which start "Needs action:" and are linked via comment ID urls somewhere in the body.

from github-pull-review.

kegsay avatar kegsay commented on June 12, 2024

Good progress has been made on this but it's still not done (hurrhurr). Need tick box for "Done?" and "Actionable?" on overview comments.

from github-pull-review.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.