kids-first / kf-portal-etl-task-service Goto Github PK

currently, KPETS prefixes the incomming token with Bearer. This is not correct, it should just use the Authorization field as is.

We need to remote the mention of the "All rights reserved" in the copyright in the header of every file. We will need the authorization of the copyright owner, OICR, in order to do so. It's not true that all rights are reserved. Some are, but some aren't, and they are detailed in the license we use. This mention of "All rights reserved" interferes with the terms of the open source license.

Example: https://github.com/kids-first/kf-portal-etl-task-service/blob/master/src/test/java/io/kf/coordinator/ETLCoordinatorTaskMainTests.java#L2

We should probably also add "Centre de recherche du CHU Sainte-Justine" as a new co-owner of the copyright, for their contributions.

Sometimes, the spark in the kf-etl docker container errors out, but does not exist the container. there should be a time out or someway to detect that spark errored out

When a user does a release, we should be able to find out who triggered a release by analyzing the log files. We need an easy way of tracking users without doing too much archaeology.

Technical notes

Taskservice: medium between release coordinator and the ETL portal of KF. Triggers the recuperation of studies towards ETL.

the task service should be able to request its own JWT and use that when making authorized requests to rollcall and the coordinator. This would mean the task service would have its own credentials when asking for a jwt from ego, and these credentials need to be stored in vault. In addition, rollcall has to be aware of the shape of the in-comming jwt.

Release coordinator does not sent ego token anymore. Instead, it send an auth0 token. Release coordinator use a Client Credential Flow. In order to be valid, JWT token must respect this clains :

• iss : (always https://kids-first.auth0.com/)
• aud : depends on environment (i.e : https://kf-release-coord-qa.kidsfirstdrc.org)
• gty : client-credentials

This must be done in ETL Task service and Rollcall

Have discussion and come out with accurate and precise diagram of data flow.