koenari / himbeertoniraidtool Goto Github PK

Currently there are multiple systems for this and they are not friendly to use

• Make central async task management
• Remove AsyncTaskWithUiResult and use new system
• Add posibility to have results in Ui
  Some notes / thoughts:
  Organize Plugin into modules liek Lootmaster taht inherit IHrtModule and provide a way to give visual feedback to the user
  make a plugin global interface to handle all async tasks (with onSuccess and onFailure) and return a feedback on completion to calling module

Hey,

I just tried to simulate loot rolls for P5S and the default rules don't seem to apply correctly. In this instance, it kept trying to give a character the raid necklace that didn't need it despite another character needing it (due to BiS > Upgrade rule).

To reproduce, try the following setup:

In this case, LM does not seem to honor the BiS>Upgrade rule at all for the necklace, despite DNC needing it and RDM not needing it.

Current plan:

• have a copy inside the plugin as backup
• load data from web address (maybe json)
• use online data if available -> else fallback to local

Clean up code not necessary for current functionality
Caution: Will drop support for configuration/data prior to (Version 0.5.1)

• Remove old Job definitions
• Remove group data from configuration
• Remove XivAPI (#28)
• Remove own UpdateGear code
• Remove old race code
• Remove hard-coded BiS remnants

List of potential features. Documented publicly, for everyone to quickly comment ideas

• #114
• Automatically open loot distribution when loot chests are opened
• Integration with games Lootmaster system
• Order jobs in Solo/Detailed view
• #132

Add new Items

• New raid + corresponding Item Levels
• Boss drops preliminary
• "Currency" conversion
• Item container contents
• Check if item level difference stays 10 betwenn iLvl tiers

Shortcommings of current system (marked = solved):

• relies on item name and is dependent on english client
• some items are not detected correctly (635 SCH weapon for example)
• needs manual work on game updates
• can become inconsistent with other curated data

Add a system to keep track of currencies and items that can be used to obtain raid gear. So that for example loot distribution can take into account if a player has enough books to buy the missing item or even if a missing tomestone gear for augmentation can be bought this week or if augmentation item should go to someone else.

Keep track of characters globally and use references in raid groups

• Characters identified by Name + home world
  See Pull rquest 15

Fixes following issues:

1. Ui is nearly unreadable when playing on for example a 4K TV
2. Some elemnts don't fit in the windows whaen using scaling

Note: Seems to be only affected by dalamuds "Global Font Scale"

The "Update Gear" button on "Solo" tab behaves inconsistently. For me it does nothing. As in, the "Examine" window doesn't open, gear does not get updated and no error message appears anywhere in the game or in the logs. Manually opening "Examine" window before clicking the button didn't do anything either.
For a friend of mine, it had partial success when they pressed the button with "Examine" window opened for their character and it did update equipped gear. Didn't do anything before that though.

Currently, if comparing to a gear/BiS list, an HQ crafted item from an Etro list is seen as an NQ item, which prevents correct matching.

Example:

Currently equipped: Diadochos Headband of Fending (HQ), DH+36/DH+36/DH+36/DH+12/DH+12
Etro list: Diadochos Headband of Fending (HQ), DH+36/DH+36/DH+36/DH+12/DH+12
Lootmaster shows from Etro list: Diadochos Headband of Fending, DH+36/DH+36/DH+36/DH+12/DH+12

These should match, but because it's importing the HQ item from Etro as NQ, it fails to match.

One of the current possible loot rules is DPS > Tank > Healer but the role priority can't be changed.

Our static does DPS > Healer > Tank and then just rolls. It would be a nice feature to be able to customize the role priority to fit your groups preference.

Test if all these changes only affect CuratedData
Add following

• RaidTier for Alliance Raid
• Items to SourceList
  • Alliance Raid Items
  • 590 Crafted

Target for GearRefresh is not necersarily the same as cahracter examined.
Name and Homeworld need to be extracted from Examine Window
Needs some reverse Engineering of FFXIV Client

• Create a connector for Lodestone
• Revamp update gear button to give acces to in-game or online update
• Incorporate NetStone

• Add state/phases (Select lott+groupp -> Start Evaluation -> Distribute Gear)
• Add Guaranteed Loot (Books)
• #81

Possibility to have for example to casters insted of 2 melees in a group
Potentially just make every postions role selectable
Suggested by Aêlle

Any way to be able to assign gear that people are wearing manually from a drop-down or list or something without relying on something like etro or the game or lodestone? It can just be batches of raid gear instead of needing to accommodate every single piece of gear. Alternatively, there can be an option to have assigned gear be also from etro as well, so the raid leader doesn't need everyone around in order to set it up and etc.

The LootMaster window won't open with /lootmaster or /lm chat command when using the "Loot Master" plugin by Aida Enna

https://github.com/Aida-Enna/XIVPlugins/tree/main/LootMaster

even after deactivating this plugin. It uses both same commands

It works when I start the game with deactivated Loot Master plugin, but as soon as both plugins are active I can't use the RaidTool-LootMaster

I don't know if this is some kind of bug or conflict, maybe changing the chat command would be enough to solve this.

the Plugin shows the wrong iLVL for my Warrior and Gunbreaker.
This is because the game uses the weapon twice in the average ilvl calculation for everything that doesnt have an offhand (so everything except paladins for combat jobs), and the plugin probabely only uses it once.

• For any purpose where the raidgroup is not available Role of MainJob is the better choice
• Player objects should start getting unique identifiers not dependent on the group

Having a central copy of GearSets for all maintained characters to share

• Needs Addition of internal unique ID for non-etro sets

Hello,

I have a problem with the plugin and it seems that the database/group setup has been deleted/no longer works since the 6.55 patch. Thanks to the "Just Backup" plugin, I still have the data on my computer, but I can't import it. Can I import the data, or is it only possible to re-enter all the data? I like to use this plugin, especially when questions arise about the lot when clearing or re-clearing content.

If needed i may supply you with the files.

If you got any feedback for improvements on the interface leave them here as a comment. Until I worked out a feedback structure this issue should work. Thank you

Currently tomestone upgrades are all showing as BiS, even when no gear is detected as available.

Above I have a simulated scenario of 2 rings dropping from p5s. Loot rules are: DPS > Healer > Tank and then rolling.

1. The loot results return that Zuuby won over Wowisdead on both rings. In a real world scenario 2 rings wont go to the same player as they can only equip 1 of them at a time anyway.

2. On top of that both Zuuby and Wowisdead already have the raid ring. The people who should be getting the ring according to the loot rules I set up would be: Mai > Devoras > Marauder.

My suspicion is that the plugin can't see the difference between a raid and tome piece of equipment. With that in mind in this simulated scenario it does makes sense that both Zuuby and Wowisdead were at the top of the loot results as both of them are missing their 630 tome rings.

I don't know how the tome gear upgrade item drop is affected as I haven't tested that.

• Add rate limiting to EtroConnector
• Keep track of last time sets were checked
• Fetch "outdatet" sets on startrup
• Have frequency of updates be configurable

/lootmaster is a command used in another plugin called Loot Master. When both plugins are loaded, the last one that was loaded overrides the command for the other.

I'm going to leave this same feedback for Aida, but thought it was worth mentioning because it can be difficult to troubleshoot or understand why you're not getting the window you expect since there aren't any warnings/errors indicating the command overrode another's.

Update gear by examining does not seem to be working in group mode. I have tried using it on myself and it is not functioning - it opens the examine window in game, but does not update the gear.

Hi. I started getting this issue several weeks ago, and the 6.2 update didn't change it. I tried re-installing the plugin, manually removing all local files for a "clean" run, yet every time I try to add myself under the Solo tab the plugin immediately crashes and then won't reopen. I've attached the screenshot and the relevant log

HimbCrash.txt

• Add fields to player edit

I have 2 members of my static that when I try and edit their Bis or current raid sets its causing the other member's gear set to change with the change that I made. I have attempted to delete the raid member from the group and re-add them same issue occurs. I attempted to remove both members however when adding them back in their gear seems to be still saved with each member having each others gear. It seems to be only happening with these two members.

Before the change

After the change

Editing each of the lines will change the other so I can't change one without the other changing.

Heya,

as soon as i use /lootmaster i get an overflow of errors in my log and then my game crashes.

this is what i get in the log ( can send more info if needed )

thanks for the awesome plugin!

Is there an option to open lootmaster without /lm?

Cause i use lmeter aswell, but it also uses /lm as chatcommand.

or am i bound to uninstall lmeter if i want to use lootmaster?

Was thinking about exporting data to other useful tools. Like

• etro.gg (for gear sets)
• GearPlanner spreadsheets by "The Balance" (for gear sets)
• Excel /Google Spreadsheet (for groups)
• An upcomming project of mine

I would like to get some feedback on how needed/wanted this would be to plan it

I just installed the plugin and tried importing BIS from etro, but it didn't import the BIS I was using, so I started changing it. Problem is, I cannot remove the last ring or the materia in it.

• Support for MultiRaidGroups & Solo/Pug Raiders [Done]
• Rework all edit windows to feature Save and cancel buttons [Done]
• Links to Etro
• Quick way to change active class of character

Basically handle player as if the got the 1st item.
Unfortunately I did not yet find a trivial way to do this. As simply ignoring the player for the secon item does not work for upgrades only unique items.
Proposed ToDos:

• Establish a way to have a copy of gear set with loot previosuly awarded
• Evaluate using this set for consecutive items