lachlan-00 / rb-fileorganizer Goto Github PK

Hi,

First, thanks for this extension, it's very useful to me.

I would like to ask you if you could add a feature, I used it back in the days with iTunes and it's the only thing missing to Rhythmbox IMO.

Let's say I have an audio file somewhere not in my library. I right-click on it and open it with Rhythmbox, then, it's automatically copied / moved (I don't know what's best, maybe an option to let the user choose) to my library in the right place using ID3 tags.

What do you think about it ?

This is a followup from this https://bugs.launchpad.net/rb-fileorganizer/+bug/1770313

I run "rhythmbox -D fileorganizer" as recommended, after fiddling a little bit with rhythmbox the terminal said that it register and then I could see the plugin.

At some point RB changed how plugin preferences work, and the fileorganizer preferences window became very broken.

Fixed in chrisgraham@b03572c

Hi,

I used to have my music library here: ~/Musique/Bibliothèque ; (Bibliothèque is the french word for Library).

I just realized my whole library is now here: ~/Musique/Biblioth%C3%A8que

I'm almost sure it's because of rb-fileorganizer, as I've ever experienced it this with Rythmbox before.

Anyway, I saw that:

1.0.3-2 features include:
[...]

• UTF-8 encoding support.

So I guess it means that UTF-8 is supported in the ID3 tags or something like that.

I'd like to know if you could support it for folders names and library path ? And so, avoid this kind of behavior. :)

Thanks !

need to look at what are the actual version requirements of the GI libraries

depends_test.py:23: PyGIWarning: Peas was imported without specifying a version first. Use gi.require_version('Peas', '1.0') before import to ensure that the right version gets loaded.
from gi.repository import GObject, Peas, PeasGtk, Gtk, Notify, Gio

depends_test.py:23: PyGIWarning: PeasGtk was imported without specifying a version first. Use gi.require_version('PeasGtk', '1.0') before import to ensure that the right version gets loaded.
from gi.repository import GObject, Peas, PeasGtk, Gtk, Notify, Gio

depends_test.py:23: PyGIWarning: Notify was imported without specifying a version first. Use gi.require_version('Notify', '0.7') before import to ensure that the right version gets loaded.
from gi.repository import GObject, Peas, PeasGtk, Gtk, Notify, Gio

depends_test.py:25: PyGIWarning: RB was imported without specifying a version first. Use gi.require_version('RB', '3.0') before import to ensure that the right version gets loaded.
from gi.repository import RB

mutagen seems to have support for python 3 without any additional changes/packages.

i'll have to change eyed3 to mutagen.

@fossfreedom do you have any feature you'd like implemented in the plugin?

I'm going to refactor the code and remove the tagging cause it was hacky and eyed3 still doesnt support python3 properly.

just do movement/db management and do it well.

I'll try and comment it better and make it easier for other people to read it.

I installed the plugin using the deb. It did not like that the dependency python-eyed3 did not exist. I change the dependency from python-eyed3 to python-eyed3 | python3-eyed3 (to make the dependency from one of both, and it worked with no fault) on the control file. I do not know how to modify that file, if I do I will provide a patch.

Some albums start with a ".", this causes the folder to be hidden when the organizer is used. I'm guessing that this also applied to other information (ie artist, song name, etc.)

I was using the version where adcebf4 is the last commit.

Information from fileorganizer.log:

Britney Spears - ...Baby One More Time - 08:59:07 AM
    IN:    /home/carelessproperty/Music/Music_on_Windows/Britney Spears/_..Baby One More Time/11 The Beat Goes On.mp3
    OUT:   /home/carelessproperty/Music/Music_on_Windows/Britney Spears/...Baby One More Time/Britney Spears (...Baby One More Time) - 11 - The Beat Goes On.mp3
 ** INFO:  Updating Database:
    OUT:   file:///home/carelessproperty/Music/Music_on_Windows/Britney%20Spears/...Baby%20One%20More%20Time/Britney%20Spears%20(...Baby%20One%20More%20Time)%20-%2011%20-%20The%20Beat%20Goes%20On.mp3
 ** INFO:  Removing empty directory
    /home/carelessproperty/Music/Music_on_Windows/Britney Spears/_..Baby One More Time

Settings:

Looks like there is no published package for the file organizer plugin on the foxxfreedom ppa. I have literally no idea what the solution is.

In mean time I will try to install it from source 👍

Hi,

I just got this when loading FileOrganizer:

ERROR:root:Could not find any typelib for Notify
Traceback (most recent call last):
  File "/home/progval/.local/share/rhythmbox/plugins/fileorganizer-gtk3/fileorganizer.py", line 17, in <module>
    from gi.repository import GObject, Peas, PeasGtk, Gtk, Notify

Installing gir1.2-notify-0.7 fixed it, but it should be mentionned somewhere.

The "Organize Selection" option disappears from the right-click menu every time I restart Rythmbox. In order to bring it back, I have to disable the plugin, restart Rythmbox, and then re-enable the plugin.

"make install" will not work, as you have README.md not README.

I have fixed in:
chrisgraham@b03572c

"Remove Empty Folders" will not work if "File/Folder Cleanup" is not enabled, and the preferences UI does not make this clear.

And then there's the moving of non-music files, which HAS to happen if "File/Folder Cleanup" is on.

I think it makes more sense to have a "Remove Empty Folders" option and a "Move Associated Files" option, as really the two things you do under "File/Folder Cleanup" are pretty different things and I see no reason to have a parent option to them.

And all this said, the moving of non-music files is very dangerous, because the user may be reorganizing stuff that is not under a deep directory yet. E.g. ~/Music/example.mp3. Any other files in ~/Music, e.g. random playlist files, will get moved with it.

Hi,

The problem described in #16 is back.

My library folder is ~/Musique/Bibliothèques/Musique. When I click on Organize selection, it'll create new folders in ~/Musique/Biblioth%C3%A8ques/Musique. But, unlike in #16, the songs are not moved to this new folder, they are unchanged in ~/Musique/Bibliothèques/Musique.

Hi,

I don't remember how I installed rb-fileorganizer the first time. But I try to install it from the git repo today, and, when I use:

python3 ./install.py

It works.

But, if I try to do it with:

make install

I've got this error:

[...]
cp template/*.conf "/home/leo/.local/share/rhythmbox/plugins/fileorganizer/"template -f
cp: impossible d'évaluer 'template/*.conf': Aucun fichier ou dossier de ce type
Makefile:7 : la recette pour la cible « install-req » a échouée

Line 3 means: no file or folder with this name.
Line 4 means: the recipe for the target "install-req" failed

So, I guess this folder and file(s?) used to be here in previous releases and the Makefile wasn't updated.

But, as it's the first way explained in the README.md, you should maybe remove it (as installing with install.py is fine) or fix it ?

Fresh installation of:
Description: Ubuntu 14.04.1 LTS
Release: 14.04
Codename: trusty

I open rhythmbox from a command line and when I try to enable the plugin it does not appear and the following error is shown to the stderr:

(rhythmbox:5923): libpeas-WARNING **: Could not find loader 'python' for plugin 'fileorganizer'

I had problem organizing with special characters in file and directories.
Its more a problem in shutil (python 3.8) but I made it work by modifying fileops.py.
Adding:
if not os.path.isdir(os.path.dirname(destin)): os.makedirs(os.path.dirname(destin))
before
shutil.move(source, destin)

For example
IN: /N/iTunesClassés/Music/Compilations/Hits 60's & 70's/07 I'm Not In Love (Acoustic).mp3
OUT: /N/iTunesClassés/Music/10cc/Hits 60's & 70's/I'm Not In Love (Acoustic).mp3