leaguesharp / leaguesharp.sdk

License

Copyright 2015 - 2015 LeagueSharp LeagueSharp/SDK is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by Free Software Foundation, either version 3 of the License, or at your option) any later version.

LeagueSharp/SDK is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.

You should have received a copy of the GNU General Public License along with LeagueSharp/SDK. If not, see http://www.gnu.org/licenses/

Contributing

We love pull requests! Here's a simple guide on how to get started.

1. Fork and clone LeagueSharp.SDK

git clone [email protected]:LeagueSharp/LeagueSharp.SDK.git

2. Push to your fork, and submit a PR("pull request")

Here are some tips to get your pull request accepted.

• Test your code.
• Follow C# Coding Conventions.
• Write a good commit message, that briefly explains the changes you made.
• Try your best not to spam commit messages.

Now after this, we will review the changes, ask you to change certain things, and then accept/deny the pull request.

leaguesharp.sdk's Issues

UI adjustments

• Improve notifications and add new flex design with the hud changes.
• Improve Damage Indicator, add custom attributes (design/view) and add toggleable option to menu.

Count Allies/Enemies in range takes too much time

Average tick count is around 650 while using CountAlliesInRange or CountEnemiesInRange.

• Distance measurement takes: 6 ticks (~average)
• Distance measurement for 4 other members would take around (6*4 = 24)
• We are losing around 626~ ticks per measurement.

Solution: Add cached enemies/allies and loop through that list, check if they are Valid & Visible, should decrease greatly the tick requirements and increase performance.

no attack plante 6.22

Can you update for dont attack plante please, thanks

Somewhere along the way, Core/Enumerations/CollisionableObjects.cs was lost (blame .gitignore)

What I mean by that is, regardless of being added forever ago, there never was a file associated with it (not like I looked that much, but I'ma assume).

Thankfully, it's just an enum. I'd submit this as a pull request, but..

Edit:
I FOUND THE ISSUE.

In .gitignore: *obj* (it's in the first set of ignore stuff from eclipse)

Missleading Names IsUnderTurret

trollolololo

IsFacing & IsBothFacing

Returns incorrect values, need to be checked.

Add Sprites to List

When Sprites are added to SDK

Menu Issues

• If you press laneclear hotkey 'V' and press SHIFT, letting go of the hotkey 'V' while holding SHIFT still triggers the hotkey 'V'.
• Interacting with MenuList dropdown sometimes interacts with underlying components.
• MenuKeyBind: bug with recognizing CTRL as a standalone keybind.
• MenuKeyBind: make a Timer interaction
• When pressing combine Shift+Enter it will toggle Menu
• MenuKeyBind: save the active state
• General: retrieve preferred show/toggle keybinds from the loader

Notifications text shortening code bug

Basically https://github.com/LeagueSharp/LeagueSharp.SDK/blob/master/Core/UI/INotifications/Notification.cs#L310-330
throws errors

Ambigious extensions

Hello, I would like to report that

https://github.com/LeagueSharp/LeagueSharp.SDK/blob/master/Third_Party/MoreLinq/ForEach.cs

is ambigious to

https://github.com/LeagueSharp/LeagueSharp.SDK/blob/master/Core/Extensions/Enumerable.cs#L112

Could this be sorted out, please?

Orbwalker Missing minions

Sometimes it attack the minion which will die before you can lasthit or not predict correctly the damage

Orbwalker adjustments

• Run performance tests
• Add special "minions" to attack and create a proper logic to issue order onto special "minions".