leaguesharp / leaguesharp.sdk Goto Github PK

Can you update for dont attack plante please, thanks

• Improve notifications and add new flex design with the hud changes.
• Improve Damage Indicator, add custom attributes (design/view) and add toggleable option to menu.

When Sprites are added to SDK

• Run performance tests
• Add special "minions" to attack and create a proper logic to issue order onto special "minions".

• If you press laneclear hotkey 'V' and press SHIFT, letting go of the hotkey 'V' while holding SHIFT still triggers the hotkey 'V'.
• Interacting with MenuList dropdown sometimes interacts with underlying components.
• MenuKeyBind: bug with recognizing CTRL as a standalone keybind.
• MenuKeyBind: make a Timer interaction
• When pressing combine Shift+Enter it will toggle Menu
• MenuKeyBind: save the active state
• General: retrieve preferred show/toggle keybinds from the loader

trollolololo

Average tick count is around 650 while using CountAlliesInRange or CountEnemiesInRange.

• Distance measurement takes: 6 ticks (~average)
• Distance measurement for 4 other members would take around (6*4 = 24)
• We are losing around 626~ ticks per measurement.

Solution: Add cached enemies/allies and loop through that list, check if they are Valid & Visible, should decrease greatly the tick requirements and increase performance.

What I mean by that is, regardless of being added forever ago, there never was a file associated with it (not like I looked that much, but I'ma assume).

Thankfully, it's just an enum. I'd submit this as a pull request, but..

Edit:
I FOUND THE ISSUE.

In .gitignore: *obj* (it's in the first set of ignore stuff from eclipse)

Sometimes it attack the minion which will die before you can lasthit or not predict correctly the damage

Basically https://github.com/LeagueSharp/LeagueSharp.SDK/blob/master/Core/UI/INotifications/Notification.cs#L310-330
throws errors

Returns incorrect values, need to be checked.

Hello, I would like to report that

https://github.com/LeagueSharp/LeagueSharp.SDK/blob/master/Third_Party/MoreLinq/ForEach.cs

is ambigious to

https://github.com/LeagueSharp/LeagueSharp.SDK/blob/master/Core/Extensions/Enumerable.cs#L112

Could this be sorted out, please?